Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 4 May 2020 10:03:00 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     wu000273@umn.edu
Cc:     davem@davemloft.net, Markus.Elfring@web.de,
        oss-drivers@netronome.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, kjlu@umn.edu
Subject: Re: [PATCH v3] nfp: abm: Fix incomplete release of system resources
 in nfp_abm_vnic_set_mac()
Message-ID: <20200504100300.28438c70@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20200503204932.11167-1-wu000273@umn.edu>
References: <20200503204932.11167-1-wu000273@umn.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun,  3 May 2020 15:49:32 -0500 wu000273@umn.edu wrote:
> From: Qiushi Wu <wu000273@umn.edu>
>=20
> In function nfp_abm_vnic_set_mac, pointer nsp is allocated by nfp_nsp_ope=
n.
> But when nfp_nsp_has_hwinfo_lookup fail, the pointer is not released,
> which can lead to a memory leak bug. Thus add a call of the function
> =E2=80=9Cnfp_nsp_close=E2=80=9D for the completion of the exception handl=
ing.
>=20
> Fixes: f6e71efdf9fb1 ("nfp: abm: look up MAC addresses via management FW")
> Signed-off-by: Qiushi Wu <wu000273@umn.edu>

This just makes the code longer. v1 was perfectly fine, thanks for the
fix.=20