Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3900087ybz;
        Mon, 4 May 2020 11:46:55 -0700 (PDT)
X-Google-Smtp-Source: APiQypIIfal/NqYgTSLyHDU15kPDtJNJFBflpwb4xEgBLMWgCxsIDNem/f56mnj+Stf2ZYORd7At
X-Received: by 2002:a17:906:d10b:: with SMTP id b11mr4861497ejz.62.1588618015106;
        Mon, 04 May 2020 11:46:55 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1588618015; cv=none;
        d=google.com; s=arc-20160816;
        b=MtWcgOA1v9ghAwFHGfPhaFSJKZM91QB3848dnnB+8lfOEuig1ShsmcpMr0i9CqzGAE
         95sbjFVnfWfwHYp8d7udT17GJ4LK0xyMCktnc+Qt1QNU4qynCVjb8kAtW6IuV/jrIGE3
         z+uRt0u5WCpfzhn3Wj5eWLo9hXnRJLRqVMd0s9O3Wx5wsTGhQlWamUDeIvJS3tjRKpaf
         jykPCVcd/QkvIq6oz80HOYXo8Cz/hsWA45BCnB3s3awJ83A4Bp5awWJL8goB3bVygz+Y
         Fhjt3wlHKJ1RYe7jU39b6TBLeyJdlOWeB2Y7H3TA54N+2SA2MWXkz0yBWBiygMN1Aozb
         soHg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:from:subject:cc:to:message-id:date;
        bh=LX910hUJjDWh7JDBujXJ30VT4EN+e3gZuem6b/S9ipE=;
        b=UwjoiTo9uOGEcvyp7yV0w5eOLjB9xCN/+IQmSxpShnrV9eSo9fRCZePOzBuuC7SfZf
         HSPl1/R3WrOsoWuVVPs3993XiYDmHhGaEdutZhbbAS6Yj8oOnvNJa3ShBGA3G6eZfLIw
         Vt9rjYu1x6ysv9F+g0dTnVIpS2fp4pBi/pRLoyM4Pqehosdr6fySrVEotoPysYaZXy5s
         gDlFOgieo4eFOz88IsnVdeNWnk2uNwmXR+zrb4beyBS/l8SmoJkq0JQ35jFVf20paBJS
         sLNm7BfxyLhYyyMoqUMMLIrNe7xtM102eFjCP82XAjB4HLSD21zdrZzqdFo7JMq4qDAb
         TUcA==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id z10si7053106ede.211.2020.05.04.11.46.31;
        Mon, 04 May 2020 11:46:55 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1730359AbgEDReL (ORCPT <rfc822;carmate383@gmail.com>
        + 99 others); Mon, 4 May 2020 13:34:11 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52826 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL)
        by vger.kernel.org with ESMTP id S1729549AbgEDReK (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 4 May 2020 13:34:10 -0400
Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 922B2C061A0E;
        Mon,  4 May 2020 10:34:10 -0700 (PDT)
Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id E8138148FE64F;
        Mon,  4 May 2020 10:34:09 -0700 (PDT)
Date:   Mon, 04 May 2020 10:34:09 -0700 (PDT)
Message-Id: <20200504.103409.787413834519966204.davem@davemloft.net>
To:     mmrmaximuzz@gmail.com
Cc:     peppe.cavallaro@st.com, alexandre.torgue@st.com,
        joabreu@synopsys.com, mcoquelin.stm32@gmail.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] stmmac: fix pointer check after utilization in
 stmmac_interrupt
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20200504062639.GA11585@maxim-hplinux>
References: <20200504062639.GA11585@maxim-hplinux>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 04 May 2020 10:34:10 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Maxim Petrov <mmrmaximuzz@gmail.com>
Date: Mon, 4 May 2020 09:26:43 +0300

> The paranoidal pointer check in IRQ handler looks very strange - it
> really protects us only against bogus drivers which request IRQ line
> with null pointer dev_id. However, the code fragment is incorrect
> because the dev pointer is used before the actual check which leads
> to undefined behavior. Remove the check to avoid confusing people
> with incorrect code.
> 
> Signed-off-by: Maxim Petrov <mmrmaximuzz@gmail.com>

Applied, thanks.