Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3901887ybz; Mon, 4 May 2020 11:48:59 -0700 (PDT) X-Google-Smtp-Source: APiQypJ+oIbcUGtXekziL+loCTUs+JRV7nW3FVe6HOhHsbYhGLz2/o6SKyoYlV31WiSnKWXtnnxW X-Received: by 2002:a17:906:7204:: with SMTP id m4mr16626641ejk.48.1588618139794; Mon, 04 May 2020 11:48:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588618139; cv=none; d=google.com; s=arc-20160816; b=RAZsGJ1GXzpytFgZr0inOYTLMxqJaYvKQLlaFw8nyK+umNuD89IgUbtup8rOr4m3/3 6EbNJGNQK2JYTKso0g2VOQQXmPapltNfLpvPwKC5a3FMcsDsLJROVKv1R148ZxPgS6iP STECM97xSpd6xi45M8x/YFHCV67k3P3OCAx3DkdX2D5Bh2H/w7D0D97nF5bryi3ror5d IvoZXCMAVBry45GYejAaTe+InjGGD8Ch4cfRjupmVPhP76KuIbWwkDGZbT3sQwrhV9aM 7IdD9UU1YGdtZiSYYoGcXzKSbJWYgzY8wPychwF3EET/50+jJMXpnn4jK46zDzLIjv4R 7WDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=eHdO2m8kGFHychUt/pCouz5KTbawVdeD7kvg7V3H+8E=; b=aZeO3oZnha2ArRhfO1vp4nqgO7vXsqdfUg8A2+RzlcMy32OH3r33TC4QRryEJT5ww9 X1o+TbyVGEPHF12ugAP0TDPtEDB71g14b10ilki11P1m83vqV8m26GLbWnksEl02oBQb JWSuKuuyDsqVhccCAD5vaaHXi0Yd/ISzfg7QBPI7ODNmociiu6aKoTXahwhvuF7CRyLV YkttNgB6Rtq8GFn8PmGAbX8KsmyV5JYirDBzUeFSd6q7x4qZH8YX7wUS5+AcJf5nGBHd McvxCubx/m+vYXKMk1kZC+BNzTWj4pMHLSesoTkVWkBzX1c6ham1QZo9abt1lnmvGoQR dHHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NqAZCIXS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m14si7784329ejb.514.2020.05.04.11.48.36; Mon, 04 May 2020 11:48:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NqAZCIXS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731470AbgEDSHI (ORCPT + 99 others); Mon, 4 May 2020 14:07:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:37716 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732069AbgEDSHF (ORCPT ); Mon, 4 May 2020 14:07:05 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 02EB520721; Mon, 4 May 2020 18:07:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588615625; bh=fLIVL3sjse+37SzZ0JN8pjVguV51V/e7QehVdNR5FHU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NqAZCIXSpqrlfa2VKwh346yokR0Do1KovWfB+RdlzqdusMqd4IR9AuH9XcASqBOZi AlgK3MOKzgb/vZqLey478JZ5+PzC2fmL3YeTEuknQKj6X7JD7i/5/u1J0zyF33eyX/ MsiJN6TOmGoNcTIVOS7yXwhS+HPgPG1pFPi0c5BY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Grygorii Strashko , Peter Ujfalusi , Vinod Koul Subject: [PATCH 5.6 57/73] dmaengine: ti: k3-psil: fix deadlock on error path Date: Mon, 4 May 2020 19:58:00 +0200 Message-Id: <20200504165509.601260333@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200504165501.781878940@linuxfoundation.org> References: <20200504165501.781878940@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Grygorii Strashko commit 172d59ecd61b89f535ad99a7e531c0f111453b9a upstream. The mutex_unlock() is missed on error path of psil_get_ep_config() which causes deadlock, so add missed mutex_unlock(). Fixes: 8c6bb62f6b4a ("dmaengine: ti: k3 PSI-L remote endpoint configuration") Signed-off-by: Grygorii Strashko Acked-by: Peter Ujfalusi Link: https://lore.kernel.org/r/20200408185501.30776-1-grygorii.strashko@ti.com Signed-off-by: Vinod Koul Signed-off-by: Greg Kroah-Hartman --- drivers/dma/ti/k3-psil.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/dma/ti/k3-psil.c +++ b/drivers/dma/ti/k3-psil.c @@ -27,6 +27,7 @@ struct psil_endpoint_config *psil_get_ep soc_ep_map = &j721e_ep_map; } else { pr_err("PSIL: No compatible machine found for map\n"); + mutex_unlock(&ep_map_mutex); return ERR_PTR(-ENOTSUPP); } pr_debug("%s: Using map for %s\n", __func__, soc_ep_map->name);