Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3903262ybz; Mon, 4 May 2020 11:50:37 -0700 (PDT) X-Google-Smtp-Source: APiQypJYT1Tll1VPiupIPeT4npQLLMn+Dr6KgKC1ZO4hBGzITkFG/H2nxRLgoF7JwxUbaNEnwv5/ X-Received: by 2002:a50:ec0c:: with SMTP id g12mr16283432edr.140.1588618237559; Mon, 04 May 2020 11:50:37 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1588618237; cv=pass; d=google.com; s=arc-20160816; b=iG/MTrXNF6XmKx2O48pDr7FeDhi2kD4svLwlpBbM6JVFPqZRglDMkQYfZFpi388JVw cZUbCGA9xTdblbGngCvSV/ihSf+5imrYjo8S9XzrnXqfIjY37t/CzTWpkwVdgMQE17jM CJgsxYHRKusfvdX+KWa4wZwSYi0MhhCBpssbSfaFqv3uvImSS47msy6/HnlHCHMs0GYp 8MDtfvEPVOcDT41VKUZ7tBzMUCGE9NZYoPdhwb7L4NOrAFd+DggKdtVPJpHvbXMZv11O XFHedpWD8c0KF38skuC445xtK8t4nFQyFAJNEXue1SUXlPMYOp16GbZuqXRy20437fG5 nlmA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=miipEusqqMCmqMkM4ve9p/HqlnJj3kVNpnKtXZyRB4g=; b=SerM2HLJ5eRBxUbhp+aPIinYtDut4kScIFnwV5oP6+B04N+dnzlZhKJG1BrJk6QGVC ishjz/oVpZY2fWNf95cXutbzNAqoT5MBI/dnjFrMiRltXRBOFuTGgH7KQ3gAJ5gM2w3U OWT2osHAv2WsSuuqQmp5Yxtzul8omCcbErISQMPI8Y5SAkI2i2JTTYDQIySuNw28XjLL jRwRPgQtgmIcdG38fr6N9Gwa4K3ix3p3lDo/+KsCaFjXtePI6iuCjEoKitjGe4EsXFR6 cypYl6hNcRYIei+8H40tONugsxKa6Zlt4a4ERtedvFXNwtzwqGiuJzbmaXFJIbBeO5TJ Barw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@xilinx.onmicrosoft.com header.s=selector2-xilinx-onmicrosoft-com header.b="X/45APEm"; arc=pass (i=1 spf=pass spfdomain=xilinx.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d1si6709749edj.453.2020.05.04.11.50.12; Mon, 04 May 2020 11:50:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@xilinx.onmicrosoft.com header.s=selector2-xilinx-onmicrosoft-com header.b="X/45APEm"; arc=pass (i=1 spf=pass spfdomain=xilinx.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727827AbgEDSoE (ORCPT + 99 others); Mon, 4 May 2020 14:44:04 -0400 Received: from mail-eopbgr760057.outbound.protection.outlook.com ([40.107.76.57]:53730 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727815AbgEDSoD (ORCPT ); Mon, 4 May 2020 14:44:03 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mYa7PnnbBZPdiXGDRlfC9uM1JPxGZv+HJqhcR1Qp1F5Y8+5fMv20pDYIbtxIZGSaig7CvAb5W+j/cPOlWca0yg6qISf/JwxJT2qWr/i3vmbWQdqtkZb48Lir7h/IrjAQ2p2AqYSLWQJiMcAzZhuDFK13SyYQXXmOcezcoNnJsuzlKp2TVyp44cX/KsyE6dcCMFYuSojs9dJ4FO/rKrtWd+6oP1U53fec5TY06cz5LThgdf3EYrpNsUG/6qVSralQ4kjL47SRrPqMBLsUctgpfrKj1OzOsAjv+epzV81ABefNWH95Uw5vGNgUKqtH5ocvgBpftniL8RVFYQVc+qmoVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=miipEusqqMCmqMkM4ve9p/HqlnJj3kVNpnKtXZyRB4g=; b=FKLO2jqvq/33EDcxvDDG5aFyrcmdOhveTDCxWZU0p7shsL5o++vh/vhtw2OTSi2Hhfq+/dFOgG2+PcW2YyqkSbqqC6p2IlZcx3GE0yRnJd0sXMfvruStZTEgWlEKqq0Bcwb7+zE2s/qqzXKRHEPg2ABbJwtfpEM65CpDVyLe73NnURdNjGV8cc70dqYzhZ51R96BgEanzRTQd2tWrOrB1kFWmFNoSsym9Dc2uhqC7TbODDKgjXMWSuC5UHXLdMZhCO+pmGNeYSIov77seSiEXicUyqUlCCGbi+RK2W9D19dO5Axd4X7p5roRz+xvsnwnI8f18ZvpFuTj1VUcm+yQVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.60.83) smtp.rcpttodomain=ideasonboard.com smtp.mailfrom=xilinx.com; dmarc=bestguesspass action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=miipEusqqMCmqMkM4ve9p/HqlnJj3kVNpnKtXZyRB4g=; b=X/45APEm2HBoyFE3vvEUeo26IsEsuOdYqRpCVQSblsp5UEsqeUncyLd4ijR+RvYPRGjC1D3KPSKKpnNCygm3eQUDtr2H391HGhK/WAzeD8j1HVsP7HlEzSKup8yaAbvfDuZynZHPHmgMYGB638Od6lJEjtNXA2mVpMZF7ZAMmmw= Received: from MN2PR01CA0028.prod.exchangelabs.com (2603:10b6:208:10c::41) by DM6PR02MB6252.namprd02.prod.outlook.com (2603:10b6:5:1d2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.19; Mon, 4 May 2020 18:43:57 +0000 Received: from BL2NAM02FT011.eop-nam02.prod.protection.outlook.com (2603:10b6:208:10c:cafe::8d) by MN2PR01CA0028.outlook.office365.com (2603:10b6:208:10c::41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.20 via Frontend Transport; Mon, 4 May 2020 18:43:56 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; ideasonboard.com; dkim=none (message not signed) header.d=none;ideasonboard.com; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; Received: from xsj-pvapsmtpgw01 (149.199.60.83) by BL2NAM02FT011.mail.protection.outlook.com (10.152.77.5) with Microsoft SMTP Server id 15.20.2958.27 via Frontend Transport; Mon, 4 May 2020 18:43:56 +0000 Received: from [149.199.38.66] (port=59577 helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw01 with esmtp (Exim 4.90) (envelope-from ) id 1jVg4D-0004QZ-TI; Mon, 04 May 2020 11:43:49 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1jVg4J-0007c4-Q6; Mon, 04 May 2020 11:43:55 -0700 Received: from [172.19.2.244] (helo=localhost) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1jVg4C-0007bZ-Pw; Mon, 04 May 2020 11:43:48 -0700 Date: Mon, 4 May 2020 11:43:48 -0700 From: Hyun Kwon To: Venkateshwar Rao Gannavarapu Cc: Hyun Kwon , "laurent.pinchart@ideasonboard.com" , "dri-devel@lists.freedesktop.org" , "airlied@linux.ie" , "daniel@ffwll.ch" , "linux-kernel@vger.kernel.org" , Sandip Kothari , Venkateshwar Rao Gannavarapu Subject: Re: [RFC PATCH 2/2] drm: xlnx: driver for Xilinx DSI TX Subsystem Message-ID: <20200504184348.GA3095@smtp.xilinx.com> References: <1587417656-48078-1-git-send-email-venkateshwar.rao.gannavarapu@xilinx.com> <1587417656-48078-3-git-send-email-venkateshwar.rao.gannavarapu@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1587417656-48078-3-git-send-email-venkateshwar.rao.gannavarapu@xilinx.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23620.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapsmtpgw01;PTR:unknown-60-83.xilinx.com;CAT:NONE;SFTY:;SFS:(136003)(396003)(39860400002)(346002)(376002)(46966005)(6862004)(4326008)(2906002)(478600001)(82310400002)(356005)(82740400003)(186003)(81166007)(33656002)(47076004)(26005)(107886003)(70206006)(70586007)(316002)(426003)(44832011)(30864003)(9786002)(8676002)(1076003)(6636002)(54906003)(336012)(5660300002)(8936002);DIR:OUT;SFP:1101; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 29b361fa-5a39-477a-e3e7-08d7f05b19db X-MS-TrafficTypeDiagnostic: DM6PR02MB6252: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-Forefront-PRVS: 03932714EB X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zX7F1e+5lupzGB3L3UoZhX0CoEwEbfQZZ8cmFpNNAZRit5nDQjcPxY74DYYu9URD7bFL9IKIDbvFcQ+yq/C1/srjUwnL15hvdPhsEIjf1o4wQuH4kz5MPKtDkAoik83T3dUAVdYuCHcYvSVhHCEsXOJLE2mDjDd8ujbN26/+aRaiU+iAhpN091BG0MeFo5zNcAemjQnO5JhnosTXsMlxdwIQaHrVupvmW8BYxTLbEsgp93DvAjWcJp5ElgVZUrO7XsUc1NKTyY1vBXMr7R69oQ04P643J0irauWIxEHyNGHu/f4YzbSgDqpwptNznVF0uG5p59Z41ZEM9aUKBoe21HmGRedGJsDaYSScl4c2xugevlbXW32hIh28eNmE/OyH1oLNk7cKziK5zxrV3HQUQhFP5mK6RtHB6rRbJIN4FXzQA6asIkS8Qf+wzk9uyVj+iZlcuC1CM8Y1FQ1r8Jp5N4KBveTRKE8H4pPLFVODnkrjDSgxtYWQms9yTxfdHziQoUG6A8a30LllIUFv8/hYag== X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2020 18:43:56.2675 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 29b361fa-5a39-477a-e3e7-08d7f05b19db X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB6252 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi GVRao, Thanks for the patch. Sorry for late reply. On Mon, 2020-04-20 at 14:20:56 -0700, Venkateshwar Rao Gannavarapu wrote: > The Xilinx MIPI DSI Tx Subsystem soft IP is used to display video > data from AXI-4 stream interface. > > It supports upto 4 lanes, optional register interface for the DPHY, I don't see the register interface for dphy support. > multiple RGB color formats, command mode and video mode. > This is a MIPI-DSI host driver and provides DSI bus for panels. > This driver also helps to communicate with its panel using panel > framework. > > Signed-off-by: Venkateshwar Rao Gannavarapu > --- > drivers/gpu/drm/xlnx/Kconfig | 11 + > drivers/gpu/drm/xlnx/Makefile | 2 + > drivers/gpu/drm/xlnx/xlnx_dsi.c | 755 ++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 768 insertions(+) > create mode 100644 drivers/gpu/drm/xlnx/xlnx_dsi.c > > diff --git a/drivers/gpu/drm/xlnx/Kconfig b/drivers/gpu/drm/xlnx/Kconfig > index aa6cd88..73873cf 100644 > --- a/drivers/gpu/drm/xlnx/Kconfig > +++ b/drivers/gpu/drm/xlnx/Kconfig > @@ -11,3 +11,14 @@ config DRM_ZYNQMP_DPSUB > This is a DRM/KMS driver for ZynqMP DisplayPort controller. Choose > this option if you have a Xilinx ZynqMP SoC with DisplayPort > subsystem. > + > +config DRM_XLNX_DSI > + tristate "Xilinx DRM DSI Subsystem Driver" > + select DRM_MIPI_DSI > + select DRM_PANEL > + select DRM_PANEL_SIMPLE > + help > + This enables support for Xilinx MIPI-DSI. This sentence is not needed with below. Could you please rephrase the whole? > + This is a DRM/KMS driver for Xilinx programmable DSI controller. > + Choose this option if you have a Xilinx MIPI DSI-TX controller > + subsytem. These seem incorrectly indented. > diff --git a/drivers/gpu/drm/xlnx/Makefile b/drivers/gpu/drm/xlnx/Makefile > index 2b844c6..b7ee6ef 100644 > --- a/drivers/gpu/drm/xlnx/Makefile > +++ b/drivers/gpu/drm/xlnx/Makefile > @@ -1,2 +1,4 @@ > zynqmp-dpsub-objs += zynqmp_disp.o zynqmp_dpsub.o zynqmp_dp.o > obj-$(CONFIG_DRM_ZYNQMP_DPSUB) += zynqmp-dpsub.o > + > +obj-$(CONFIG_DRM_XLNX_DSI) += xlnx_dsi.o > diff --git a/drivers/gpu/drm/xlnx/xlnx_dsi.c b/drivers/gpu/drm/xlnx/xlnx_dsi.c > new file mode 100644 > index 0000000..b8cae59 > --- /dev/null > +++ b/drivers/gpu/drm/xlnx/xlnx_dsi.c > @@ -0,0 +1,755 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Xilinx FPGA MIPI DSI Tx Controller driver > + * > + * Copyright (C) 2017 - 2019 Xilinx, Inc. > + * > + * Authors: > + * - Saurabh Sengar > + * - Venkateshwar Rao Gannavarapu > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include