Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3918739ybz;
        Mon, 4 May 2020 12:08:07 -0700 (PDT)
X-Google-Smtp-Source: APiQypKZXL2wvB40L9ZEkeCs9XNkZT9dJktJAuR750C71Pd8sw+oUkhM8RegR/5wtTHaS83c5Vrn
X-Received: by 2002:a17:907:214f:: with SMTP id rk15mr16422877ejb.301.1588619286933;
        Mon, 04 May 2020 12:08:06 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1588619286; cv=none;
        d=google.com; s=arc-20160816;
        b=j8kZcw3IizK4EUrIDOzOkhcnryjHPxqqlqsEgeoInLbEhkyQyXEqURYIDTrzUjFypr
         fhrgCrwODyykGsmaV1OPOHJ+QFEwdiZS+zdu2hnF0dXMmuU9d6M7tull103Z/j1SwOam
         q23LTQti8IRRBt1y1BsCrote15DMXrmBDsJxXVJRDfSOhcA/njcRkfZ72i/5cI1Ve/V4
         JdHkqcmefy+bJzoDwoAuBnR+6Y41MuRfyOZ5sOzFJbxE9s7mnMh9oVvQU2sr6AcQDMXy
         S4bYzt5f38RKq4FZ6rpMliwwvqywckrTfmr6hlN9CmJ3BWDgHPRUZXpcKLZurCw0N+wP
         q6tA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:from:subject:cc:to:message-id:date;
        bh=L+CUGo6BofWUHXrapl7HGmUg+S5pivk3uzlvThA3Xfo=;
        b=mt/ipoUoyne8cWtWmjmCzFuh39aPdmyKp0fAsF0xH5St7v6jQL64UFYVjY16OpWtv3
         IhJRom6Kz6X/qybJEdBMvNNFGOlDSuKHUMA86rGGCgOY10erhF/CPVltovNasNcxNGmZ
         8XPCwUMqKhzw8PPupqvsjpRvTS6YtvtiF83+a4/+h65H23QYQtYoEA2hrljLpHh1iBhc
         aPIA1QvbBsdcz5jzDVpaZLjU410/d7utChTQEPoSzWtGZ5BZ3OHhRmBaGc7RSjyQp5fo
         RxEDChUgos0oy+6Z1Ct16NYFyLa+YWBaApNj4Tj4LHSEUSTdPof1uE9FOuWUyc5W1q5X
         YQrg==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id cm18si6912984edb.130.2020.05.04.12.07.43;
        Mon, 04 May 2020 12:08:06 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727032AbgEDTF3 (ORCPT <rfc822;sbrunau@gmail.com> + 99 others);
        Mon, 4 May 2020 15:05:29 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39046 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL)
        by vger.kernel.org with ESMTP id S1726469AbgEDTF3 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 4 May 2020 15:05:29 -0400
Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49780C061A0E;
        Mon,  4 May 2020 12:05:28 -0700 (PDT)
Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id AA29211F5F61A;
        Mon,  4 May 2020 12:05:27 -0700 (PDT)
Date:   Mon, 04 May 2020 12:05:26 -0700 (PDT)
Message-Id: <20200504.120526.935588639172781549.davem@davemloft.net>
To:     wu000273@umn.edu
Cc:     kuba@kernel.org, oss-drivers@netronome.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, kjlu@umn.edu
Subject: Re: [PATCH] nfp: abm: fix a memory leak bug
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20200502224259.1477-1-wu000273@umn.edu>
References: <20200502224259.1477-1-wu000273@umn.edu>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 04 May 2020 12:05:27 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: wu000273@umn.edu
Date: Sat,  2 May 2020 17:42:59 -0500

> From: Qiushi Wu <wu000273@umn.edu>
> 
> In function nfp_abm_vnic_set_mac, pointer nsp is allocated by nfp_nsp_open.
> But when nfp_nsp_has_hwinfo_lookup fail, the pointer is not released,
> which can lead to a memory leak bug. Fix this issue by adding
> nfp_nsp_close(nsp) in the error path.
> 
> Signed-off-by: Qiushi Wu <wu000273@umn.edu>

Applied and queued up for -stable, thanks.