Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/3] dt-bindings: leds: Add binding for aw2013
To:     <nikitos.tr@gmail.com>, <pavel@ucw.cz>
CC:     <robh+dt@kernel.org>, <linux-leds@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <~postmarketos/upstreaming@lists.sr.ht>
References: <20200504162934.4693-1-nikitos.tr@gmail.com>
 <20200504162934.4693-2-nikitos.tr@gmail.com>
From:   Dan Murphy <dmurphy@ti.com>
Message-ID: <7866a778-f38a-5d65-09d6-783f3a6c555d@ti.com>
Date:   Mon, 4 May 2020 15:09:57 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <20200504162934.4693-2-nikitos.tr@gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Pavel

On 5/4/20 11:29 AM, nikitos.tr@gmail.com wrote:
> From: Nikita Travkin <nikitos.tr@gmail.com>
>
> Add YAML devicetree binding for AWINIC AW2013 3-channel led driver
>
> Signed-off-by: Nikita Travkin <nikitos.tr@gmail.com>
> ---
>   .../devicetree/bindings/leds/leds-aw2013.yaml | 91 +++++++++++++++++++
>   1 file changed, 91 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/leds/leds-aw2013.yaml
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-aw2013.yaml b/Documentation/devicetree/bindings/leds/leds-aw2013.yaml
> new file mode 100644
> index 000000000000..f118721df1e8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-aw2013.yaml
> @@ -0,0 +1,91 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/leds-aw2013.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: AWINIC AW2013 3-channel LED Driver
> +
> +maintainers:
> +  - Nikita Travkin <nikitos.tr@gmail.com>
> +
> +description: |
> +  The AW2013 is a 3-channel LED driver with I2C interface. It can control
> +  LED brightness with PWM output.
> +
> +properties:
> +  compatible:
> +    const: awinic,aw2013
> +
> +  reg:
> +    maxItems: 1
> +
> +  vcc-supply:
> +    description: Regulator providing power to the "VCC" pin.
> +
> +  "#address-cells":
> +    const: 1
> +
> +  "#size-cells":
> +    const: 0
> +
> +patternProperties:
> +  "^led@[0-2]$":
> +    type: object
> +    allOf:
> +      - $ref: common.yaml#
> +
> +    properties:
> +      reg:
> +        description: Index of the LED.
> +        minimum: 0
> +        maximum: 2
> +
> +required:
> +  - compatible
> +  - reg
> +  - "#address-cells"
> +  - "#size-cells"
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    #include <dt-bindings/leds/common.h>
> +
> +    i2c0 {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        led-controller@45 {
> +            compatible = "awinic,aw2013";
> +            reg = <0x45>;
> +            #address-cells = <1>;
> +            #size-cells = <0>;
> +
> +            vcc-supply = <&pm8916_l17>;
> +
> +            led@0 {
> +                reg = <0>;
> +                led-max-microamp = <5000>;
> +                function = LED_FUNCTION_INDICATOR;
> +                color = <LED_COLOR_ID_RED>;
> +            };
> +
> +            led@1 {
> +                reg = <1>;
> +                led-max-microamp = <5000>;
> +                function = LED_FUNCTION_INDICATOR;
> +                color = <LED_COLOR_ID_GREEN>;
> +            };
> +
> +            led@2 {
> +                reg = <2>;
> +                led-max-microamp = <5000>;
> +                function = LED_FUNCTION_INDICATOR;
> +                color = <LED_COLOR_ID_BLUE>;
> +            };
> +        };
> +    };
> +...

Would this be a good candidate for the multicolor framework?

Dan