Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4042329ybz; Mon, 4 May 2020 14:41:50 -0700 (PDT) X-Google-Smtp-Source: APiQypLmqnBe0jaAuGQEuNBnjsi46q83HyV/wmu+ierB9cMonFq1JBQXEfa+B+JAFEXcUYOV0NYZ X-Received: by 2002:aa7:c497:: with SMTP id m23mr54451edq.155.1588628510014; Mon, 04 May 2020 14:41:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588628510; cv=none; d=google.com; s=arc-20160816; b=IFQqc0jfKnMoRWG2EwG0u6WE6BEsAaBWAC7Hg9W1SUI7aT/nibZTWiUuarh9DsJG9D p/J4ppYuMzpYv962WxyGef3MTHGHIJ55rrJvcz77deKb+HZbJ2zswwQY51xl8nq/9ULd DWSlkwoFwe0w/vQ34rGFRXfbIkWu71cpg23LmKiMSCqO8YoT2u9eu6taTfPwTidrZSB1 2HupUfOKo7m0/aI2Eb61m6kS2EWcHm2G/ntpLOeU2uXvOk8vV+Lz1/Ye7lyMGZ6Zwyk0 NLqWzrl7Bi3prB9cdFjEFBhXT/EXDsK5L4OxkucxnYEkCT4qsBe1clsYFXP/WYUzs2cy WkNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=dnKlsTHwnnFXazn7zzxGnzLza7yEGHj+jI4fWn0tS74=; b=XVJ4W0oCjh3MhpfIdVQeNZorlWdIu4Zr5DrjOPfNzLMHxQAcC7LrppYKLR4AhWwEf5 JfNsWxZL0PHajkVvsY4JKcIkTyykBahglezDkedb4JVBKOxp4HtyisGaszhC28+hr/F4 c5rd9Fa9YYn24Oqk0KdptuWapZ4Jz4s7mKsrziOV+0NWieRbp+q4HDwiKtS4Zj0Eb9fV svQRzato/8mj1lKHxc+9EAs6CXipYOhrUvrLh50n3SzyQU+Ptfjs881u+nD+nqyQdY8Y nsnHjlprNOJN77Go0N0UoNaN4QIUflze3Nm++6E/foEI8HJf13QTsp/jw9j+pX6U7i4I gayA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=AynCMGGq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o59si151022eda.39.2020.05.04.14.41.26; Mon, 04 May 2020 14:41:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=AynCMGGq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726487AbgEDVjn (ORCPT + 99 others); Mon, 4 May 2020 17:39:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726338AbgEDVjm (ORCPT ); Mon, 4 May 2020 17:39:42 -0400 Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2435C061A0E; Mon, 4 May 2020 14:39:42 -0700 (PDT) Received: by mail-pl1-x641.google.com with SMTP id v2so312759plp.9; Mon, 04 May 2020 14:39:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=dnKlsTHwnnFXazn7zzxGnzLza7yEGHj+jI4fWn0tS74=; b=AynCMGGq0W5VEIeiqAdRi99uVamrPcFWpeWEkJSSFpofFC9z+cTdg2BqY7IQs4bIPZ GSqk0NDj1De6v3E6B8hD69oAQTlbDvt1Lx9cjx93XUcfEwcebbSsgHRMtF4qhLb0jzZX itI0Q8Kr1odj5D/nJN/BpvPDndUDGVSMkPUzjR5fkCIsZ0cHYIyF0GBIi0buzkkIVTYX vyMUc8KMOGVroi9h+Rt1Zocd5gnzZOxcPjMnShu3prz33cm7yAKqGlvhXPLfJHUQyMp3 L/RalKi4lfErm0MP9laMKgQi1WBfOL73oLxLBoIMe2Umoj52vUyX7Fb2Vn9QenyLud+5 JzTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=dnKlsTHwnnFXazn7zzxGnzLza7yEGHj+jI4fWn0tS74=; b=iV3tvBC1dV3jeoNR/aGEjrtX1IfcrmutBIRHbyiK4h676Qi7geqNU4IGGQ7/Rk81xc oUAHpzsNTVl3hWV1Xjd6q40acDqCI0LOA/kPofODUss+vw5dkXNBIOX+djzhrlDFNkz+ tK3RQ0AkKv/npFSYG9O6/SqxUZFmPfoxolT0fCnPAnM+55Q1b9HpJu1txbdkjEuUjQHf 2yaVzdQQ4L9s2dAaPmWIo9KWnBg5MuNvTxpTChgbixhQgp1MFf83KAoaXXv7sEBiJhg6 mkqlmh/jvVCJcknZwib+v89uQ84qWtduEUAWEefWiBeXqh0JmFpaAZfRPM0wymEZm5P2 r6WA== X-Gm-Message-State: AGi0PublvgyIwp1syPYhSCTmgHVbtw+G88uLFET6PPKGPC4h4Z5JNUQq KbU/iyGExz+3hyrumy5MBkg= X-Received: by 2002:a17:90b:3017:: with SMTP id hg23mr171014pjb.150.1588628381874; Mon, 04 May 2020 14:39:41 -0700 (PDT) Received: from Asurada-Nvidia (searspoint.nvidia.com. [216.228.112.21]) by smtp.gmail.com with ESMTPSA id a12sm44947pfr.28.2020.05.04.14.39.41 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 May 2020 14:39:41 -0700 (PDT) Date: Mon, 4 May 2020 14:39:05 -0700 From: Nicolin Chen To: Shengjiu Wang Cc: timur@kernel.org, Xiubo.Lee@gmail.com, festevam@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, lgirdwood@gmail.com, robh+dt@kernel.org, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] ASoC: fsl_esai: introduce SoC specific data Message-ID: <20200504213905.GA21292@Asurada-Nvidia> References: <27af074e47bf2b81e2dce67ea66a9f7301dfcb07.1588320656.git.shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <27af074e47bf2b81e2dce67ea66a9f7301dfcb07.1588320656.git.shengjiu.wang@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 01, 2020 at 04:12:04PM +0800, Shengjiu Wang wrote: > Introduce a SoC specific data structure which contains the > differences between the different SoCs. > This makes it easier to support more differences without having > to introduce a new if/else each time. > > Signed-off-by: Shengjiu Wang Though the 2nd patch is having comments to address, this one looks fine to me and should be able to merge as long as Mark is okay with this too: Acked-by: Nicolin Chen