Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp26902ybj; Mon, 4 May 2020 15:23:00 -0700 (PDT) X-Google-Smtp-Source: APiQypKndhmBH5OI9liDHtkOz70TdKgRumOPY0SzIf5NrWIIRA/tZjb4I5t8ADmF3SWEupg9sU0A X-Received: by 2002:aa7:d655:: with SMTP id v21mr176957edr.355.1588630980050; Mon, 04 May 2020 15:23:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588630980; cv=none; d=google.com; s=arc-20160816; b=oquVIKrw9g6CO/w3nG5p5Ukt5z4Oni+0r234JrHaCTZLhTuj7tTL3ap1Z8ksVNQugt L0u/VeFVoKCjQI+EnMtaAeKgszbQvrEri+seWVolMIK+sGoVh/iHP64oyOGWSGY8eavw GuaoyTbgkw/ubzVtBsBRHSms96MnKjpENWCnRHvB2cxstrsGipI22QV0EFzeBWymULcR juZ3Agh2QZtPdcI6Vf0qnly5u54TxBJjueXWAyaiTVDQtOdHPKx1b2ECNwxs3yRYuTeH IcqrYwdT4nafaCFDGK9FnoMBAPdk9y6UCeo7wHwCcm37EBNpDK73ACoWNhzQMlE1Bz/Y g1rQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date:dkim-signature; bh=2124TI3JVPSYZnL61vEJtJH218+zbkrDCXTmrjEitNE=; b=Bhwvuurel/Y31WJflGLmMnGCEvQRGcPyN/I9xBRY2SaxbiH2fb5JqjPftL/k/KIftm ycCylsYgg2ub2QUtP2aXbezqECAA0o7xStsBeyVIVrQpcullukvfAJSvduLcyNO1mlVj unGFF6H0abe0cQniwPRxN29UnRb3Z8UzfoC7HVfhe4nSXWZVGqos0dHzhDwNOIxSA8dL lZuj2tMe4i+6Tz2VgJrI5eugrTASMpeYv5sW502o9SSlBk/WQnpV8EASVUUpo9RY4bGQ k0EF0HNQs2CYsYkBTXpkXLSm13z6vPGJU/uKb854vj6eu51icNP2b7YNgmlvhy+mNMFY QfsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=gJKG6J+q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a5si6726185ejv.381.2020.05.04.15.22.35; Mon, 04 May 2020 15:23:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=gJKG6J+q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728034AbgEDWUj (ORCPT + 99 others); Mon, 4 May 2020 18:20:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:35858 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726291AbgEDWUi (ORCPT ); Mon, 4 May 2020 18:20:38 -0400 Received: from pobox.suse.cz (unknown [195.250.132.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E1514206A4; Mon, 4 May 2020 22:20:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588630838; bh=cvKz/TW55lC8yvXi3iR0AU74dO/R1dsn6RuW11AKRvc=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=gJKG6J+q/xog0qE2Xn+NjR7z/SEHm8XkPKTHfuecDO3i+xViaVIPvmcFKmSG4mGuZ +iEZdm8G4+sSjArWGnEGs+vqdKH5+dNBk8+TWL+YJilEBqyL/2ebjCGYnnAGzsUIlw 41+lRL9dAmeDeo3Qbv9/s7oIxlb72C75LK4+7IYU= Date: Tue, 5 May 2020 00:20:34 +0200 (CEST) From: Jiri Kosina To: Josh Poimboeuf cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Zijlstra , Jessica Yu , Joe Lawrence , Miroslav Benes Subject: Re: [PATCH v4 00/11] livepatch,module: Remove .klp.arch and module_disable_ro() In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 Apr 2020, Josh Poimboeuf wrote: > v4: > - Fixed rebase bisection regression [Miroslav] > - Made module_enable_ro() static [Jessica] > - Added Acked-by's > > v3: > - klp: split klp_write_relocations() into object/section specific > functions [joe] > - s390: fix plt/got writes [joe] > - s390: remove text_mutex usage [mbenes] > - x86: do text_poke_sync() before releasing text_mutex [peterz] > - split x86 text_mutex changes into separate patch [mbenes] > > v2: > - add vmlinux.ko check [peterz] > - remove 'klp_object' forward declaration [mbenes] > - use text_mutex [jeyu] > - fix documentation TOC [jeyu] > - fix s390 issues [mbenes] > - upstream kpatch-build now supports this > (though it's only enabled for Linux >= 5.8) > > These patches add simplifications and improvements for some issues Peter > found six months ago, as part of his non-writable text code (W^X) > cleanups. > > Highlights: > > - Remove the livepatch arch-specific .klp.arch sections, which were used > to do paravirt patching and alternatives patching for livepatch > replacement code. > > - Add support for jump labels in patched code (only for static keys > which live in vmlinux). > > - Remove the last module_disable_ro() usage. > > For more background, see this thread: > > https://lkml.kernel.org/r/20191021135312.jbbxsuipxldocdjk@treble > > This has been tested with kpatch-build integration tests and klp-convert > selftests. So I think this should best go through livepatching.git for 5.8. Unless anyone has a better idea or objects heavily, I'll queue it tomorrow. Thanks, -- Jiri Kosina SUSE Labs