Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932735AbWCIDFw (ORCPT ); Wed, 8 Mar 2006 22:05:52 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932736AbWCIDFw (ORCPT ); Wed, 8 Mar 2006 22:05:52 -0500 Received: from mx1.redhat.com ([66.187.233.31]:32947 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S932735AbWCIDFv (ORCPT ); Wed, 8 Mar 2006 22:05:51 -0500 Date: Wed, 8 Mar 2006 22:05:42 -0500 From: Dave Jones To: Linux Kernel Cc: raven@themaw.net Subject: Remove redundant check from autofs4_put_super Message-ID: <20060309030542.GA17851@redhat.com> Mail-Followup-To: Dave Jones , Linux Kernel , raven@themaw.net Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 870 Lines: 26 We have to have a valid sbi here, or we'd have oopsed already. (There's a dereference of sbi->catatonic a few lines above) Coverity #740 Signed-off-by: Dave Jones --- linux-2.6/fs/autofs4/inode.c~ 2006-03-08 22:02:53.000000000 -0500 +++ linux-2.6/fs/autofs4/inode.c 2006-03-08 22:03:47.000000000 -0500 @@ -145,8 +145,7 @@ static void autofs4_put_super(struct sup autofs4_catatonic_mode(sbi); /* Free wait queues, close pipe */ /* Clean up and release dangling references */ - if (sbi) - autofs4_force_release(sbi); + autofs4_force_release(sbi); kfree(sbi); -- http://www.codemonkey.org.uk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/