Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp218758ybj; Mon, 4 May 2020 19:46:36 -0700 (PDT) X-Google-Smtp-Source: APiQypLbnetpZ0DMeTqNjzyJQx21BeUh50C+ASSX6Y/fNVYva0RcCn26Mp1IQBGuNBwlp081P5iG X-Received: by 2002:a05:6402:1694:: with SMTP id a20mr799765edv.322.1588646796530; Mon, 04 May 2020 19:46:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588646796; cv=none; d=google.com; s=arc-20160816; b=PDmGI2kIQt9QS6HInop/e/bk4QtxdEdWbqE4lWgqduyeO19TSZWcI7FOvh1zR8ivLN H8EykUQKV6dw+nmovSxEgxlfRP9fNcEMBtEXNuNrH2pi3K84e/3nbsJSqTa0HlwuGy3H 9p8JzzFFzv6bi4fRHsRU4WRbJQh/Jf2yY3l3pa1GhLKy/RLBpjZE3piGtP9kps2n8ga9 50YIH+g2CBt9wUTbo6sVzwfxgisMmuew3pGq5LmhbjTcS+wTk+SCie0LZ3JgplwAf1qb Ds6+CxD3jNqrTchp2zD3lnCHjbgv/SccrRESD23tMi68EkTi+inuogCOFBmiQiTPrk9H 5d5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :dlp-reaction:dlp-version:dlp-product:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:ironport-sdr:ironport-sdr; bh=sCgFBQN/HyuZXox06KSgWhVMSABLAg4IiMtdcjV8KQU=; b=tkL/2e0p9Fp2o8sLQspyNaPszjdIBYKUTXtuR1DW017cU611BbvMjTfdSnE9uOVJOx ChwG/1FETx4kMEEWeNLtVOzeYTOhAwIxpQoFNkeIz+ojJtuT5TtSSHKMewMoIfK7AV2w 7z5LXMThoxtYAMj5k42fSln+nM8PfjnSXlTsOQizVyU7gWMiGENtAX3ZeRErEQuAGVWe EbioAUwWcrqmqUIdCnsrk2MaFs8go52J2F5uO4X9VU21VMTORGUEqDXPuL0G6C8XeUTU 4gHXjaLNC3KtB4SbreVYExcz8cpJEnO99LkhmAPaXGlRajDA2F5UTfNcJnKBMrGT7fpH kItw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s4si287025ejq.495.2020.05.04.19.46.13; Mon, 04 May 2020 19:46:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728143AbgEECoS convert rfc822-to-8bit (ORCPT + 99 others); Mon, 4 May 2020 22:44:18 -0400 Received: from mga17.intel.com ([192.55.52.151]:31648 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726516AbgEECoS (ORCPT ); Mon, 4 May 2020 22:44:18 -0400 IronPort-SDR: JrzXRH2wlqVPt8b1StdQjQi+lT7rWe1FpG9/OzilD3wjlf8ncKpJXa9QLKbyF4CqqoLli/BJ1X Y8paEsvVUJiw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2020 19:44:18 -0700 IronPort-SDR: Cw0t5scE+DXk0tAVbbTjx1prBri9H12oNtWUnV6oed9VLpZb/AFgB5T1UjJvZVQ3upKT/6HJDn rov7QaMdhCNQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,354,1583222400"; d="scan'208";a="277727970" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by orsmga002.jf.intel.com with ESMTP; 04 May 2020 19:44:18 -0700 Received: from orsmsx151.amr.corp.intel.com (10.22.226.38) by ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 4 May 2020 19:44:17 -0700 Received: from orsmsx112.amr.corp.intel.com ([169.254.3.248]) by ORSMSX151.amr.corp.intel.com ([169.254.7.25]) with mapi id 14.03.0439.000; Mon, 4 May 2020 19:44:17 -0700 From: "Kirsher, Jeffrey T" To: Xie XiuQi , "davem@davemloft.net" CC: "intel-wired-lan@lists.osuosl.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH net-next] ixgbe: fix signed-integer-overflow warning Thread-Topic: [PATCH net-next] ixgbe: fix signed-integer-overflow warning Thread-Index: AQHWIoaqP7B4wK9mpEeCjVZHIrr8naiYyOWg Date: Tue, 5 May 2020 02:44:17 +0000 Message-ID: <61CC2BC414934749BD9F5BF3D5D94044986886BA@ORSMSX112.amr.corp.intel.com> References: <20200505024521.24635-1-xiexiuqi@huawei.com> In-Reply-To: <20200505024521.24635-1-xiexiuqi@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.138] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Xie XiuQi > Sent: Monday, May 4, 2020 19:45 > To: Kirsher, Jeffrey T ; davem@davemloft.net > Cc: intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org > Subject: [PATCH net-next] ixgbe: fix signed-integer-overflow warning > > ubsan report this warning, fix it by adding a unsigned suffix. > > UBSAN: signed-integer-overflow in > drivers/net/ethernet/intel/ixgbe/ixgbe_common.c:2246:26 > 65535 * 65537 cannot be represented in type 'int' > CPU: 21 PID: 7 Comm: kworker/u256:0 Not tainted 5.7.0-rc3-debug+ #39 > Hardware name: Huawei TaiShan 2280 V2/BC82AMDC, BIOS 2280-V2 > 03/27/2020 > Workqueue: ixgbe ixgbe_service_task [ixgbe] Call trace: > dump_backtrace+0x0/0x3f0 > show_stack+0x28/0x38 > dump_stack+0x154/0x1e4 > ubsan_epilogue+0x18/0x60 > handle_overflow+0xf8/0x148 > __ubsan_handle_mul_overflow+0x34/0x48 > ixgbe_fc_enable_generic+0x4d0/0x590 [ixgbe] > ixgbe_service_task+0xc20/0x1f78 [ixgbe] > process_one_work+0x8f0/0xf18 > worker_thread+0x430/0x6d0 > kthread+0x218/0x238 > ret_from_fork+0x10/0x18 > > Reported-by: Hulk Robot > Signed-off-by: Xie XiuQi > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Dave, I am picking this up.