Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932251AbWCIE1x (ORCPT ); Wed, 8 Mar 2006 23:27:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932670AbWCIE1x (ORCPT ); Wed, 8 Mar 2006 23:27:53 -0500 Received: from mx1.redhat.com ([66.187.233.31]:32221 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S932251AbWCIE1w (ORCPT ); Wed, 8 Mar 2006 23:27:52 -0500 Date: Wed, 8 Mar 2006 23:27:44 -0500 From: Dave Jones To: Linux Kernel Subject: filldir[64] oddness Message-ID: <20060309042744.GA23148@redhat.com> Mail-Followup-To: Dave Jones , Linux Kernel Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 933 Lines: 27 I'm puzzled by an aparent use of uninitialised memory that coverity's checker picked up. fs/readdir.c #define NAME_OFFSET(de) ((int) ((de)->d_name - (char __user *) (de))) #define ROUND_UP(x) (((x)+sizeof(long)-1) & ~(sizeof(long)-1)) 140 static int filldir(void * __buf, const char * name, int namlen, loff_t offset, 141 ino_t ino, unsigned int d_type) 142 { 143 struct linux_dirent __user * dirent; 144 struct getdents_callback * buf = (struct getdents_callback *) __buf 145 int reclen = ROUND_UP(NAME_OFFSET(dirent) + namlen + 2); How come that NAME_OFFSET isn't causing an oops when it dereferences stackjunk->d_name ? Dave -- http://www.codemonkey.org.uk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/