Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH net v1] net: broadcom: fix a mistake about ioremap
 resource
To:     Dejin Zheng <zhengdejin5@gmail.com>, davem@davemloft.net,
        swboyd@chromium.org, ynezz@true.cz, netdev@vger.kernel.org,
        jonathan.richardson@broadcom.com
Cc:     linux-kernel@vger.kernel.org,
        Scott Branden <scott.branden@broadcom.com>,
        Ray Jui <ray.jui@broadcom.com>
References: <20200505020329.31638-1-zhengdejin5@gmail.com>
From:   Florian Fainelli <f.fainelli@gmail.com>
Message-ID: <8b71b3ba-edc8-ce78-27ba-ce05230efc31@gmail.com>
Date:   Mon, 4 May 2020 20:28:52 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Firefox/68.0 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <20200505020329.31638-1-zhengdejin5@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 5/4/2020 7:03 PM, Dejin Zheng wrote:
> Commit d7a5502b0bb8b ("net: broadcom: convert to
> devm_platform_ioremap_resource_byname()") will broke this driver.
> idm_base and nicpm_base were optional, after this change, they are
> mandatory. it will probe fails with -22 when the dtb doesn't have them
> defined. so revert part of this commit and make idm_base and nicpm_base
> as optional.
> 
> Fixes: d7a5502b0bb8bde ("net: broadcom: convert to devm_platform_ioremap_resource_byname()")
> Reported-by: Jonathan Richardson <jonathan.richardson@broadcom.com>
> Cc: Scott Branden <scott.branden@broadcom.com>
> Cc: Ray Jui <ray.jui@broadcom.com>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: David S. Miller <davem@davemloft.net>
> Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian