Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp274118ybj; Mon, 4 May 2020 21:12:23 -0700 (PDT) X-Google-Smtp-Source: APiQypJ4HlT6bMv5W6Dv+0O35q6fzWTpI0wPaBfB1MvHPXFmdHw4/e8eTkcjWBAA2OMvW4HPUaNR X-Received: by 2002:aa7:dacc:: with SMTP id x12mr968467eds.363.1588651943376; Mon, 04 May 2020 21:12:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588651943; cv=none; d=google.com; s=arc-20160816; b=xNObXyqDtw6ouRMqhcR7Ki4WFPuhKUfl86EGboWUgdLJpr5z/TskP9EsbMclpiYqWe 96ermipNKn/o1iuVLc01H0kofojPlhVg9Fd15cV267BZmxPpnBZDIJPNTa8EsecpjAeo ryyjaXbOmiAVmOh2178gerk1NDZLegAQXZNx84kF7f5hEPnGxRMVC67QlO3GiQeKQ36k A/f1OJcKuH6V/uFrF9Iktj43FtxPGwXY+vgqMHQ3MIKpQ2nCsF+U3712gYKyUwp7fnHg ZgCOmELXag4FR6WbvO0ue/MRwroCoUW5XsKVJ59/jOr8Qe29Gp2ivm/3dFiFGs3PH/fg mIdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=DoqDXH/3ekdVQe0eRy5uE4ovem02TnuS1+gpXK1aVCA=; b=V3QtI7J5CafAiIzzZVUWyugCrCIHkMWX++SWYdS9hUa53VbgAik96Ax0i5E/v9uMDL Ft5XT5pWLt7iJEJCnft28Auja5tSllqB5p02GL4WFrUdh4qB6+7+GDlfEXFK7RR7QS79 ClFkY2RJhgpWtIWjc5+rB4bXvdeUiseWFMFgao4sGg4TR18jV/iFG9JSrIkJCxs8Bk7w xDEQ4U4HgD9bNDfpOmCXB0nqWDFG+7fs8Cm0840p9OZeo6PnAT/zdq1mKVLwrsZ46hDg RpnzdVElJ9PB+Td5jcQDwG0/vxmwl8t+OSLsziDYGXeKrYvkUEjiOxaZZY38g9NiwRSU uV6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=E2iBL7r3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a19si533448edr.254.2020.05.04.21.11.59; Mon, 04 May 2020 21:12:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=E2iBL7r3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726774AbgEEEKa (ORCPT + 99 others); Tue, 5 May 2020 00:10:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725272AbgEEEK3 (ORCPT ); Tue, 5 May 2020 00:10:29 -0400 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4AA8C061A0F; Mon, 4 May 2020 21:10:29 -0700 (PDT) Received: by mail-pl1-x643.google.com with SMTP id f15so301782plr.3; Mon, 04 May 2020 21:10:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=DoqDXH/3ekdVQe0eRy5uE4ovem02TnuS1+gpXK1aVCA=; b=E2iBL7r3i7+fGgkaDSkcdr4xgJYIvdXvpfhukXGhunJilBnuw2i0wDcSl40PTZOsBh 9Cl2lWM6wdwbQ9wCJsGL0yEqO3efdvcGWpX3xo7jwgbqZxP7QOcELhwahRU2WxGcpCGr yEjSY+wM77i0QDEaOUedNPwDTD5+oVdAjhEdQOePFpFiffr/SIF8er1WB50+FVWI2TlG +fYq7qtVL1YfTt+Mr9ba6EMhz4kYJi8iFxsp+3whfv6sl5Stwx+4qFXdezCkQksQb1O4 pAfudChDjEXdnlFLKHeXpgIpmrAJURvfp4OtmbKyPrTjxN3OYqDlCF720+XRKQwMCMw8 KY2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=DoqDXH/3ekdVQe0eRy5uE4ovem02TnuS1+gpXK1aVCA=; b=unfjSEow3w76tmktRZ9SOY6MwvMf18Dt/nDZAI7/pogBPATfz2mUaYrDrGUqpSKT8T 5gW++tAhyrZ2TdMOMFqe+nPsbuJwrft5QPom3cSzSVwz2+2GLePIfQEazpusxf/ot1u2 nWYs7mILKdKYQjr04xY/m26Opwb7Sz5BkN2VopUhFNwq9mG8sGqYX1TmL3yLHw6c5pXo 045nUmcasqpuyCd4H6h0mG2dxuOgJWVGBIUfXxxfEUfebJUy9R+dLmwKO+0RUw/6hYwU /h938flPFbtNvag0j+lau1xjHHdsr3eB/sNYUCPoE2iyxbps+Ov0+BtSHGTaG9pBMLVo cyQw== X-Gm-Message-State: AGi0PubouMUO3IQ1DhGM+nRdWh3SCOM6OuQRK2NblGwsXLjHdNJZxlTe H/CBkLvWpTvNuQLsl48OB8E= X-Received: by 2002:a17:90a:dc01:: with SMTP id i1mr597850pjv.166.1588651829190; Mon, 04 May 2020 21:10:29 -0700 (PDT) Received: from [192.168.1.7] ([120.244.110.63]) by smtp.gmail.com with ESMTPSA id w125sm491358pgw.22.2020.05.04.21.10.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 May 2020 21:10:28 -0700 (PDT) Subject: Re: [PATCH] fs: jfs: fix a possible data race in txBegin() To: Markus Elfring , jfs-discussion@lists.sourceforge.net Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Dave Kleikamp References: <5ef374a5-0e2e-5c74-a827-0148c384f6e3@web.de> From: Jia-Ju Bai Message-ID: Date: Tue, 5 May 2020 12:10:20 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <5ef374a5-0e2e-5c74-a827-0148c384f6e3@web.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/5/5 0:15, Markus Elfring wrote: >> Thus, a data race can occur for tblk->flag. >> >> To fix this data race, the spinlock log->gclock is used in >> txBegin(). >> >> This data race is found by our concurrency fuzzer. > How do you think about a wording variant like the following? > > Change description: > A data race can occur for the data structure member “flag”. > This data race was found by our concurrency fuzzer. > > Thus use the spin lock “gclock” for the resetting of five > data structure members in this function implementation. > > > Would you like to add the tag “Fixes” to the commit message? > Thanks, Markus. I am not sure how to add the tag "Fixes"... I need to find which previous commit add the code about txBegin()? Best wishes, Jia-Ju Bai