Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] Fix all coding-style warnings on lm75 driver
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     jdelvare@suse.com, linux-hwmon@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1588255534-28073-1-git-send-email-michalorzel.eng@gmail.com>
 <20200505015808.GA139531@roeck-us.net>
From:   =?UTF-8?B?TWljaGHFgiBPcnplxYI=?= <michalorzel.eng@gmail.com>
Message-ID: <cc5e0f61-a7f7-c7b7-2e90-8e7817329d1e@gmail.com>
Date:   Tue, 5 May 2020 07:48:46 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.1
MIME-Version: 1.0
In-Reply-To: <20200505015808.GA139531@roeck-us.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 05.05.2020 03:58, Guenter Roeck wrote:
> On Thu, Apr 30, 2020 at 04:05:34PM +0200, Michal Orzel wrote:
>> Check/fix all warnings generated by checkpatch.pl script on LM75 driver.
>>
>> Signed-off-by: Michal Orzel <michalorzel.eng@gmail.com>
> 
> Applied, but for the future please prepend your patches with something like
> "subsystem: driver:", or for hwmon "hwmon: (driver)".
> 
> Also, please keep in mind that such cleanups are not encouraged unless you
> also provide functional changes.
> 
> Thanks,
> Guenter
> 
I will keep it in mind.

Thanks,
Michal
>> ---
>>  drivers/hwmon/lm75.c |  8 ++++++--
>>  drivers/hwmon/lm75.h | 31 +++++++++++++++++--------------
>>  2 files changed, 23 insertions(+), 16 deletions(-)
>>
>> diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c
>> index 5e63922..ba0be48 100644
>> --- a/drivers/hwmon/lm75.c
>> +++ b/drivers/hwmon/lm75.c
>> @@ -797,8 +797,10 @@ static int lm75_detect(struct i2c_client *new_client,
>>  
>>  	/* First check for LM75A */
>>  	if (i2c_smbus_read_byte_data(new_client, 7) == LM75A_ID) {
>> -		/* LM75A returns 0xff on unused registers so
>> -		   just to be sure we check for that too. */
>> +		/*
>> +		 * LM75A returns 0xff on unused registers so
>> +		 * just to be sure we check for that too.
>> +		 */
>>  		if (i2c_smbus_read_byte_data(new_client, 4) != 0xff
>>  		 || i2c_smbus_read_byte_data(new_client, 5) != 0xff
>>  		 || i2c_smbus_read_byte_data(new_client, 6) != 0xff)
>> @@ -849,6 +851,7 @@ static int lm75_suspend(struct device *dev)
>>  {
>>  	int status;
>>  	struct i2c_client *client = to_i2c_client(dev);
>> +
>>  	status = i2c_smbus_read_byte_data(client, LM75_REG_CONF);
>>  	if (status < 0) {
>>  		dev_dbg(&client->dev, "Can't read config? %d\n", status);
>> @@ -863,6 +866,7 @@ static int lm75_resume(struct device *dev)
>>  {
>>  	int status;
>>  	struct i2c_client *client = to_i2c_client(dev);
>> +
>>  	status = i2c_smbus_read_byte_data(client, LM75_REG_CONF);
>>  	if (status < 0) {
>>  		dev_dbg(&client->dev, "Can't read config? %d\n", status);
>> diff --git a/drivers/hwmon/lm75.h b/drivers/hwmon/lm75.h
>> index b614e63..a398171 100644
>> --- a/drivers/hwmon/lm75.h
>> +++ b/drivers/hwmon/lm75.h
>> @@ -1,17 +1,15 @@
>>  /* SPDX-License-Identifier: GPL-2.0-or-later */
>>  /*
>> -    lm75.h - Part of lm_sensors, Linux kernel modules for hardware
>> -	      monitoring
>> -    Copyright (c) 2003 Mark M. Hoffman <mhoffman@lightlink.com>
>> -
>> -*/
>> + * lm75.h - Part of lm_sensors, Linux kernel modules for hardware monitoring
>> + * Copyright (c) 2003 Mark M. Hoffman <mhoffman@lightlink.com>
>> + */
>>  
>>  /*
>> -    This file contains common code for encoding/decoding LM75 type
>> -    temperature readings, which are emulated by many of the chips
>> -    we support.  As the user is unlikely to load more than one driver
>> -    which contains this code, we don't worry about the wasted space.
>> -*/
>> + * This file contains common code for encoding/decoding LM75 type
>> + * temperature readings, which are emulated by many of the chips
>> + * we support.  As the user is unlikely to load more than one driver
>> + * which contains this code, we don't worry about the wasted space.
>> + */
>>  
>>  #include <linux/kernel.h>
>>  
>> @@ -20,18 +18,23 @@
>>  #define LM75_TEMP_MAX 125000
>>  #define LM75_SHUTDOWN 0x01
>>  
>> -/* TEMP: 0.001C/bit (-55C to +125C)
>> -   REG: (0.5C/bit, two's complement) << 7 */
>> +/*
>> + * TEMP: 0.001C/bit (-55C to +125C)
>> + * REG: (0.5C/bit, two's complement) << 7
>> + */
>>  static inline u16 LM75_TEMP_TO_REG(long temp)
>>  {
>>  	int ntemp = clamp_val(temp, LM75_TEMP_MIN, LM75_TEMP_MAX);
>> +
>>  	ntemp += (ntemp < 0 ? -250 : 250);
>>  	return (u16)((ntemp / 500) << 7);
>>  }
>>  
>>  static inline int LM75_TEMP_FROM_REG(u16 reg)
>>  {
>> -	/* use integer division instead of equivalent right shift to
>> -	   guarantee arithmetic shift and preserve the sign */
>> +	/*
>> +	 * use integer division instead of equivalent right shift to
>> +	 * guarantee arithmetic shift and preserve the sign
>> +	 */
>>  	return ((s16)reg / 128) * 500;
>>  }
>> -- 
>> 2.7.4
>>