Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 5 May 2020 14:49:58 +0800
From:   Dejin Zheng <zhengdejin5@gmail.com>
To:     Florian Fainelli <f.fainelli@gmail.com>
Cc:     davem@davemloft.net, swboyd@chromium.org, ynezz@true.cz,
        netdev@vger.kernel.org, jonathan.richardson@broadcom.com,
        linux-kernel@vger.kernel.org,
        Scott Branden <scott.branden@broadcom.com>,
        Ray Jui <ray.jui@broadcom.com>
Subject: Re: [PATCH net v1] net: broadcom: fix a mistake about ioremap
 resource
Message-ID: <20200505064958.GA1357@nuc8i5>
References: <20200505020329.31638-1-zhengdejin5@gmail.com>
 <8b71b3ba-edc8-ce78-27ba-ce05230efc31@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8b71b3ba-edc8-ce78-27ba-ce05230efc31@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, May 04, 2020 at 08:28:52PM -0700, Florian Fainelli wrote:
> 
> 
> On 5/4/2020 7:03 PM, Dejin Zheng wrote:
> > Commit d7a5502b0bb8b ("net: broadcom: convert to
> > devm_platform_ioremap_resource_byname()") will broke this driver.
> > idm_base and nicpm_base were optional, after this change, they are
> > mandatory. it will probe fails with -22 when the dtb doesn't have them
> > defined. so revert part of this commit and make idm_base and nicpm_base
> > as optional.
> > 
> > Fixes: d7a5502b0bb8bde ("net: broadcom: convert to devm_platform_ioremap_resource_byname()")
> > Reported-by: Jonathan Richardson <jonathan.richardson@broadcom.com>
> > Cc: Scott Branden <scott.branden@broadcom.com>
> > Cc: Ray Jui <ray.jui@broadcom.com>
> > Cc: Florian Fainelli <f.fainelli@gmail.com>
> > Cc: David S. Miller <davem@davemloft.net>
> > Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
> 
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>

Florian, Thank you very much for helping me as always!

BR,
Dejin

> -- 
> Florian