Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp420284ybj; Tue, 5 May 2020 00:50:08 -0700 (PDT) X-Google-Smtp-Source: APiQypJKFtjvExRqoEMM3r5J+4yPRV/TjsyRIHWsHOLggr9Gt4UcBsumaZJ+ph2EgpJym5N0zjss X-Received: by 2002:a17:906:7ac8:: with SMTP id k8mr1425665ejo.235.1588665008501; Tue, 05 May 2020 00:50:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588665008; cv=none; d=google.com; s=arc-20160816; b=ESM26/rfJWIeBi6kcX+dJcsvAv9zhU1wufZq0Av10zVKM/FPeD446V8p5IMJxw8ko2 4pusORx9byaSj9ZuMUAQOWAyG8HtLyqN+SYeTJGIYAVeGw16bP0XXMX7xBUF9kLf/RKT CjfQbqlweeG/XObyX08lULPHuBSaUEOvycwJfYNjcOOl51YETHOU0B/r5zI1j5KUP7Po CZbrQdnBKweL8XmvKLpYqFYdH/LSq/I4GkPjac8JTWXfwbOssEQRXiWwUbQP1FI9DnN8 4Q5IoqUO2Nq67wO71p9dFWtX5XdaFW1VVWNDODVBJuRdpGU26teycm1Fk/Auo/scAFdM /xKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=TX1zwxzyEaSlSti8pWRFHvMcH7FZe/O0bXwnFtPoe+0=; b=btGoSqd59JjAeg9XHGEcn6g3OG7VHo7pN+GVUmZAgbawEQabSzuq7jNRqM53l8f2nM 7dNV1YuBYbrHt77lrSIPycwPWGH3sT8NAQUmmTIRKSV7Eirdn4urYTk7KUjL3gV/0Joc 9bDYXnFHRpeFIUTVKw18F2YfHFHWdYxyThBlHS1P7NK5oHD2CRi6jR/RXAVdweaw5SDZ /VOcOGJ2wnoFmCUV9sq0ViKnayVerXrYkZbxqR/zpKFdv2jvQFMN2pD0HuTn2X3K12jy MX1Cv2BT0HLs5Zrq0IJv1QtnRckerwvyiSFRMcW68B6TZotQq/8lM/JlPiQ0038RhWbM HRrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Z0SS3n1f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i14si591786ejr.238.2020.05.05.00.49.45; Tue, 05 May 2020 00:50:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Z0SS3n1f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728575AbgEEHpS (ORCPT + 99 others); Tue, 5 May 2020 03:45:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:40562 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728565AbgEEHpP (ORCPT ); Tue, 5 May 2020 03:45:15 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 179002078E; Tue, 5 May 2020 07:45:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588664715; bh=d7kGl8EmDAO8ZOBK3gZ//gfpMqkW08L56eEq7FgxXWk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z0SS3n1fnEgyhA06l2/QuLbQ0/QDNt18elj+gWpCVRwcrNus8vy9DwuClxJ8pB5gN nVSOdJNcaOsnEkF6q8yzqVNMnpvt1OvDrqolEqWgfMUYAYfuFKgZs+csxtkDVrngjr VSEpbaFdvLuaCleSmCj/4VMCust8N+VB3s9QcZpI= Date: Tue, 5 May 2020 09:45:11 +0200 From: Greg KH To: SeongJae Park Cc: davem@davemloft.net, viro@zeniv.linux.org.uk, kuba@kernel.org, edumazet@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, SeongJae Park Subject: Re: [PATCH net 1/2] Revert "coallocate socket_wq with socket itself" Message-ID: <20200505074511.GA4054974@kroah.com> References: <20200505072841.25365-1-sjpark@amazon.com> <20200505072841.25365-2-sjpark@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200505072841.25365-2-sjpark@amazon.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 05, 2020 at 09:28:40AM +0200, SeongJae Park wrote: > From: SeongJae Park > > This reverts commit 333f7909a8573145811c4ab7d8c9092301707721. > > The commit 6d7855c54e1e ("sockfs: switch to ->free_inode()") made the > deallocation of 'socket_alloc' to be done asynchronously using RCU, as > same to 'sock.wq'. And the following commit 333f7909a857 ("coallocate > socket_sq with socket itself") made those to have same life cycle. > > The changes made the code much more simple, but also made 'socket_alloc' > live longer than before. For the reason, user programs intensively > repeating allocations and deallocations of sockets could cause memory > pressure on recent kernels. > > To avoid the problem, this commit separates the life cycle of > 'socket_alloc' and 'sock.wq' again. The following commit will make the > deallocation of 'socket_alloc' to be done synchronously again. > --- No signed-off-by? No "Fixes:"? :(