Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp420460ybj; Tue, 5 May 2020 00:50:23 -0700 (PDT) X-Google-Smtp-Source: APiQypJA61mI3z04rGa4dNHcdYSggjcT34YsZrfvgq+6Pl0ZN3DCJoKHiLcfI9Ax/rYRwAMR9Vcp X-Received: by 2002:a17:906:3f45:: with SMTP id f5mr1538220ejj.18.1588665023297; Tue, 05 May 2020 00:50:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588665023; cv=none; d=google.com; s=arc-20160816; b=lS9usWr9YxR45BJr6zG/lV5NwYkKuGLDjKLCMEQWV2rO7jH97C/FXPA4ZGnl0+G5jR C9v1yaWH+s2tbCezqR32K0nlaFO+kSJSW5U5XyVtE/PzosVnbi9kp2WbrT+3uLHeQkkl waeU5VmSMgyjRvq3Tx3DBg/tejmTPIAS4/g9k/BexMLYRkGRZ2MGktmCOBtvH/B/Y3TR /txI6Kbqvwp89mFvAtkHSVIf9ihgz2uK4j31hmTsqaEAss3Ylvu+WJMbHDJt31ISbwK/ gDfhIN6H6DkoyaLZVazPFv9S0MB0azGYWxeeViLeg2N/SftN021baUCFkIIdLg2CSDCj JIlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=0s/ja4SD3Ttg0zwNSOHi8KmMAlM0D/C8QfjtXPN7aWc=; b=hCFw15KcbNVuVL8iwsMF04E46oVE8l7zvQY1futNVfXxlPeMwdCAsisvE53kHFnSdT B48DgESYUqOWmIo86ubDNsiqQwAWE3hYDd+pKlmsWWKZVg6dVat9gRWeYir3DDdkInfK JTQd3+CscFrObBhKyU/sWIpptLK1Bv8FeeqIvi4c092f9I2aEG48g9DbTp2HVkUJsuHj CDmTf730ZKUtRdQG/uUmrxrhTrPgkZfO9PClrjNanbsLMyAyGkxLYCz+oWSuXVLLKJm9 LPCD3EpcpQNvh5pOz7MQumhvSHVkR3EpSTYlTlJR+eeA2S6KXY0UECboGVdw9VOCSgFq SLxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=MB5J6Nxa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p9si724166ejn.415.2020.05.05.00.50.00; Tue, 05 May 2020 00:50:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=MB5J6Nxa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728591AbgEEHpi (ORCPT + 99 others); Tue, 5 May 2020 03:45:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:40892 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727938AbgEEHpi (ORCPT ); Tue, 5 May 2020 03:45:38 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 404F2206CC; Tue, 5 May 2020 07:45:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588664737; bh=KabGD4ekn5YE4Pzx/iZDYkiL8RHInKLJTdo36GuGiug=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MB5J6NxaWPPdA49yOdcc3E0eCCKZGUoGTno53CYL4PpBBM0d82eJK4gHwBkshuHOX acn3ntKp+HFX7GBsVFTTyEahgRy8Ldhw5p+P6HNpnUcIHFYJuN1FH+uQ/d7qKDZ6LW IHK/pe2cHDJg0yQK4VwxjS3h9fF3c91V442WA26o= Date: Tue, 5 May 2020 09:45:35 +0200 From: Greg KH To: SeongJae Park Cc: davem@davemloft.net, viro@zeniv.linux.org.uk, kuba@kernel.org, edumazet@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, SeongJae Park Subject: Re: [PATCH net 2/2] Revert "sockfs: switch to ->free_inode()" Message-ID: <20200505074535.GB4054974@kroah.com> References: <20200505072841.25365-1-sjpark@amazon.com> <20200505072841.25365-3-sjpark@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200505072841.25365-3-sjpark@amazon.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 05, 2020 at 09:28:41AM +0200, SeongJae Park wrote: > From: SeongJae Park > > This reverts commit 6d7855c54e1e269275d7c504f8f62a0b7a5b3f18. > > The commit 6d7855c54e1e ("sockfs: switch to ->free_inode()") made the > deallocation of 'socket_alloc' to be done asynchronously using RCU, as > same to 'sock.wq'. > > The change made 'socket_alloc' live longer than before. As a result, > user programs intensively repeating allocations and deallocations of > sockets could cause memory pressure on recent kernels. > > To avoid the problem, this commit reverts the change. > --- > net/socket.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Same problems here as in patch 1/2 :(