Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: m8F2JJq921i8U2hTPFX0OwXLwYDtpl5tpc29M2DH+3KrOTRiknwDPZ2TJ0WOTyoRcP0j5qH4tC
 TRGUvBBx98GA==
Subject: Re: [PATCH v9 3/3] edac: Add support for Amazon's Annapurna Labs L2 EDAC
To:     Robert Richter <rrichter@marvell.com>, <bp@alien8.de>
CC:     <mchehab@kernel.org>, <tony.luck@intel.com>, <james.morse@arm.com>,
        <robh+dt@kernel.org>, <frowand.list@gmail.com>,
        <davem@davemloft.net>, <gregkh@linuxfoundation.org>,
        <Jonathan.Cameron@huawei.com>, <arnd@arndb.de>,
        <linux-kernel@vger.kernel.org>, <linux-edac@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <dwmw@amazon.co.uk>,
        <benh@amazon.com>, <ronenk@amazon.com>, <talel@amazon.com>,
        <jonnyc@amazon.com>, <hanochu@amazon.com>, <barakw@amazon.com>
References: <20200129195016.956-1-hhhawa@amazon.com>
 <20200129195016.956-4-hhhawa@amazon.com>
 <20200310134713.n4gtrgtjdjymmgm5@rric.localdomain>
From:   "Hawa, Hanna" <hhhawa@amazon.com>
Message-ID: <8bd3e95c-c45e-383a-f1a3-d60be5c2ff19@amazon.com>
Date:   Tue, 5 May 2020 11:30:00 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <20200310134713.n4gtrgtjdjymmgm5@rric.localdomain>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 3/10/2020 3:47 PM, Robert Richter wrote:
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
> 
> 
> 
> On 29.01.20 21:50:16, Hanna Hawa wrote:
>> Adds support for Amazon's Annapurna Labs L2 EDAC driver to detect and
>> report L2 errors.
>>
>> Signed-off-by: Hanna Hawa <hhhawa@amazon.com>
>> ---
>>   MAINTAINERS               |   5 +
>>   drivers/edac/Kconfig      |   8 ++
>>   drivers/edac/Makefile     |   1 +
>>   drivers/edac/al_l2_edac.c | 270 ++++++++++++++++++++++++++++++++++++++
>>   4 files changed, 284 insertions(+)
>>   create mode 100644 drivers/edac/al_l2_edac.c
> 
> Hanna, most of the review comments by Boris for patch #1 (al_l1_edac)
> apply here too. Please address them.

Hi Boris, Robert,

Sorry for not getting back to you sooner, will address comments on both 
files and upload new patchset ASAP.

Thanks,
Hanna

> 
> Thanks,
> 
> -Robert
>