Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp450093ybj; Tue, 5 May 2020 01:32:15 -0700 (PDT) X-Google-Smtp-Source: APiQypLCZPKOMS82bn1kAzdlPDj1jElsRRvHgwLKRAAqAxDDwXHq+3nLRjbNgcWYN7S9qcxBxjcO X-Received: by 2002:a17:906:2488:: with SMTP id e8mr1541561ejb.157.1588667535029; Tue, 05 May 2020 01:32:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588667535; cv=none; d=google.com; s=arc-20160816; b=nzN2IFLecAJ3CM3ZM/WNxwmKMQu1nMdeVoUainzMQK3277mcPczom7tL5O51lmARkG W41EjsMAzt1cjy87XHduO1abw8llZMcRPrwPjY2+cCm9JaSEmQfeM9ebvM3jxSvUidZ9 SzwAlL92EpZ2/S7UVzqE6jerzuZv1G32VViurdoDY0yFwVOIiu5/XV5gBGlLr6PywDnU cxB3xahzdjdYwpsgLys3g94I/fjhnqY9lExXXrYFiqmPPTYbXkUdmDG3Btj6TML6sOer Qf6P4FyrIjZMJg989tSeWiroAfEIg0PNo+n82SbOifL7lgSYI/KPrseeC52zARhytKzQ YXcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=bgM1z0W3jC692xWkgi3/Y+e2n/nzkwaSzFa78vdYF0E=; b=Ro8Vh/uxWnRdOuc4pjIz7aXiZm0vHX3kihQw+3y3yEEzhJiT7C44DWIRqcY4/8NRoN 73yrh+dGlw0uUQbPNMk7+DxEvpqRbsWG8nb341VxQRuzaDk2BbFZ/xsQkHdTKaZWQw1p aMhS4d/cV2733ADOAFBi5u073p+7dkPmsTNSjkl4NZnj5QA5xyiQ1sXJ0sxazP6fAkoY zfQPnu/HMyufN9LMnnHlle66cSz2YlNfFUGWQzABRybHi4D45Z2Q8CEqT0Mr8Cr5eZOp wGrY/Ef8xfcwuuLlaYM4Vh2+17cD6dx/69+0q+KwDaYyrhe7qZKb7Mnce85xWNm5hEGu 9HzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DIWu5shl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q28si857406edb.547.2020.05.05.01.31.51; Tue, 05 May 2020 01:32:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DIWu5shl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728544AbgEEI2H (ORCPT + 99 others); Tue, 5 May 2020 04:28:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1728497AbgEEI2H (ORCPT ); Tue, 5 May 2020 04:28:07 -0400 Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6386C061A10 for ; Tue, 5 May 2020 01:28:05 -0700 (PDT) Received: by mail-lj1-x242.google.com with SMTP id y4so695033ljn.7 for ; Tue, 05 May 2020 01:28:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bgM1z0W3jC692xWkgi3/Y+e2n/nzkwaSzFa78vdYF0E=; b=DIWu5shlATY4PZunGAKyb/Z+n2zkJihLqazePZ4n/k6j5RCVLrLJOPjtisCmJ8+trj /jCI1TplrSRfpZ5kH53qorDrheIpgsvZmn6FcroYQoDm5fn+1FLbBBDr72W4k8wY3OVB oP681xMKnTOAASBA2YOqIwqrGCoLIboWhJoH6lGdTMUzvdFTmx0PSELZsW/M50f3dgAy Dvxb+NmVgrs1GIGHpvW12W0Rsfa3soOn9dYUbzFobQPhbBJKn3mRg7aivW4Pww+9Jtxh 0hsIpSJz1JdCxorD1s+WITyExRl8HmHDaaFS3WDusH4MYrxLQ+cH9kSN4LWThyf4wjd2 GJvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bgM1z0W3jC692xWkgi3/Y+e2n/nzkwaSzFa78vdYF0E=; b=qnvsEaGBPu1NUULXm0f6Oj/keNKyOCIca0IvuP72PrnqblFILjjWQWOs817hDPuwUu +vZj4LCCu4F7vDNjIvfQKWRp1Mjaqv/IoHuyWlXGYbFdRJAzeSiW/ypXMrl5f48VrYHu TOnCr4KS53JcE9P79pE8+aM5e/nxySoij9ELYobW+wUIhycTYMhjvxK1krx8JAlT9EIz uasawwqFo0snFa34qOcl8vCg9jECKaaOk42E2kJNBWYLDqtBkfzE9hpvpeFlimEAg5IC 4stjHWWTjffxwzQ1q5SA1gJ4OyFivhnkuhcl4wfVUgyEnw2Q1fxM9pk3F32uix8QPaQI ePoQ== X-Gm-Message-State: AGi0PuZ1O6yM2us3J8Pj2FTt6hirfmjKXIhOSh5QO3FtGfPUEfjCWy57 NI9jK3fN8eganhNw/rnncHKnhh10ddWWAZTTsgD++Q== X-Received: by 2002:a2e:8087:: with SMTP id i7mr993585ljg.99.1588667284186; Tue, 05 May 2020 01:28:04 -0700 (PDT) MIME-Version: 1.0 References: <20200408191458.1260397-1-arnd@arndb.de> In-Reply-To: <20200408191458.1260397-1-arnd@arndb.de> From: Linus Walleij Date: Tue, 5 May 2020 10:27:52 +0200 Message-ID: Subject: Re: [PATCH] drm/msm: fix link error without CONFIG_DEBUG_FS To: Arnd Bergmann Cc: Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Jordan Crouse , Rob Clark , "Kristian H. Kristensen" , Allison Randal , Bjorn Andersson , MSM , "open list:DRM PANEL DRIVERS" , freedreno , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 8, 2020 at 9:15 PM Arnd Bergmann wrote: > I ran into a randconfig link error with debugfs disabled: > > arm-linux-gnueabi-ld: > drivers/gpu/drm/msm/msm_gpu.o: in function `should_dump': msm_gpu.c:(.text+0x1cc): undefined reference to `rd_full' > > Change the helper to only look at this variable if debugfs is present. > > Fixes: e515af8d4a6f ("drm/msm: devcoredump should dump MSM_SUBMIT_BO_DUMP buffers") > Signed-off-by: Arnd Bergmann This fixes a compilation error for me on the APQ8060. Tested-by: Linus Walleij Yours, Linus Walleij