Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp617205ybj; Tue, 5 May 2020 05:00:03 -0700 (PDT) X-Google-Smtp-Source: APiQypIth3YAkGvczl1KbyvdMj950japO6aZ/quIu1ZExuMZ9FaeO5JdJ2vXVph458QhxKpETFK0 X-Received: by 2002:a17:906:30c3:: with SMTP id b3mr2371474ejb.126.1588680003204; Tue, 05 May 2020 05:00:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588680003; cv=none; d=google.com; s=arc-20160816; b=iTplclUq1dYSozX2mAFPa8CLKaer9oJqsnBJ/1+Tc4IPqGdaM71t86c5eVfGmKBNyY VozSVZmtaKaxyF41SHbWqn2I8UBLXuI1EFckA8u/GiYOL1QqUoboC9FmU/mH3ixwpkWj iTCl+RTMNie6BVSMG0zrO1MuMzVthQtiQxz1pLJfvGkcB+V3eOru8npHnDsz6vXYDxoq R1NoDqoWzPTym/1e0+n1xtjA3VOt5RouRcJ7EyqNBH83Hs/GIcvyY77rP8DsHhhq9Ac+ ghkSkaKVOEpwLeYWigUPd4IzN+wb2LvzDWePjrmZ7Vgk0uyKzT3oj8P79jAX14uLyFjn NJgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=cZq9ezEgFtqk5Ox1Ey0tu1okQWo6BVx00JZqSkS7Hkc=; b=TfX826ZHyD1au6AJCU73ErnZcUB8CFQGYCZVvGDHjti3O5WyqbHnDSpbqTm2P+Tvro Uqr0hpxL8L8ACb5Y6n6XX3PVlSPPl0PRL5P1Y7Uifex/tN0ZNJMkYMIw87SKhtGBDnx2 g52MbpHFyPNDDnvQWBiEseJkB1avD5jclo1nK1MTYOSOI0EcxBV9uvDAxpJhtemGNu15 QeibV1x5EMmr04Fdvadj12VMC2c0eUYfneDF+uo/Cc3BQcZ911Zr5j6+nwkP9PCoSJNF pvsx5tmwZ2i+l+4ySmd8kQXtboDbZRxkn/89s65A7uosJvgZ0mBhZT9DEsJ1GwSHCT2a gvog== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bm6si968617edb.608.2020.05.05.04.59.36; Tue, 05 May 2020 05:00:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728865AbgEEL4J (ORCPT + 99 others); Tue, 5 May 2020 07:56:09 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:3803 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728804AbgEEL4I (ORCPT ); Tue, 5 May 2020 07:56:08 -0400 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id D52B2ECE72F96FF1ABBA; Tue, 5 May 2020 19:56:03 +0800 (CST) Received: from DESKTOP-C3MD9UG.china.huawei.com (10.166.215.55) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.487.0; Tue, 5 May 2020 19:55:54 +0800 From: Zhen Lei To: Minchan Kim , Nitin Gupta , "Sergey Senozhatsky" , Jens Axboe , linux-block , Andrew Morton , linux-mm , Alasdair Kergon , Mike Snitzer , dm-devel , Song Liu , linux-raid , linux-kernel CC: Zhen Lei Subject: [PATCH 0/4] eliminate SECTOR related magic numbers and duplicated conversions Date: Tue, 5 May 2020 19:55:39 +0800 Message-ID: <20200505115543.1660-1-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.166.215.55] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When I studied the code of mm/swap, I found "1 << (PAGE_SHIFT - 9)" appears many times. So I try to clean up it. 1. Replace "1 << (PAGE_SHIFT - 9)" or similar with SECTORS_PER_PAGE 2. Replace "PAGE_SHIFT - 9" with SECTORS_PER_PAGE_SHIFT 3. Replace "9" with SECTOR_SHIFT 4. Replace "512" with SECTOR_SIZE No functional change. Zhen Lei (4): block: Move SECTORS_PER_PAGE and SECTORS_PER_PAGE_SHIFT definitions into mm/swap: use SECTORS_PER_PAGE_SHIFT to clean up code block: use SECTORS_PER_PAGE_SHIFT and SECTORS_PER_PAGE to clean up code mtd: eliminate SECTOR related magic numbers block/blk-settings.c | 8 ++++---- block/partitions/core.c | 4 ++-- drivers/block/zram/zram_drv.h | 2 -- drivers/md/dm-table.c | 2 +- drivers/md/raid1.c | 4 ++-- drivers/md/raid10.c | 10 +++++----- drivers/md/raid5-cache.c | 10 +++++----- include/linux/blkdev.h | 10 ++++++++-- mm/page_io.c | 4 ++-- mm/swapfile.c | 12 ++++++------ 10 files changed, 35 insertions(+), 31 deletions(-) -- 2.26.0.106.g9fadedd