Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3] ipmi:bt-bmc: Fix error handling and status check
To:     minyard@acm.org
Cc:     arnd@arndb.de, gregkh@linuxfoundation.org,
        openipmi-developer@lists.sourceforge.net,
        linux-kernel@vger.kernel.org,
        Shengju Zhang <zhangshengju@cmss.chinamobile.com>
References: <20200505102906.17196-1-tangbin@cmss.chinamobile.com>
 <20200505114907.GK9902@minyard.net>
From:   Tang Bin <tangbin@cmss.chinamobile.com>
Message-ID: <3610b0fb-25f5-1bf9-a3c1-1c7ca113a9c8@cmss.chinamobile.com>
Date:   Tue, 5 May 2020 20:59:51 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <20200505114907.GK9902@minyard.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi, Corey:

On 2020/5/5 19:49, Corey Minyard wrote:
> On Tue, May 05, 2020 at 06:29:06PM +0800, Tang Bin wrote:
>> If the function platform_get_irq() failed, the negative value
>> returned will not be detected here. So fix error handling in
>> bt_bmc_config_irq(). And in the function bt_bmc_probe(),
>> when get irq failed, it will print error message. So use
>> platform_get_irq_optional() to simplify code. Finally in the
>> function bt_bmc_remove() should make the right status check
>> if get irq failed.
> Ok, this is included in my tree.

I just want to say: thank you very much.

After many days of communication with you, I have learned a lot, your 
patient teaching has inspired me a lot. It's my pleasure to meet you.

Thanks,

Tang Bin

>