Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp704369ybj; Tue, 5 May 2020 06:32:08 -0700 (PDT) X-Google-Smtp-Source: APiQypIXdcWgtsdcCGFSRDdpJ/E7bniFB7+0zcNhfFW2kc2kQrNzKSlrpudTlQ1Sw78rvgrMGVye X-Received: by 2002:a17:906:551:: with SMTP id k17mr2761541eja.350.1588685527902; Tue, 05 May 2020 06:32:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588685527; cv=none; d=google.com; s=arc-20160816; b=0jCTZ6UsorML3xetgztvza4PqxHvkXj3UjHfC/6vdjp2F+O7oX9iKX6ZifJmOkw/hq mKn1ppsqAI0u7Z+S1dcsKqSpSL+DlBKWFjW+P7yWDoLvSmDDlwmDAD4t4VGCF7IkJFeR saahAxOV+2AIY3IvpRq9jhE2c0zaGrIsRSl9mqBmDRdFHCZ9MY6IW0yzYJxLiEuw5Msu tqbwJfGI4FJvLX0ezsqn6MZ1D/Q81ij9Qr5+WyPx1NsmZLlt1n/WZP2OQULnmU6K4GNQ grUU87AAmbXMenwfys+z+2nXHCqBP+KF+lOmB2IaF/ip7jG9xQ607NwgEWP8wigKWVD0 kfVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=ytpnnOYb/oE+E/Nvm3NIQv5IQH0lclsHIOsJ1WDGJbw=; b=Vq1TL2LFKO9OsVntlKCrtHSNBoC3BwvQmo6cLNdN/Evo94fuql/T5CuZ+EYNtLB6Or 2HU1If+PeO1BC9qk5faibe73uwNbGHM6g+lsehwEgu01MxFEq2I52SqUJpIQEWT7A/tF xW/g9V949RptigpCKNTBZCrhHrJ+Sauv3MKPwzmW/0x+pFbckRwGTEEpD+X8VNojvBBv LZOZ0BGI0daUx0KOkzBdgxEoTxqdgQC3KIcyWc86Dy35IIrmj3zvqdtbrSdvL6syAmJv b2hKxlE1vtHBw9r9nBTS3VRGzzYXk0rpLBoot4PsLv2X6tEUCIsGO2Rh9I4jHnyjW3oP efSw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ox5si1111082ejb.530.2020.05.05.06.31.43; Tue, 05 May 2020 06:32:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728990AbgEEN2N (ORCPT + 99 others); Tue, 5 May 2020 09:28:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728268AbgEEN2M (ORCPT ); Tue, 5 May 2020 09:28:12 -0400 Received: from baptiste.telenet-ops.be (baptiste.telenet-ops.be [IPv6:2a02:1800:120:4::f00:13]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4889BC061A0F for ; Tue, 5 May 2020 06:28:12 -0700 (PDT) Received: from ramsan ([IPv6:2a02:1810:ac12:ed60:bd97:8453:3b10:1832]) by baptiste.telenet-ops.be with bizsmtp id b1U92200E3VwRR3011U9X9; Tue, 05 May 2020 15:28:09 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan with esmtp (Exim 4.90_1) (envelope-from ) id 1jVxcI-0007yK-1e; Tue, 05 May 2020 15:28:10 +0200 Received: from geert by rox.of.borg with local (Exim 4.90_1) (envelope-from ) id 1jVxcI-0004bV-0H; Tue, 05 May 2020 15:28:10 +0200 From: Geert Uytterhoeven To: "David S . Miller" Cc: Shannon Nelson , Pensando Drivers , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH v2] ionic: Use debugfs_create_bool() to export bool Date: Tue, 5 May 2020 15:28:09 +0200 Message-Id: <20200505132809.17655-1-geert+renesas@glider.be> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently bool ionic_cq.done_color is exported using debugfs_create_u8(), which requires a cast, preventing further compiler checks. Fix this by switching to debugfs_create_bool(), and dropping the cast. Signed-off-by: Geert Uytterhoeven Acked-by: Shannon Nelson --- v2: - Add Acked-by. --- drivers/net/ethernet/pensando/ionic/ionic_debugfs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c b/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c index 5f8fc58d42b3d31c..11621ccc1faf0837 100644 --- a/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c +++ b/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c @@ -170,8 +170,7 @@ void ionic_debugfs_add_qcq(struct ionic_lif *lif, struct ionic_qcq *qcq) debugfs_create_x64("base_pa", 0400, cq_dentry, &cq->base_pa); debugfs_create_u32("num_descs", 0400, cq_dentry, &cq->num_descs); debugfs_create_u32("desc_size", 0400, cq_dentry, &cq->desc_size); - debugfs_create_u8("done_color", 0400, cq_dentry, - (u8 *)&cq->done_color); + debugfs_create_bool("done_color", 0400, cq_dentry, &cq->done_color); debugfs_create_file("tail", 0400, cq_dentry, cq, &cq_tail_fops); -- 2.17.1