Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp770382ybj; Tue, 5 May 2020 07:18:51 -0700 (PDT) X-Google-Smtp-Source: APiQypLw4l0zw58OPWcFabUPIyMEL1lAf/vkZRTOatHaKkqcYnPY1YnauT3dkOK08DnsuCGIbHpr X-Received: by 2002:aa7:d60a:: with SMTP id c10mr2961872edr.66.1588688331537; Tue, 05 May 2020 07:18:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588688331; cv=none; d=google.com; s=arc-20160816; b=Dcltwto94NdXgPNGpKF9JB0GGJmsZgPF7Dm/oJcQwIF0tRepTpAwTUsxSd4zJOpvWf B9sS0XjLpTXPD2ieWaMDjo/FzB6lj01LkSr9sMyVzsup7FfL32crZa2b2d0tCOLAN1ti AYhyAb941RBY+dn3wDakMdSG8I6hfkaUAYLWnMXeEr9N9TEZ0dogd5owboBUj36GtzRT DzGR1XhaAVU9JQjp/C7LdbTDBwpSS+UWjCaLWcvgcIoA8L1punqkgt5kRSA2JKG6HkVi bR159Oi2uIySo/HPZCywJAg0GycXwN+qXzhq1TIU66uvi4wjcICM6FhaVZHjbjv/oJsw Ebbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:subject:cc:to:from:date:user-agent:message-id; bh=asdBagzIrxHJrHgy8f5rqYoVBakp0lcdJh8BjgBMx0w=; b=BT5etMiJFog0b4OT4COp0wpcKeSPoETYqpqTv1x99XGcWLN6jUdOKlZH0gSWCWmytJ mg9j0IerswPzjb8yX82bb0govEYOTpzg6776m/g2EZPjV1xT/5PrwCPHei5yrDvqJZS8 rgi7adNn5JXMoRGtiFdhXGJ2uWNuJBDxxNYM5M1vJmG7bofmgR/d0XgKjyl7JJgkHduz InDd+RiB/LAkpYMVTRYuPIbivKQiolijvBRZ0u1eqRGLfLgBm0FU7gnAw7F2vcCshGE8 RNpoRVT0BFZ8zlT+YtT0G7Z2kjq78wJIcZ0iM9z6NphdJJcHeCVyiXS9Z6cZQ0pP9nE+ N8cQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id sd18si1177626ejb.534.2020.05.05.07.18.27; Tue, 05 May 2020 07:18:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729830AbgEEOP1 (ORCPT + 99 others); Tue, 5 May 2020 10:15:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1729822AbgEEOPY (ORCPT ); Tue, 5 May 2020 10:15:24 -0400 Received: from Galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67F42C061A0F for ; Tue, 5 May 2020 07:15:24 -0700 (PDT) Received: from p5de0bf0b.dip0.t-ipconnect.de ([93.224.191.11] helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1jVyLi-0001OD-5V; Tue, 05 May 2020 16:15:06 +0200 Received: from nanos.tec.linutronix.de (localhost [IPv6:::1]) by nanos.tec.linutronix.de (Postfix) with ESMTP id AF7E4FFC8D; Tue, 5 May 2020 16:15:05 +0200 (CEST) Message-Id: <20200505134904.457578656@linutronix.de> User-Agent: quilt/0.65 Date: Tue, 05 May 2020 15:44:06 +0200 From: Thomas Gleixner To: LKML Cc: x86@kernel.org, "Paul E. McKenney" , Andy Lutomirski , Alexandre Chartre , Frederic Weisbecker , Paolo Bonzini , Sean Christopherson , Masami Hiramatsu , Petr Mladek , Steven Rostedt , Joel Fernandes , Boris Ostrovsky , Juergen Gross , Brian Gerst , Mathieu Desnoyers , Josh Poimboeuf , Will Deacon Subject: [patch V4 part 3 12/29] x86/entry/common: Provide idtentry_enter/exit() References: <20200505134354.774943181@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-transfer-encoding: 8-bit X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Provide functions which handle the low level entry and exit similiar to enter/exit from user mode. Signed-off-by: Thomas Gleixner --- arch/x86/entry/common.c | 89 ++++++++++++++++++++++++++++++++++++++++ arch/x86/include/asm/idtentry.h | 3 + 2 files changed, 92 insertions(+) --- a/arch/x86/entry/common.c +++ b/arch/x86/entry/common.c @@ -510,3 +510,92 @@ SYSCALL_DEFINE0(ni_syscall) { return -ENOSYS; } + +/** + * idtentry_enter - Handle state tracking on idtentry + * @regs: Pointer to pt_regs of interrupted context + * + * Invokes: + * - lockdep irqflag state tracking as low level ASM entry disabled + * interrupts. + * + * - Context tracking if the exception hit user mode. + * + * - RCU notification if the exception hit kernel mode + * + * - The hardirq tracer to keep the state consistent as low level ASM + * entry disabled interrupts. + */ +void noinstr idtentry_enter(struct pt_regs *regs) +{ + if (user_mode(regs)) { + enter_from_user_mode(); + } else { + lockdep_hardirqs_off(CALLER_ADDR0); + rcu_irq_enter(); + instr_begin(); + trace_hardirqs_off_prepare(); + instr_end(); + } +} + +/** + * idtentry_exit - Common code to handle return from exceptions + * @regs: Pointer to pt_regs (exception entry regs) + * + * Depending on the return target (kernel/user) this runs the necessary + * preemption and work checks if possible and reguired and returns to + * the caller with interrupts disabled and no further work pending. + * + * This is the last action before returning to the low level ASM code which + * just needs to return to the appropriate context. + * + * Invoked by all exception/interrupt IDTENTRY handlers which are not + * returning through the paranoid exit path (all except NMI, #DF and the IST + * variants of #MC and #DB). + */ +void noinstr idtentry_exit(struct pt_regs *regs) +{ + lockdep_assert_irqs_disabled(); + + /* Check whether this returns to user mode */ + if (user_mode(regs)) { + prepare_exit_to_usermode(regs); + } else if (regs->flags & X86_EFLAGS_IF) { + /* Check kernel preemption, if enabled */ + if (IS_ENABLED(CONFIG_PREEMPTION)) { + /* + * This needs to be done very carefully. + * idtentry_enter() invoked rcu_irq_enter(). This + * needs to undone before scheduling. + * + * Preemption is disabled inside of RCU idle + * sections. When the task returns from + * preempt_schedule_irq(), RCU is still watching. + * + * rcu_irq_exit_preempt() has additional state + * checking if CONFIG_PROVE_RCU=y + */ + if (!preempt_count()) { + instr_begin(); + rcu_irq_exit_preempt(); + if (need_resched()) + preempt_schedule_irq(); + /* Covers both tracing and lockdep */ + trace_hardirqs_on(); + instr_end(); + return; + } + } + instr_begin(); + /* Tell the tracer that IRET will enable interrupts */ + trace_hardirqs_on_prepare(); + lockdep_hardirqs_on_prepare(CALLER_ADDR0); + instr_end(); + rcu_irq_exit(); + lockdep_hardirqs_on(CALLER_ADDR0); + } else { + /* IRQ flags state is correct already. Just tell RCU */ + rcu_irq_exit(); + } +} --- a/arch/x86/include/asm/idtentry.h +++ b/arch/x86/include/asm/idtentry.h @@ -7,6 +7,9 @@ #ifndef __ASSEMBLY__ +void idtentry_enter(struct pt_regs *regs); +void idtentry_exit(struct pt_regs *regs); + /** * DECLARE_IDTENTRY - Declare functions for simple IDT entry points * No error code pushed by hardware