Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp898132ybj; Tue, 5 May 2020 09:16:48 -0700 (PDT) X-Google-Smtp-Source: APiQypLdEtIhWVBe/r3TuLoMa4krsGM2Ec7ywcyQbkTcARTHfBJNIT8EAmVrlGvBTO6wtUZ2y46b X-Received: by 2002:a17:906:5958:: with SMTP id g24mr3648584ejr.58.1588695407851; Tue, 05 May 2020 09:16:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588695407; cv=none; d=google.com; s=arc-20160816; b=n6iXhTgNACK3kBWdegVXVR3oogEvGjlKEuwYOJervt6O8ry7DhlcKAbmKFFs72S1oE zyZ6VZxorYVmcuwZE9yBrLyzJzVRNLs34E2dtUtN31Bg3NFr5ud9t2NeZmXmEYkitZwo mKjYlA6/iqj0/qYxK42VzfAKPp+nshGiGPxzfyjC8L+e9NFg9/RpoM3Cc6RUeOPH/Vbj PoLl66ShJ9kLGM6/pKn5OmBlFisDzay44GqkzahRwsIj8ggE3s0GvTB5ejBtvjuEGCpA XMMPq7LN0B07eOmzLdBB+t/AmIZ7p/hPImI0Dbqa7ofyb6GJ3aOCZmRIpTqS8I0vz4Gk x1rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=WY2SW7m1ZuaSEsRnkoY3SUZR0I3YGl6FpRmKal/t8ZE=; b=bihBq0v9mzk0SPACltu9ftjbxDgZHlOPiU02X9vSocLHOKf5BPAg27f+l4i77DmnS6 r9TxItMSNY7ngDvmG9Dnmm9eXDh6ST0QVqwv1Xbsz9JhM6I26JC0bsj0wiD5j9duu5Xf OXvKIp0Byl9YpZIngxKLSoGCHgDhKRg6YeEARVZpMl1bPHtOl6dEge2RejM4erv4BpLg tOOYCwtZxEpAUl92fFYxKe4mOS/H8tPd3oZugEPCgIWdom1rumOw+8rAgnYwmoYDhSLr AXsC2LLV5AxMFEbLPYmCXXvmwHwS+NxzBYj3tgsvdhwbswLvhzKLMqUaDdFXoJjim7k1 QEWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YMruXtbw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ce9si1269816ejc.139.2020.05.05.09.16.22; Tue, 05 May 2020 09:16:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YMruXtbw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730657AbgEEQNz (ORCPT + 99 others); Tue, 5 May 2020 12:13:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:59430 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728807AbgEEQNv (ORCPT ); Tue, 5 May 2020 12:13:51 -0400 Received: from localhost.localdomain (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 75F6D206A4; Tue, 5 May 2020 16:13:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588695230; bh=dpXPFwKuVMrPa7413QY+1yJ7/pkzBpNiSnMEv+1die4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YMruXtbwRLDiFtaSuq49ZBOGAUPM520/Z9wz5f24Zvyj55NVRs57wCT7bIIr9epPJ MN6iiyCoC+MWBt+bCoJImrZ5O06KJ9UN5+NBbB+5xYeQ0a2RtMSXZUCXHXGNrYM+Im QUSZiMN0CryEfhf6eFAFwD5DGN046UE6m+oBJFlI= From: Will Deacon To: Daniel Thompson , Catalin Marinas Cc: Will Deacon , linux-kernel@vger.kernel.org, patches@linaro.org, Douglas Anderson , linux-arm-kernel@lists.infradead.org, Jason Wessel Subject: Re: [PATCH v2] arm64: cacheflush: Fix KGDB trap detection Date: Tue, 5 May 2020 17:13:45 +0100 Message-Id: <158869137087.244424.4260224460496540281.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200504170518.2959478-1-daniel.thompson@linaro.org> References: <20200504170518.2959478-1-daniel.thompson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 4 May 2020 18:05:18 +0100, Daniel Thompson wrote: > flush_icache_range() contains a bodge to avoid issuing IPIs when the kgdb > trap handler is running because issuing IPIs is unsafe (and not needed) > in this execution context. However the current test, based on > kgdb_connected is flawed: it both over-matches and under-matches. > > The over match occurs because kgdb_connected is set when gdb attaches > to the stub and remains set during normal running. This is relatively > harmelss because in almost all cases irq_disabled() will be false. > > [...] Applied to arm64 (for-next/misc), thanks! [1/1] arm64: cacheflush: Fix KGDB trap detection https://git.kernel.org/arm64/c/ab8ad279ceac Cheers, -- Will https://fixes.arm64.dev https://next.arm64.dev