Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp1004198ybj; Tue, 5 May 2020 11:14:30 -0700 (PDT) X-Google-Smtp-Source: APiQypJ2w0tQ1qVxG6XIwCAsncW9LMYPznfu4GTnn4WCnhZ9XPu6sjKOXqbGTcMVHbH5R+gHaKPs X-Received: by 2002:a17:906:3198:: with SMTP id 24mr3696249ejy.39.1588702470750; Tue, 05 May 2020 11:14:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588702470; cv=none; d=google.com; s=arc-20160816; b=owDbVOBsYF98wse1l1bioBUhjDddrzAXSmw5Il60rjmFj0gRD3Gbu5Pqs/GIGAa6G+ DGJvxRE1Xq0a63EAZJX1eLgYM2zrzMHHHmzd/CLMauC/uNcT0fDcNdhYJUISiPm6qfVE ZTpbnr1T1TQ7TSw9VUUQr6GVlY3Q8Bui0lbRQlL7rRshtPfeNl+ZuDcTvVhdQklySuQQ vY6Ql4BOOLIUCfSQsEYIuCLHWJWsxQJTc6PUmQsU7Fk5KhfQtZrjcuc7VEAoWs5BxJe2 h+CUsemTcq/R9lXRxFThaCp17tbpqzmDKmAvH5R0Rbz99LjFQkBgZwdhBNmIOC4i4NNv IVog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=7Sl8u3vCtur/Q35QHcGjpI9sY0sn+zS1YEXLPVk2s6c=; b=sxT70w+2gyaJw3UQwcT8Ys+JoW/NM0PEXhOfJnCfVbutn16xlFtvxxMvC5oirlFxZv X5YMd8IU8kG1o7RRUuZ0ujpxC4e/xyd7nw1YdHb8njxarThYmITqfuXBzijj7yR+3et/ rII85KyCCzwErnv/V0/BsRHdZMLmt3NSg2grimBmU+KHQgwoeD5dhned+xJr2XlQ4pYs UUTHyWuB4lA5AFndBFFSu5NJYiQblxshJ/8SD3ew3wfkg28I7fgTKaWaiNUZszwUUhh4 XaxzE7KAa81hXM2jQJAXjT706rzE16bB4RFVNmPOyIC/fZhgheq9dr5lrVAMViz8U/vp fXwA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t5si1793667edr.374.2020.05.05.11.14.08; Tue, 05 May 2020 11:14:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730763AbgEESMP (ORCPT + 99 others); Tue, 5 May 2020 14:12:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729663AbgEESMO (ORCPT ); Tue, 5 May 2020 14:12:14 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE456C061A0F; Tue, 5 May 2020 11:12:14 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 8D08A127EDD2C; Tue, 5 May 2020 11:12:10 -0700 (PDT) Date: Tue, 05 May 2020 11:12:06 -0700 (PDT) Message-Id: <20200505.111206.118627398774406136.davem@davemloft.net> To: zhengdejin5@gmail.com Cc: swboyd@chromium.org, ynezz@true.cz, netdev@vger.kernel.org, jonathan.richardson@broadcom.com, linux-kernel@vger.kernel.org, scott.branden@broadcom.com, ray.jui@broadcom.com, f.fainelli@gmail.com Subject: Re: [PATCH net v1] net: broadcom: fix a mistake about ioremap resource From: David Miller In-Reply-To: <20200505020329.31638-1-zhengdejin5@gmail.com> References: <20200505020329.31638-1-zhengdejin5@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 05 May 2020 11:12:11 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dejin Zheng Date: Tue, 5 May 2020 10:03:29 +0800 > Commit d7a5502b0bb8b ("net: broadcom: convert to > devm_platform_ioremap_resource_byname()") will broke this driver. > idm_base and nicpm_base were optional, after this change, they are > mandatory. it will probe fails with -22 when the dtb doesn't have them > defined. so revert part of this commit and make idm_base and nicpm_base > as optional. > > Fixes: d7a5502b0bb8bde ("net: broadcom: convert to devm_platform_ioremap_resource_byname()") > Reported-by: Jonathan Richardson > Signed-off-by: Dejin Zheng Applied, thank you.