Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp1008676ybj; Tue, 5 May 2020 11:19:19 -0700 (PDT) X-Google-Smtp-Source: APiQypJqcq1c9ZhG9oReovMPU0WBs+HSdpaxUIzx6X02Lx20Y79rjft57gdvyhs7YZcRJY3unxyK X-Received: by 2002:a50:d596:: with SMTP id v22mr3704591edi.91.1588702759761; Tue, 05 May 2020 11:19:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588702759; cv=none; d=google.com; s=arc-20160816; b=ncfjp7V/yW0ooJ6GqRB9whjGGXOl7D2q7GhuPIPFuS+mUmVOg2jh7msPEsrHtwGK2u SKoXcOvVTMRzCsLZ75Q/Z/dXG+BR2RBcC9AQqDEOxe3pWaSja5imGbTPa7BMRP2U91yh ao9lDNNHnUtR4VeAkC1TIYtybtsxtEY/EBYzncDrZBRAInYuwBX6N/dvoyJ13TcmyKt6 Ea7dk0zhLLB+s+vO3NhnCVe23bhQ6wN1XPW5Kd53C+zFRadSgWPGyt4CiSQXEVEnlFNS mnNc4BFUnhA1+lTd0vV3LT7SRDsCmW2KLdB/zIJcKZOSlx/bIgGjiVb/v52k/JGxOcB/ nfaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=wKOanS3DZQirO8yTsXSGkjYLBJnWPNZ2qyQnKCYVpmA=; b=Z10zgXafkvT8CTeq1e0sJ1r+5No1/06PhFMByNJzEPAqdKsRfG/YjZdEfOP7NonQdH Kat44fWiY+UG5EjYA+DM/9helI3IrfntEHvApMgBjcK50lOFBOu5zcVhdpnNBzhSu6pV rzMGbJur0Zxk7vUjWGd4esVts9Nx7j2OletgTYmj0tpvc1JJEzDF15HT+GTfSFMZfDkq UWVZjcHTIIX4NzlaWvpWAz+nYvjQZQopH3zHxzohtuveZDm97nrgqCIuLwsodLN8jgPh l4M+U4H+tVCuMTGXeATk6Nsrsc3xTsqh6Z1HJSszJgFyXDvoTzZ8Bik3ywErTVIPQQle 888g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fYBbpjo9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r12si1715919edm.95.2020.05.05.11.18.55; Tue, 05 May 2020 11:19:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fYBbpjo9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730800AbgEESRa (ORCPT + 99 others); Tue, 5 May 2020 14:17:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:32882 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730258AbgEESR3 (ORCPT ); Tue, 5 May 2020 14:17:29 -0400 Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 82C2220663; Tue, 5 May 2020 18:17:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588702649; bh=oZIhy4uAhQMfRftPSAxXEs0/SUwk5XbjQFCfi1/11+o=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=fYBbpjo91qL2bwN6FFFUcLIk0cn3McB4ntM5Qt+Rrvckuh/34djzMcYKkrf5Umuym G0X2rpkq9+fFecmn/LBEwtxYj2swjIIAPRxsGVdZ0sKb8t7MDrhLmSLSz3PzMON8oM 9rHKTFfE0VbReNi0WnRWnKbEJI23LGHeGbxhUnCQ= Subject: Re: [PATCH 0/3] selftests: vdso: Add a selftest for vDSO getcpu() To: Mark Brown Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, shuah References: <20200505174728.46594-1-broonie@kernel.org> From: shuah Message-ID: Date: Tue, 5 May 2020 12:17:28 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200505174728.46594-1-broonie@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/5/20 11:47 AM, Mark Brown wrote: > This series does a bit of a cleanup of the existing tests for the vDSO > in kselftest and then adds a new test for getcpu(). > > Mark Brown (3): > selftests: vdso: Rename vdso_test to vdso_test_gettimeofday > selftests: vdso: Use a header file to prototype parse_vdso API > selftests: vdso: Add a selftest for vDSO getcpu() > > tools/testing/selftests/vDSO/.gitignore | 2 + > tools/testing/selftests/vDSO/Makefile | 5 +- > tools/testing/selftests/vDSO/parse_vdso.c | 24 +-------- > tools/testing/selftests/vDSO/parse_vdso.h | 31 ++++++++++++ > .../selftests/vDSO/vdso_standalone_test_x86.c | 4 +- > .../testing/selftests/vDSO/vdso_test_getcpu.c | 50 +++++++++++++++++++ > .../{vdso_test.c => vdso_test_gettimeofday.c} | 10 ++-- > 7 files changed, 92 insertions(+), 34 deletions(-) > create mode 100644 tools/testing/selftests/vDSO/parse_vdso.h > create mode 100644 tools/testing/selftests/vDSO/vdso_test_getcpu.c > rename tools/testing/selftests/vDSO/{vdso_test.c => vdso_test_gettimeofday.c} (84%) > Thanks Mark. These look good to me. I will apply them for Linux 5.8-rc1. thanks, -- Shuah