Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp1037913ybj; Tue, 5 May 2020 11:52:33 -0700 (PDT) X-Google-Smtp-Source: APiQypI81oMogTRgSBPa+1q7QHQRBWhQJBqEtl3EOmwZqBfCACU/hYK3C97jEmuksQg1DHrFfF/L X-Received: by 2002:a50:baa6:: with SMTP id x35mr4093691ede.54.1588704753019; Tue, 05 May 2020 11:52:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588704753; cv=none; d=google.com; s=arc-20160816; b=lUsgBI0WuAFdS8toO3T8r9It40lmzdwqsmAZqRhTMiBmqtZGvEy9MAp06swz1K58RM mgZzVz9r4qYSGbmIuSz283lQ8mHamxXcFNY7Hv056a9zoFocbiYaH4mYJeBhc5O0LM3Z xxpTTB9Kt6uWqzwU6naKIegRGXgYk4+gbPoBxcjHrhQTo5dLSv3nFlmSpY6lgGk5WSGd lTSTOsiZhRCCARHinu6SGIS12DWJwB4Qi6wziuniSpz+qa4MFEab3G31Bgx3xcYJNFyq szQ1VUqqHzEhpgZSrqQpig8BXxpgbTiliu3OcHMhM5UReJv6acFmjdhvDGJdMZ4LSRV4 g68w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=ALl8X3rtizxgvj7XQLJD1OBCJnkKpWHU91oBoAmMrjk=; b=OF9FXya3EBGyLtVwROB3YuFazP1Ud/IcJxATkdSlbS3MDdUWAlhhphc3+fhLaZ1aUr Uu0swfJoA8HnN+x0jx0waw2mAA+T7oXFEzPuq1On0M/WkDtMEi9NcCE51i0AJkTeZLz4 8ax4X6jagTk2paYexY3BsRb5PpRSG+LQxJfJnf2nSMyxS69BpUvlRpwhCU1JoF6GiqUm 7LmW17lpIQSiiONKXOIpJntAy2r65UhEN8DiqYTKIB7YjTOQFjyknBS0hmS3CsnRSK+Q MlSjz1FOCAt4B5EF5BBAVmsSFAJI09eFkFLt43hlFnwWOnMVd/AezACHIQFKkfmtaMJY LGbQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w20si1508727ejq.91.2020.05.05.11.52.10; Tue, 05 May 2020 11:52:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728990AbgEESsa (ORCPT + 99 others); Tue, 5 May 2020 14:48:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726350AbgEESs1 (ORCPT ); Tue, 5 May 2020 14:48:27 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B955CC061A0F; Tue, 5 May 2020 11:48:27 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id BC5A7127F9DC3; Tue, 5 May 2020 11:48:26 -0700 (PDT) Date: Tue, 05 May 2020 11:48:25 -0700 (PDT) Message-Id: <20200505.114825.1476000329624313198.davem@davemloft.net> To: sjpark@amazon.com Cc: viro@zeniv.linux.org.uk, kuba@kernel.org, gregkh@linuxfoundation.org, edumazet@google.com, sj38.park@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, sjpark@amazon.de Subject: Re: [PATCH net v2 0/2] Revert the 'socket_alloc' life cycle change From: David Miller In-Reply-To: <20200505081035.7436-1-sjpark@amazon.com> References: <20200505081035.7436-1-sjpark@amazon.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 05 May 2020 11:48:27 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: SeongJae Park Date: Tue, 5 May 2020 10:10:33 +0200 > From: SeongJae Park > > The commit 6d7855c54e1e ("sockfs: switch to ->free_inode()") made the > deallocation of 'socket_alloc' to be done asynchronously using RCU, as > same to 'sock.wq'. And the following commit 333f7909a857 ("coallocate > socket_sq with socket itself") made those to have same life cycle. > > The changes made the code much more simple, but also made 'socket_alloc' > live longer than before. For the reason, user programs intensively > repeating allocations and deallocations of sockets could cause memory > pressure on recent kernels. > > To avoid the problem, this commit reverts the changes. Series applied and queued up for -stable, thanks.