Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp1101093ybj; Tue, 5 May 2020 13:05:46 -0700 (PDT) X-Google-Smtp-Source: APiQypJLgj9XtZLBntl+Ob9IFG0WjwG/Rcff7lJBPNg9sL7AtmjfqEc0vYVCoNOYEL0JcMvsAIFa X-Received: by 2002:a17:906:d10b:: with SMTP id b11mr4245680ejz.62.1588709146368; Tue, 05 May 2020 13:05:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588709146; cv=none; d=google.com; s=arc-20160816; b=BVjUg3uDzrq3oqgokuH2B4gqD/DpNTKwMryb1/wNd3/CQrVRx/OrkZ4ycCNQOP6rxa +4wAuopY6SNQ5ubi8jizPZRv/t+JU4tKwk9W0ooorvaY0yKc6dgXoNWVs9qvJzz9ZmDJ a/9Q6473O0TNPqI64CR9htTOWr7r/zUtWxkB/AqLkuKliChPAg5GwOFQhZBp5Czo4Squ 5beaFVoQv0xsBwl63x1+FrMjR5CypO2x2xvmMOErEyeuRQVp9J/bCyM6fH5p5u98/Mbd zCzjKvNkH6z/S+wxoCRAL4hLJ6awad2dIT3s6bM3QXbZGfxS+nB1ZiOKLQzvkGjsL+qA BfSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=pipuDpvfZfNEKvyznB3sFn0XZCEjfP3aGCbir969T00=; b=Iv5J3i0N6Pibcl17o9sgjw5lxFORydd35b9LiN2Wx6xKaexOTT1skSvTGBIdpTjirA FHQ29e0ImRcE9VZu7SWzSV1WaLvEo2VOL+vRJP8N9I8pvq6cPdga/tNrCR/u/l05z5pA cm2TFV5/Oa8cdxBrPrE6/Sy7MaxnBwMc+R1kgP86Caq3BdhhiTp3v+MSWmetIFF3+5bB DIpAmD3z0uoeJlTzZXr95IoYkxI5K/h0VyMafD76BCQdIRGtqPY4Q81USYb4/IwxBghG Ct+ATAh/TxL2dMK1uP0FQ2qE+lvdPlIqtPq3n6eGBdj7expop3MhUwBW2Q343vR9V3ua nLYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=WwvCor+T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a24si1115059edj.166.2020.05.05.13.05.23; Tue, 05 May 2020 13:05:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=WwvCor+T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728737AbgEEUD6 (ORCPT + 99 others); Tue, 5 May 2020 16:03:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:59622 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728076AbgEEUD6 (ORCPT ); Tue, 5 May 2020 16:03:58 -0400 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B8C4320721; Tue, 5 May 2020 20:03:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588709038; bh=pipuDpvfZfNEKvyznB3sFn0XZCEjfP3aGCbir969T00=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WwvCor+TCXaNSHxEPhW+wZHOhGU+Y7VyxOCqaP0HoQ9AXGK9gf7EYBTVp1Gl5vtMQ x7VV35YV/frw6TCrsjt61fsKtY6z2VpbO1pB5ElqAzjpZ+LanP65zXKuuqZD6BHnZv uHTI3xf5cyzxpht7jsg74g2DGZ3VFLqSGeSUBCis= Date: Tue, 5 May 2020 13:03:57 -0700 From: Andrew Morton To: Roman Penyaev Cc: Jason Baron , Khazhismel Kumykov , Alexander Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/1] epoll: call final ep_events_available() check under the lock Message-Id: <20200505130357.04566dee5501c3787105376f@linux-foundation.org> In-Reply-To: References: <20200505084049.1779243-1-rpenyaev@suse.de> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 05 May 2020 10:42:05 +0200 Roman Penyaev wrote: > May I ask you to remove "epoll: ensure ep_poll() doesn't miss wakeup > events" from your -mm queue? Jason lately found out that the patch > does not fully solve the problem and this one patch is a second > attempt to do things correctly in a different way (namely to do > the final check under the lock). Previous changes are not needed. Where do we stand with Khazhismel's "eventpoll: fix missing wakeup for ovflist in ep_poll_callback"? http://lkml.kernel.org/r/20200424190039.192373-1-khazhy@google.com