Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp1111680ybj; Tue, 5 May 2020 13:18:12 -0700 (PDT) X-Google-Smtp-Source: APiQypIwXSd95KRVSjf9vG2vlyx17jjbgDH5gGipisPEEIuVqhG/3LMXlyv9ZJPPOuxTlET7wsMh X-Received: by 2002:a17:906:1502:: with SMTP id b2mr4391650ejd.359.1588709892003; Tue, 05 May 2020 13:18:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588709891; cv=none; d=google.com; s=arc-20160816; b=U9lSFg3ZYY/IeBm/M9pHms5ne5hXPTUz4RGReeUfF/u3OpmmdMQbhdEMgUqqY1jnX2 8K7yklV9FhmkQ4eCDsk4B9RIVkJuqyf+jU/pJADA/5EeDH4bHYhaVVfmIPG8hm/gVIop p60GuCnSWlp9Gfrl/5OlN5X+uO2tK3JD5csk3ImxIfxbYi0BM+OrI1yXVKJtWLjGYq30 eDaLnNTXP6xtn4BvyOrGHLnYe0c2m++LMD3726dQhUolAtTzjBtHpU46duCTOa+b5TLP FnUzZWqq1+tC1em8vx8b7KOHMp1kRyIMW5AXUQ+QkiMOVme5mzrp5uNgY+NTxj4gjjVD LT3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=KbP40KP0Tytfb2z8VHrbGlcu/EjSaji9XtREHLqrwFI=; b=RagmfJEu0lyYXKJJQaQPGsaL5gF+M3/yykXRd9fw/7F8ZfgCKG2r3iiwuee53kAnax cGI5GBHAG6ufT7c+C4UEpFw11AiNMRtiQLsM1wHktCwbYoCg7lULAzm02VMsc6Wh85O8 rfZ0p1/z83TcWsNIthqgZL6dPkc96BSvla3D5uQo8Bv1dnfMQQnIAjZJmxk+eoOWMt1P uT3H41uLK0JblmioDa/dVVQnS/ff8MEp/5VD+9sbXGBKKutUBvgHcybyUqmB4qmUdKYi g4pHZGsgjRyTEtA/BtYoy9LugFXXZlidtXwzFZGDCD6SnadgKc8NRiCT36xYJMLh63Iw fxng== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b9si1662566ejq.79.2020.05.05.13.17.48; Tue, 05 May 2020 13:18:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729164AbgEEUOB (ORCPT + 99 others); Tue, 5 May 2020 16:14:01 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:60273 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727785AbgEEUOA (ORCPT ); Tue, 5 May 2020 16:14:00 -0400 Received: from localhost (lfbn-lyo-1-9-35.w86-202.abo.wanadoo.fr [86.202.105.35]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 72AAE200003; Tue, 5 May 2020 20:13:45 +0000 (UTC) From: Alexandre Belloni To: linux-rtc@vger.kernel.org Cc: Rasmus Villemoes , =?UTF-8?q?Per=20N=C3=B8rgaard=20Christensen?= , linux-kernel@vger.kernel.org, Alexandre Belloni Subject: [PATCH 3/5] rtc: pcf2127: remove unnecessary #ifdef Date: Tue, 5 May 2020 22:13:08 +0200 Message-Id: <20200505201310.255145-3-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200505201310.255145-1-alexandre.belloni@bootlin.com> References: <20200505201310.255145-1-alexandre.belloni@bootlin.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is not point in setting .ioctl to NULL when CONFIG_RTC_INTF_DEV is not defined because it would not be called anyway. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf2127.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/rtc/rtc-pcf2127.c b/drivers/rtc/rtc-pcf2127.c index 136709baaa88..5ac996578523 100644 --- a/drivers/rtc/rtc-pcf2127.c +++ b/drivers/rtc/rtc-pcf2127.c @@ -184,7 +184,6 @@ static int pcf2127_rtc_set_time(struct device *dev, struct rtc_time *tm) return 0; } -#ifdef CONFIG_RTC_INTF_DEV static int pcf2127_rtc_ioctl(struct device *dev, unsigned int cmd, unsigned long arg) { @@ -205,9 +204,6 @@ static int pcf2127_rtc_ioctl(struct device *dev, return -ENOIOCTLCMD; } } -#else -#define pcf2127_rtc_ioctl NULL -#endif static const struct rtc_class_ops pcf2127_rtc_ops = { .ioctl = pcf2127_rtc_ioctl, -- 2.26.2