Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp1117985ybj; Tue, 5 May 2020 13:26:53 -0700 (PDT) X-Google-Smtp-Source: APiQypIa//wmU6z6j5uwCLW4OdS4++rLmkhqXRc9arVVkp2q7bwkEu7geqIHQkZJ0IcYAmsT7vsN X-Received: by 2002:aa7:d514:: with SMTP id y20mr4356898edq.28.1588710413374; Tue, 05 May 2020 13:26:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588710413; cv=none; d=google.com; s=arc-20160816; b=VMl/F1mstpesq8lKq/Y9QSczt+DXRcwM7R1hN7FjR9bCMVhTbMBcz/cZAWq3InotRb u1o9ZqIX8iVCM6GV1Wi2/VIr/QTAbEcsmLzGg9ZuLvxQ2xD7wzVeroUh6qODjhtEgC9l 9Iqk43fn8yzWY+C8xSQ64tYAn5uaz9t0JFAiWUFinBK+CxIMWQ7iE3RDqJEqVt1OEaDf fvswo+TkJubJfZ5m8+Tx5ScKQFET31oF4L69H2RqkWKFON+O5GjJ6GZKrnfKlfFkcaIy xacTh13TA7LBLmYl1uI7nkMHgic7X0RXE/BGaZ97v253LrUGIvws43EwPT2epM0pxsUK hf0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=+7ccSn4HVUVygULcv7AeheGQ7hIuB0Tt/+0tGWc80y0=; b=vSRgpsV2PE18p5d0g3apvamR1UzTuRwPtr1UK6wfTkSNtHNAqFzwyDLaloTkDtZQEQ NnJFkVV773hdDSGTIKOInGde6s6mK1zTHYbrxLY3eIvh6bZJQ1G9QZ588tcVgU3K/NYN m88KitjYgvASA96M6n1NGyFId0VHqq8Ut56fmSCHeU6W6qu4eqfo3m83BqOpe5huxWOJ cyJMOWXmkQORejaBevFG+Gl1UUrXNgMHxU2GOHyj+zc5czvqY6fQXdYdoA8KcvDAYB7t U2vwArS/FqiQgcEjKK3vHTLd26GBM5YZ3r/FN3ab2sS+IYUeWlgA9WGq857guDYBVqSd K3UQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m11si1760869edq.373.2020.05.05.13.26.30; Tue, 05 May 2020 13:26:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729037AbgEEUZA (ORCPT + 99 others); Tue, 5 May 2020 16:25:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1728756AbgEEUZA (ORCPT ); Tue, 5 May 2020 16:25:00 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FE99C061A0F; Tue, 5 May 2020 13:25:00 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id C90331280C7D8; Tue, 5 May 2020 13:24:59 -0700 (PDT) Date: Tue, 05 May 2020 13:24:59 -0700 (PDT) Message-Id: <20200505.132459.1059623707678036566.davem@davemloft.net> To: grygorii.strashko@ti.com Cc: anders.roxell@linaro.org, netdev@vger.kernel.org, nsekhar@ti.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next] net: ethernet: ti: am65-cpts: fix build From: David Miller In-Reply-To: <20200505162123.13366-1-grygorii.strashko@ti.com> References: <20200505162123.13366-1-grygorii.strashko@ti.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 05 May 2020 13:25:00 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Grygorii Strashko Date: Tue, 5 May 2020 19:21:23 +0300 > It's possible to have build configuration which will force PTP_1588_CLOCK=m > and so TI_K3_AM65_CPTS=m while still have TI_K3_AM65_CPSW_NUSS=y. This will > cause build failures: > > aarch64-linux-gnu-ld: ../drivers/net/ethernet/ti/am65-cpsw-nuss.o: in function `am65_cpsw_init_cpts': > ../drivers/net/ethernet/ti/am65-cpsw-nuss.c:1685: undefined reference to `am65_cpts_create' > aarch64-linux-gnu-ld: ../drivers/net/ethernet/ti/am65-cpsw-nuss.c:1685:(.text+0x2e20): > relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `am65_cpts_create' > > Fix it by adding dependencies from CPTS in TI_K3_AM65_CPSW_NUSS as below: > config TI_K3_AM65_CPSW_NUSS > ... > depends on TI_K3_AM65_CPTS || !TI_K3_AM65_CPTS > > Note. This will create below dependencies and for NFS boot + CPTS all of them > have to be built-in. > PTP_1588_CLOCK -> TI_K3_AM65_CPTS -> TI_K3_AM65_CPSW_NUSS > > While here, clean up TI_K3_AM65_CPTS definition. > > Fixes: b1f66a5bee07 ("net: ethernet: ti: am65-cpsw-nuss: enable packet timestamping support") > Signed-off-by: Grygorii Strashko > Reported-by: Anders Roxell Applied.