Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp1135192ybj; Tue, 5 May 2020 13:51:22 -0700 (PDT) X-Google-Smtp-Source: APiQypKUrn4Qg8tA6wxL3985pT7Ne0MOO8HZb/UBlLy0sEqYrEhmuNWXv9q3zaAs9KTZpkkw3Kao X-Received: by 2002:a05:6402:1bc8:: with SMTP id ch8mr4248514edb.53.1588711882274; Tue, 05 May 2020 13:51:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588711882; cv=none; d=google.com; s=arc-20160816; b=gvxRx4cYOpzguy9+R1CGcd99oCQONufpRNSXwGxl/825MIZ2+4EiagMKG+obtsvAw6 pSph++AdRNXc+Jg3DmQ38wiQhdFUlZ+17uyk7neFxbAz9kN0gjV5Ib6sTNvyUrBnn/o5 5m/GdIwF4cz/BQIal0Hfs0KDivdNfM+OyOynCxO+J9hDda1jgDAXjijNHXlozQ9vPrSZ WawTT6rvGbyCaUj/cIpPi+OmMTYmtcuv8GuMpy4C8Qpnx9Q6MsQFdezKuhjKGI3+q6PX EqVauugs9K7qV5TuweIWUw0rv6mk9yrFiYdwkEudvklYr8vDFoiOmbWpCUpjL0lNjL4M Ss5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=gDQj+SjGugMQF8uI+esHL1nC61saNTbGZKF9q4vD+qY=; b=ZLf9HiR3KW08EHETOBfPKYhi23A/izbwkwhMPTE9ancZilQNwLp8Zojuk/ZYoDmoXG tBT7IlEyH5pBx56ieLjdUSbU/Bps3zR5II4gqtoH6JmX2HgbQbYQm3ope/1fhuubfTC+ bWlIzm4sYnfxGjE9GdSW2yJ28URB9Rv9iOvNPY1hcMlcASydy6Y6gpYoVpE2jzSFvS+J jFLwAOL2Qpt/tv+1bQ3PqksZDgesk6a/kP1/60VbUBkjhZ6pBcRttbaoNHwtsd1VU9iv QCjVYa+e36OoLu69oTeB1BwLkrQY/UoMtN6W1uq2Ce0oIJcdrc8op04gFACsiUZicQ4Y nNSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=X68YJ+61; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q28si1833100edb.547.2020.05.05.13.50.59; Tue, 05 May 2020 13:51:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=X68YJ+61; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728853AbgEEUtf (ORCPT + 99 others); Tue, 5 May 2020 16:49:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726593AbgEEUtf (ORCPT ); Tue, 5 May 2020 16:49:35 -0400 Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E932AC061A0F for ; Tue, 5 May 2020 13:49:34 -0700 (PDT) Received: by mail-pj1-x1044.google.com with SMTP id a7so142807pju.2 for ; Tue, 05 May 2020 13:49:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=gDQj+SjGugMQF8uI+esHL1nC61saNTbGZKF9q4vD+qY=; b=X68YJ+6115N6xJQyXmzCTQ+PpT+i6HwBzGRgAcXyUKaveCJp095cI3uGI+MEomoRZ4 vvTeHPcOmw+LFxFuzftrI04yLDpWfcrQg4wNP+0hkHCoOBk6ys5D2SFBIRw2i5ZKl9Da sxRMptkqta1hpE1wpKHxnWvOeTW6xpYDTH8pA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=gDQj+SjGugMQF8uI+esHL1nC61saNTbGZKF9q4vD+qY=; b=RlSs1upU/dwd6n+TM6KWPi8zMPZ+B+M2QGz1DOr1A1A/dnVviabR9MbKtEcetgREht iCzPL7sdb9AVZ61foDOLUAAhbKDR2ts+I4+/kMw6guP0APLQ8lVNOKdZRQ+mA9n6L6sE wJkAjdN+OsE2nMLOmUe3N1kCWMRAIXyhF+5tb8UgZEJunWfWzvi3fQOt7zMFDEVWNKyi 9yKHuWGJGPSy6T5mvVCfjVuUffNo4w2h2opfp1fCFuf8GVadSo7HmY4+Xw71lRom3weD LUKwb/aDkLroZY/PNMRHOaTLymzzWYcCDeDqZm6x1JYTp4U9l9b5pM6XFr47ItJa07k1 Ko5A== X-Gm-Message-State: AGi0PubCuM94zCUZJG0TsGrtGnRrVtR7amnHWeSy4aSlOklQ8qhVLw/f c6kFBFHBY7mgbTBOLTIApDeia76X5v0= X-Received: by 2002:a17:90a:8c3:: with SMTP id 3mr5039320pjn.147.1588711774351; Tue, 05 May 2020 13:49:34 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id j7sm2832507pjy.9.2020.05.05.13.49.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2020 13:49:33 -0700 (PDT) Date: Tue, 5 May 2020 13:49:32 -0700 From: Kees Cook To: "Eric W. Biederman" Cc: linux-kernel@vger.kernel.org, Linus Torvalds , Oleg Nesterov , Jann Horn , Greg Ungerer , Rob Landley , Bernd Edlinger , linux-fsdevel@vger.kernel.org, Al Viro , Alexey Dobriyan , Andrew Morton Subject: Re: [PATCH 3/7] exec: Rename the flag called_exec_mmap point_of_no_return Message-ID: <202005051348.E3358B456@keescook> References: <87h7wujhmz.fsf@x220.int.ebiederm.org> <87zhami2xp.fsf@x220.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zhami2xp.fsf@x220.int.ebiederm.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 05, 2020 at 02:42:26PM -0500, Eric W. Biederman wrote: > > Update the comments and make the code easier to understand by > renaming this flag. > > Signed-off-by: "Eric W. Biederman" Reviewed-by: Kees Cook -- Kees Cook