Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp1141034ybj; Tue, 5 May 2020 13:59:51 -0700 (PDT) X-Google-Smtp-Source: APiQypIzcJfEHJkAG9aSRSOAHSOMKhxI+86ozrLYHwMdpPSgS+sO6+PFzm/XiPzX87gL+ei/tatP X-Received: by 2002:a17:906:25cb:: with SMTP id n11mr4722107ejb.37.1588712391557; Tue, 05 May 2020 13:59:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588712391; cv=none; d=google.com; s=arc-20160816; b=hOVAsBwCuiuUDNtBTedNUEb/qNdpWxmF1EprK1FyPSsn5MaVOMAE+Kt39szta802NT 7cMt1w1wLn/lGeO8pMfwmZ/BsV8p2w870wOp03YXAi48vO8Syle1b0YIYklcLea5i0TR P3ZuXDE388BcfOdSVda1MszPEvYfiECGEhoGQElLZoYEyugKGTgRTeLg7NteCxkUX0Oy zUT2mKNl27Tm3cNJkqYFDDtDQzwvDOLzhz1wb+qyR6obv6expKkR0PkCClTYniCIBn3J MgJ/36MimzMoTc6v8e1x+LkiwwYPDAyTQ7WO8UVrfmNe3muo0BQzZUJwnVVUXzitW76j usyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:message-id:references :in-reply-to:subject:cc:to:from:date:content-transfer-encoding :mime-version; bh=hSjVMGFlwPorXVBMxP4QrRA9zxVCulwYyG9XqXM6mGs=; b=pr9ucOgqJrYqVRwNqtKDeOYPcv1JXLEcLKpOUo2TS59NqoPQSyxhMZEjQmP9sauYYZ I6Q4UMADMFJwKaYYtBC7/gpAerLJFtD5AaKmnMP+7q/+V9thjQo1gM7Lg76FF6ZGzbI6 CZI+iu5/4N2KuM6k22ZBzJEGFzdbyeyrYpos6eKsiI+1/3ftYfw39JQ9i0NYYzy/Y9sm LHn25Dg6CKIqR8fy+PtNt6Hs9r8c89FFFpw2xr5YofeHz5xRjvvl81FerK7haoKcYEvr 1Nv/vYJl7cO6S75UZrxeR2j6pD6eoql5/Rfe7QadHjuamuY4e/nB0y0RI+FbYONX70Fv jpew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o59si1967134eda.39.2020.05.05.13.59.28; Tue, 05 May 2020 13:59:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729060AbgEEU6D (ORCPT + 99 others); Tue, 5 May 2020 16:58:03 -0400 Received: from mx2.suse.de ([195.135.220.15]:44922 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726593AbgEEU6D (ORCPT ); Tue, 5 May 2020 16:58:03 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 067EAACB8; Tue, 5 May 2020 20:58:03 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 05 May 2020 22:58:01 +0200 From: Roman Penyaev To: Andrew Morton Cc: Jason Baron , Khazhismel Kumykov , Alexander Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/1] epoll: call final ep_events_available() check under the lock In-Reply-To: <20200505130357.04566dee5501c3787105376f@linux-foundation.org> References: <20200505084049.1779243-1-rpenyaev@suse.de> <20200505130357.04566dee5501c3787105376f@linux-foundation.org> Message-ID: <35b7d79b5cc7ee5befb1e632043701a7@suse.de> X-Sender: rpenyaev@suse.de User-Agent: Roundcube Webmail Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-05-05 22:03, Andrew Morton wrote: > On Tue, 05 May 2020 10:42:05 +0200 Roman Penyaev > wrote: > >> May I ask you to remove "epoll: ensure ep_poll() doesn't miss wakeup >> events" from your -mm queue? Jason lately found out that the patch >> does not fully solve the problem and this one patch is a second >> attempt to do things correctly in a different way (namely to do >> the final check under the lock). Previous changes are not needed. > > Where do we stand with Khazhismel's "eventpoll: fix missing wakeup for > ovflist in ep_poll_callback"? > > http://lkml.kernel.org/r/20200424190039.192373-1-khazhy@google.com This one from Khazhismel is needed. Others are complementary to the Khazhismel's, except the "epoll: ensure ep_poll() doesn't miss wakeup events", which you've already removed. Thanks. -- Roman