Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp1162856ybj; Tue, 5 May 2020 14:26:45 -0700 (PDT) X-Google-Smtp-Source: APiQypJZlry4wlB05EzLHMDRPQC1LOt3EahjTKn2qhLOFcYS3XYMZ/1nt1x7lOdqZrOcBBQIwu+U X-Received: by 2002:aa7:d5d4:: with SMTP id d20mr4598685eds.369.1588714004973; Tue, 05 May 2020 14:26:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588714004; cv=none; d=google.com; s=arc-20160816; b=Y92GBxxIpDlorZSYXaT2VhO0kpU/DPGakeCY4Nv7RMt1jr0JAZ5qFA1wWlVskD8Qr1 RVcdja5OSsx5e3uSq0f9lZBfzOJcj27xjfgc5XrLNfaEpL1ThVC18SrWikZBC0Xqhq5c NCnjk1futWRI1ulnIPOCEt6bZDN89VbK9OZ4O2XYjQDL5m01Gsuf6DZi56ux/UzzsHgV +IJXZwpH/a4P3l9f124jOGIJzbIk7IrI0HD0ZVpIUU24BwRFOExpKfnDn+Cu23yUXxyj IfFYsipkb8w4tU+1gBKxDeh2+c3UY71vkLM/0kO2Xu6oWc2ylTw4Bo5vNTaglyi5jtE5 Pb6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=IVXFcMOH/nL95f6Hr87JfBhlnVOV2MublhhmoFho6aA=; b=fqKjpSahCze0T/pIFtCRjmPMzXqQXKslwjrec0OxqpHKjMXBIDszbfVZLMVT65xJZx nCdWYwO1+7g7/Ofuhez/T8N+4tcNrsPKl9UIaZ0SLoEwlhO1Fts6IeYvw2nuaNUW1zMj 6MybwpMWJEKc8wtr7Cw/IYJfOIDBx7bOeoj/WkyfxXTsMfLum9R7DWdGn8PWAGX1QXRS dxL6ghxhnPV7ZwOZtUEmBsZViRZNEdlM4IFpZw50iPP8UlM/Af/ckIxbnlkOVGJUGB7z m+l/sBDFVeWZzLDxXvrynE+ao8wfb5uLB6OIhlf59DbBanuIlXwoJBe4XF8FJf5mCp+S eYJw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i5si359264ejr.71.2020.05.05.14.26.22; Tue, 05 May 2020 14:26:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729273AbgEEVYm (ORCPT + 99 others); Tue, 5 May 2020 17:24:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1728660AbgEEVYl (ORCPT ); Tue, 5 May 2020 17:24:41 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFC4CC061A0F; Tue, 5 May 2020 14:24:40 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 682151281606D; Tue, 5 May 2020 14:24:40 -0700 (PDT) Date: Tue, 05 May 2020 14:24:39 -0700 (PDT) Message-Id: <20200505.142439.1075452616982863931.davem@davemloft.net> To: bhsharma@redhat.com Cc: netdev@vger.kernel.org, bhupesh.linux@gmail.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, aelior@marvell.com, GR-everest-linux-l2@marvell.com, manishc@marvell.com Subject: Re: [PATCH 1/2] net: qed*: Reduce RX and TX default ring count when running inside kdump kernel From: David Miller In-Reply-To: <1588705481-18385-2-git-send-email-bhsharma@redhat.com> References: <1588705481-18385-1-git-send-email-bhsharma@redhat.com> <1588705481-18385-2-git-send-email-bhsharma@redhat.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 05 May 2020 14:24:40 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bhupesh Sharma Date: Wed, 6 May 2020 00:34:40 +0530 > -#define NUM_RX_BDS_DEF ((u16)BIT(10) - 1) > +#define NUM_RX_BDS_DEF ((is_kdump_kernel()) ? ((u16)BIT(6) - 1) : ((u16)BIT(10) - 1)) These parenthesis are very excessive and unnecessary. At the very least remove the parenthesis around is_kdump_kernel().