Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp1166896ybj; Tue, 5 May 2020 14:32:04 -0700 (PDT) X-Google-Smtp-Source: APiQypIchSlwKNJh9euRDTFRVlPOnBZbkiBcAFx8wp/g13WrhuUG76xNuEdhBRjdmCjPniaWomB4 X-Received: by 2002:a17:907:2107:: with SMTP id qn7mr4787054ejb.316.1588714324301; Tue, 05 May 2020 14:32:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588714324; cv=none; d=google.com; s=arc-20160816; b=Y62dj4hfGEprFxJdQXlsQL2ksNoh48/TQqOhylnULNSVGg0dPHdH+hulfUO97qRLoZ UHjEK12YYcm/34LuXidi948c6uT46z95+N2wVNqrCBOc+uZrwxMLt7G4p4hOESRFPu2b 29eP7YRB/rqht0/Rgxu1SaQko5NIktrm2nD+j2Xt8nZ8tSaezjR3iXR2+ZHn+Q2lnu/K aC7AdsLZUCEMc7jYRxFEUc4paFeRfnUVTFI2yLyvkd6IKcJQjP/Ic2WwVMugI6pdTKI9 aN3VrmgRYbWnEb4zeUh/qV6yaro57h5UdOrj14K0Ny0Jv4L6kaG0pZAVqqauNX/ruxrq mRcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=AYOhvViGtfOYUpiUVO6St0IFegyeJIOeiAmdAI4TNGQ=; b=rNh3mcl32zXD0fc7diNyoqHFy7/0FY+HCezaEINaWxQ/BAUZdGt8uYIQ/saOeqTd9t 6Ubxlw5t9v0PaZrON08e6kw97mOqOSneXBveX668fnT7kxY/oMnPu4AhOwncnALXjsHu 5LkfWsf1iz6IfetQU6fakrY3Mb/fbTFCyrIhJX2gRnreGJe6RBW2Obtt0sfqhN5dxAqB cxf5Aq1g2H+OH9vaZim7it7b8WabquEXDpcX09BjfFsHUb6XstBt/ZLQoFCewxu/CvPg FV/UwR8jJsfgVJJ5o9A/SuZbqquMzKdAQzu0Pa660PT6RnBrNkQsEU1fw9GfegbTRola 6kkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=aZRjcMSG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f24si2042833eja.417.2020.05.05.14.31.41; Tue, 05 May 2020 14:32:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=aZRjcMSG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729218AbgEEVaK (ORCPT + 99 others); Tue, 5 May 2020 17:30:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1728853AbgEEVaJ (ORCPT ); Tue, 5 May 2020 17:30:09 -0400 Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C8D8C061A0F for ; Tue, 5 May 2020 14:30:09 -0700 (PDT) Received: by mail-pl1-x641.google.com with SMTP id u22so1356531plq.12 for ; Tue, 05 May 2020 14:30:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=AYOhvViGtfOYUpiUVO6St0IFegyeJIOeiAmdAI4TNGQ=; b=aZRjcMSGm6tpJdp5dwhoA4BnTL577pukRa7mQxkssp3Sui1VOiL8Cg5ituwtaTjV63 puUEc6X0vUmy9Ut2Ru4iG7PiSQeUG9f5uPgZ7vStJgQ5nKW+uovurKtQKfkKF/xcGUEi lexkvpQCX0AhebneUv6ca46cPDFaGMd+VR3ZQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=AYOhvViGtfOYUpiUVO6St0IFegyeJIOeiAmdAI4TNGQ=; b=U0bzVxtbhqevLZ36eM3ByG43QfqvGMLqUw6PCSWH4llKyzc+DXZybW35Z6i882Be9D A39dwua1aySYa7bHH7kLBTmASp1w3ChiuPSIvtf8rOnC4J6r/xPF3j6U8eku0X2X0gHx gyv4468eEKEQI0cQEYlQMZb9laM8BWkJ74ftvghzhqN6jbyMjgVT2KzWDbvTy5ls8a+u HGexJOLqYHAmDy+13bSco9Sew7MvQ279uqBO3ZYEocyNReHp96ahAZoMtCdLuKbO3a2z 2m6dpKwMr5+lro1hRymR1boY9PRuASv7P1ZE/i1AuxVdByedcJAPu/uyIhJd4ggSEt6T 4kGw== X-Gm-Message-State: AGi0PuZKFkKaje2Ak1Gu+qYmTVpXdwQF04Ovd5wgyMyw7rMpUnwRpgDb eHz1GVevgE002rjg4hOwljiXKg== X-Received: by 2002:a17:902:a98c:: with SMTP id bh12mr4905381plb.176.1588714209118; Tue, 05 May 2020 14:30:09 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id o1sm2883000pjs.35.2020.05.05.14.30.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2020 14:30:08 -0700 (PDT) Date: Tue, 5 May 2020 14:30:07 -0700 From: Kees Cook To: "Eric W. Biederman" Cc: linux-kernel@vger.kernel.org, Linus Torvalds , Oleg Nesterov , Jann Horn , Greg Ungerer , Rob Landley , Bernd Edlinger , linux-fsdevel@vger.kernel.org, Al Viro , Alexey Dobriyan , Andrew Morton Subject: Re: [PATCH 7/7] exec: Rename flush_old_exec begin_new_exec Message-ID: <202005051430.6ED1CC450@keescook> References: <87h7wujhmz.fsf@x220.int.ebiederm.org> <87a72mi2rq.fsf@x220.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87a72mi2rq.fsf@x220.int.ebiederm.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 05, 2020 at 02:46:01PM -0500, Eric W. Biederman wrote: > > There is and has been for a very long time been a lot more going on in > flush_old_exec than just flushing the old state. After the movement > of code from setup_new_exec there is a whole lot more going on than > just flushing the old executables state. > > Rename flush_old_exec to begin_new_exec to more accurately reflect > what this function does. > > Signed-off-by: "Eric W. Biederman" Reviewed-by: Kees Cook -- Kees Cook