Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: hQnNVMOt3y5qUQJDaMWSDmq3lYfl8c28nwsWcW0pE/E3MeGMZXt4SNusjwJujjZES21mFkRh6e
 sgzHxFdJWjfA==
IronPort-SDR: JB32Q4wMnIBLi+4AWjdE2T4xpp1OBGveR9G2gmu/9Jzyw2aMgONqrARLWMEK+zeDxueXXsDABT
 hOqI5pi39D3w==
From:   "Wong, Vee Khee" <vee.khee.wong@intel.com>
To:     David Miller <davem@davemloft.net>,
        "joabreu@synopsys.com" <joabreu@synopsys.com>
CC:     "peppe.cavallaro@st.com" <peppe.cavallaro@st.com>,
        "alexandre.torgue@st.com" <alexandre.torgue@st.com>,
        "mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-stm32@st-md-mailman.stormreply.com" 
        <linux-stm32@st-md-mailman.stormreply.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Ong, Boon Leong" <boon.leong.ong@intel.com>,
        "Voon, Weifeng" <weifeng.voon@intel.com>
Subject: RE: [PATCH net-next 1/1] net: stmmac: Add option for VLAN filter fail
 queue enable
Thread-Topic: [PATCH net-next 1/1] net: stmmac: Add option for VLAN filter
 fail queue enable
Thread-Index: AQHWGTyVW2FLQsiP2Eedqaoj0MNIyqiHUYmAgBMntQA=
Date:   Wed, 6 May 2020 03:31:00 +0000
Message-ID: <BYAPR11MB28704CA53250D824BA7422B0ABA40@BYAPR11MB2870.namprd11.prod.outlook.com>
References: <20200423070026.26200-1-vee.khee.wong@intel.com>
 <20200423.155329.1710757370582804428.davem@davemloft.net>
In-Reply-To: <20200423.155329.1710757370582804428.davem@davemloft.net>
Accept-Language: en-GB, en-US
Content-Language: en-US
dlp-reaction: no-action
dlp-version: 11.2.0.6
dlp-product: dlpe-windows
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 13b83a13-dc30-4043-897d-08d7f16de5fa
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2020 03:31:00.7246
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +/RGKORFg3m1DOhaDC4C3bhSKb3GNHNR6O1uf/+V7Eq5E2I4qfeGvPUF8h+yFfYmhy4corXXxJgFtYflW9ClKQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3302
X-OriginatorOrg: intel.com
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: netdev-owner@vger.kernel.org <netdev-owner@vger.kernel.org> On
> Behalf Of David Miller
> Sent: Friday, April 24, 2020 6:53 AM
> To: Wong, Vee Khee <vee.khee.wong@intel.com>
> Cc: peppe.cavallaro@st.com; alexandre.torgue@st.com;
> joabreu@synopsys.com; mcoquelin.stm32@gmail.com;
> netdev@vger.kernel.org; linux-stm32@st-md-mailman.stormreply.com;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Ong,
> Boon Leong <boon.leong.ong@intel.com>; Voon, Weifeng
> <weifeng.voon@intel.com>
> Subject: Re: [PATCH net-next 1/1] net: stmmac: Add option for VLAN filter=
 fail
> queue enable
>=20
> From: Wong Vee Khee <vee.khee.wong@intel.com>
> Date: Thu, 23 Apr 2020 15:00:26 +0800
>=20
> > From: "Chuah, Kim Tatt" <kim.tatt.chuah@intel.com>
> >
> > Add option in plat_stmmacenet_data struct to enable VLAN Filter Fail
> > Queuing. This option allows packets that fail VLAN filter to be routed
> > to a specific Rx queue when Receive All is also set.
> >
> > When this option is enabled:
> > - Enable VFFQ only when entering promiscuous mode, because Receive All
> >   will pass up all rx packets that failed address filtering (similar to
> >   promiscuous mode).
> > - VLAN-promiscuous mode is never entered to allow rx packet to fail VLA=
N
> >   filters and get routed to selected VFFQ Rx queue.
> >
> > Reviewed-by: Voon Weifeng <weifeng.voon@intel.com>
> > Reviewed-by: Ong Boon Leong <boon.leong.ong@intel.com>
> > Signed-off-by: Chuah, Kim Tatt <kim.tatt.chuah@intel.com>
> > Signed-off-by: Ong Boon Leong <boon.leong.ong@intel.com>
>=20
> Why would you be setting this with a platform attribute?  Even if the
> capability exists, wouldn't you want the user to be able to choose to opt=
 out?

Hi Jose/David Miller,

1/ In current implementation, TSN uses VLAN filter that can either accept/r=
eject VLAN-tagged network packets. In some situation, we do not want to dro=
p failed packets, but instead steer the packet to a VLAN Failed Queue Chann=
el.

2/ VLAN Fail Queue Channel will be set to use the RxQ with higheset index a=
s per HW IP configuration because that is the least priority channel.

3/ The way user will enable this feature is through promiscuous mode settin=
gs using ifconfig. (e.g. ifconfig enp0s30f4 promisc)

4/ VLAN Filter Fail Packets Queue feature is IP version specific (only appl=
icable to DWMAC5). I would propose we add this under platform data (e.g. dw=
mac-intel), so that it can be built in according to hardware on a separate =
patch.

Any thoughts?