Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Manish Rangankar <mrangankar@marvell.com>
To:     Jason Yan <yanaijie@huawei.com>,
        "QLogic-Storage-Upstream@cavium.com" 
        <QLogic-Storage-Upstream@cavium.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] [PATCH] scsi: qedi: remove Comparison of 0/1 to bool
 variable
Thread-Topic: [EXT] [PATCH] scsi: qedi: remove Comparison of 0/1 to bool
 variable
Thread-Index: AQHWHuli2Q3Dl6FLG06MBAsIf0Kgdqiag5sw
Date:   Wed, 6 May 2020 04:43:25 +0000
Message-ID: <BYAPR18MB299824A60D731DD4BFB8F840D8A40@BYAPR18MB2998.namprd18.prod.outlook.com>
References: <20200430121706.14879-1-yanaijie@huawei.com>
In-Reply-To: <20200430121706.14879-1-yanaijie@huawei.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 1fc87cbe-9472-432c-8837-08d7f17803c4
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2020 04:43:25.6726
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Wui1Yp9ABWl+8Gos4B/1GoeJr828RRWXfcbU+E0w1avhXVnEoTb8b6qF+HRxXMlvCA9TDtpheFUzPDJCo/C1VA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2838
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.676
 definitions=2020-05-06_01:2020-05-04,2020-05-06 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Jason Yan <yanaijie@huawei.com>
> Sent: Thursday, April 30, 2020 5:47 PM
> To: QLogic-Storage-Upstream@cavium.com; jejb@linux.ibm.com;
> martin.petersen@oracle.com; Manish Rangankar
> <mrangankar@marvell.com>; linux-scsi@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: Jason Yan <yanaijie@huawei.com>
> Subject: [EXT] [PATCH] scsi: qedi: remove Comparison of 0/1 to bool
> variable
>=20
> External Email
>=20
> ----------------------------------------------------------------------
> Fix the following coccicheck warning:
>=20
> drivers/scsi/qedi/qedi_main.c:1309:5-25: WARNING: Comparison of 0/1 to
> bool variable
> drivers/scsi/qedi/qedi_main.c:1315:5-25: WARNING: Comparison of 0/1 to
> bool variable
>=20
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
>  drivers/scsi/qedi/qedi_main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.=
c
> index 4dd965860c98..46584e16d635 100644
> --- a/drivers/scsi/qedi/qedi_main.c
> +++ b/drivers/scsi/qedi/qedi_main.c
> @@ -1306,13 +1306,13 @@ static irqreturn_t qedi_msix_handler(int irq,
> void *dev_id)
>  			  "process already running\n");
>  	}
>=20
> -	if (qedi_fp_has_work(fp) =3D=3D 0)
> +	if (!qedi_fp_has_work(fp))
>  		qed_sb_update_sb_idx(fp->sb_info);
>=20
>  	/* Check for more work */
>  	rmb();
>=20
> -	if (qedi_fp_has_work(fp) =3D=3D 0)
> +	if (!qedi_fp_has_work(fp))
>  		qed_sb_ack(fp->sb_info, IGU_INT_ENABLE, 1);
>  	else
>  		goto process_again;
> --

Thanks,
Acked-by: Manish Rangankar <mrangankar@marvell.com>