Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200505182821.47708-1-elver@google.com>
In-Reply-To: <20200505182821.47708-1-elver@google.com>
From:   David Gow <davidgow@google.com>
Date:   Wed, 6 May 2020 12:45:03 +0800
Message-ID: <CABVgOSmg8z1TpMh7NPy0M+9Gs2JT097-j_XGBRGhKk_3y2J-oA@mail.gmail.com>
Subject: Re: [PATCH v2] kcsan: Add test suite
To:     Marco Elver <elver@google.com>
Cc:     "Paul E. McKenney" <paulmck@kernel.org>,
        Dmitry Vyukov <dvyukov@google.com>,
        Alexander Potapenko <glider@google.com>,
        Andrey Konovalov <andreyknvl@google.com>,
        kasan-dev <kasan-dev@googlegroups.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        KUnit Development <kunit-dev@googlegroups.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, May 6, 2020 at 2:30 AM Marco Elver <elver@google.com> wrote:
>
> This adds KCSAN test focusing on behaviour of the integrated runtime.
> Tests various race scenarios, and verifies the reports generated to
> console. Makes use of KUnit for test organization, and the Torture
> framework for test thread control.
>
> Signed-off-by: Marco Elver <elver@google.com>

Thanks, this works much better on my setup: having an explicit error
for there not being enough CPUs is a lot better than hanging. It'd
still be nice to have these be "skipped" rather than "failed" at some
stage, but that's a nice-to-have for the future once we've implemented
such a thing in KUnit.

I'm still a little hesitant about non-deterministic tests in general =E2=80=
=94
even if they're only run when CONFIG_KCSAN is enabled, it's possible
that a future CI system could run under KCSAN and report false
breakages on unrelated patches. Given no such setup exists yet,
though, I think it's probably a problem for the future rather than a
blocker at the moment.

Regardless, I hit no unexpected issues in my testing, so,

Tested-by: David Gow <davidgow@google.com>

-- David