Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200505162607.334-1-nsaenzjulienne@suse.de> <20200505162607.334-2-nsaenzjulienne@suse.de>
In-Reply-To: <20200505162607.334-2-nsaenzjulienne@suse.de>
From:   Bin Meng <bmeng.cn@gmail.com>
Date:   Wed, 6 May 2020 13:33:26 +0800
Message-ID: <CAEUhbmWOQNDeStd3oDFTveiugzDG0zf0X1ybSWeCSP4QStNcPA@mail.gmail.com>
Subject: Re: [PATCH v3 1/2] arm: rpi: Add function to trigger VL805's firmware load
To:     Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc:     mbrugger@suse.com, U-Boot Mailing List <u-boot@lists.denx.de>,
        Marek Vasut <marex@denx.de>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Simon Glass <sjg@chromium.org>, m.szyprowski@samsung.com,
        Sylwester Nawrocki <s.nawrocki@samsung.com>,
        mark.kettenis@xs4all.nl
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Nicolas,

On Wed, May 6, 2020 at 12:26 AM Nicolas Saenz Julienne
<nsaenzjulienne@suse.de> wrote:
>
> On the Raspberry Pi 4, after a PCI reset, VL805's (a xHCI chip) firmware
> may either be loaded directly from an EEPROM or, if not present, by the
> SoC's VideCore (the SoC's co-processor). Introduce the function that
> informs VideCore that VL805 may need its firmware loaded.
>

I still did not get it. Without the firmware being loaded, does xHCI
on RPi 4 still work? What exact functionality does the firmware
provide?

> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
>
> ---
> Changes since v2:
>  - Correct wrong function name in comment
>  - Add better comment on rpi_firmware_init_vl805()
>
> Changes since v1:
>  - Rename function so it's not mistaken with regular firmware loading
>
>  arch/arm/mach-bcm283x/include/mach/mbox.h | 13 +++++++
>  arch/arm/mach-bcm283x/include/mach/msg.h  |  7 ++++
>  arch/arm/mach-bcm283x/msg.c               | 45 +++++++++++++++++++++++
>  3 files changed, 65 insertions(+)
>

Regards,
Bin