Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp1504664ybj; Tue, 5 May 2020 23:06:16 -0700 (PDT) X-Google-Smtp-Source: APiQypLn5lwJJUAWCfMooPrwGbtj0UwSrLo51VRHRCB8063HFQU8TuGIQmkuZEs1upcQ8BLhKTtu X-Received: by 2002:aa7:c1ca:: with SMTP id d10mr5685657edp.152.1588745176776; Tue, 05 May 2020 23:06:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588745176; cv=none; d=google.com; s=arc-20160816; b=VCqskqChXstmmYk0O/br0JdBshxOG9zrMHAyhbiRyEb5RMdXAyxr8gId3ru1GIQMYL BgxJrfDnS7xZxpMe7fEhZ3gOHD7+JJYrVTj31P5i+C5GFkQcPuiAYVLxYqhJuaPdccLl 8Ma95x4N+W/wQq5cFMgeNS/D6ENdSIwLXlqWBsT1ocpN0OXD2VI+RN+u+2Y2ZwcIU51E htbWvwmnKSIyIbk3U5soqP5VrYP+xmQtwgBHFLGqrrthlLoq3LThfa6AtmSNHO6/r+zt 7nNhJxWp1YPvebBnjymtjixUzcqhtuxT3tnzM8kw8yo//yPTsvqJugntipZwHUp+il7g 31sQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=vrtd+9ieluN48r2UyxPC1PU2Bt6Hfhw6JP1741c+amY=; b=PyvOyuX//zSsZfO/4FXEZ2fPOdNkwkscbzybGVamitX+Dpr1pEAzH9jqNrjqm2u0pb iPK6xZi8TdyPxd6UNpcTYc+RZntHHBpb9t8h2UPu9vcZfpJhJr1asDeS+Q931u3KnRnG 3ZaxTuOzqAnQYv3cZevVB1uJJsNsF70JFjxZBaMm65ND9fxGHzHCFWBy7dpHG2RklW99 W7WuP4r7neHqNiqVtfBM53grfob0bWZlXiT2V19Tzx8Z15/CNs1ZO9JK1DYNl44AU5QM NTReGGJQeRhUcXyMguDVeymb6koUSrI1aR0kkOsEn3VQ1Tq7mvCusm7dLbQPbwMcNkLZ 9YeA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d16si598568ejb.187.2020.05.05.23.05.54; Tue, 05 May 2020 23:06:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726751AbgEFGEi (ORCPT + 99 others); Wed, 6 May 2020 02:04:38 -0400 Received: from verein.lst.de ([213.95.11.211]:39025 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725771AbgEFGEh (ORCPT ); Wed, 6 May 2020 02:04:37 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 91F7368C65; Wed, 6 May 2020 08:04:35 +0200 (CEST) Date: Wed, 6 May 2020 08:04:35 +0200 From: Christoph Hellwig To: Martijn Coenen Cc: axboe@kernel.dk, hch@lst.de, ming.lei@redhat.com, narayan@google.com, zezeozue@google.com, kernel-team@android.com, maco@google.com, bvanassche@acm.org, Chaitanya.Kulkarni@wdc.com, jaegeuk@kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 05/10] loop: Remove figure_loop_size() Message-ID: <20200506060435.GB10771@lst.de> References: <20200429140341.13294-1-maco@android.com> <20200429140341.13294-6-maco@android.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200429140341.13294-6-maco@android.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 29, 2020 at 04:03:36PM +0200, Martijn Coenen wrote: > This function was now only used by loop_set_capacity(). Just open code > the remaining code in the caller instead. > > Signed-off-by: Martijn Coenen Looks good, Reviewed-by: Christoph Hellwig