Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp1510493ybj;
        Tue, 5 May 2020 23:15:05 -0700 (PDT)
X-Google-Smtp-Source: APiQypIwlHRIjtDZswTIrTj93VzUkVkwD5/liCMZtVZ3GbM0LWqvzchuwI+hGRsvTgNQ//4QXvcN
X-Received: by 2002:a50:b285:: with SMTP id p5mr5713129edd.150.1588745705059;
        Tue, 05 May 2020 23:15:05 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1588745705; cv=none;
        d=google.com; s=arc-20160816;
        b=0vVaxNp5Zs8njvOo7RyBSrGBg05pxcT7I8TTAMoByMICxY0k1zLPm3ycFGt91a83d0
         FZZ+2+YwvN0TkTW4PQ8lddBK6qz+eN2JSGYPmlr0HZz1cntsupEeRtpTSMt6lAGLyUfC
         C3BKquh1sf5ONqJ352akHZ2CJ/CSblbhiSP0qwve8sHi7ixeQi5vnZyP4+9zWNrSMhyF
         CgfwhBMqIfkXEUOvmmJvk7mQbUkyJZRo0WIM+jQlLnfee4IQLYAz3qV7dW7+iYhWICfn
         JNK5JqiphKAFbtJzeXTp1++8e6/i7Zkg1usSmK2UrF+JMuMHhpGRCQmRlKyuHDJT8wcL
         wAXQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date;
        bh=DH10JwVvOLyO/vJisovqsnXZqPvwLRF/+oSufm5iUow=;
        b=Lpa7nQjv1jUbIc0Ly94eDG20e1s7VotV+GQP4ZnPB8u3RQF3VbPeDlCYfmAKLg5wl6
         9rc7yV2gg7/LmZwJ1kbjN6qkbfDEW3YBN98GPtLAxLgkVfKACX9CtXM4vvobCTDY2RX8
         g7JUiaIvFdOaeyQQc8DnQ3lHMINlXhPovBEapCxHJMHfVxMPKkkJuM8mYMQ0HbHUDhgh
         B9CuXaKwtYU195jvMBUS23Npkl+MQu9BYMjdLyN3USo9XVo4xT6z3/LzFh0Meg2gvFEe
         4jdpQzNjYHGMcSBiRX5zNonmNeHt/+ZAjvX5T6cfoDfhnOPmsCOr3doW2BfyV39CmJ87
         f24w==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id z9si454849edi.65.2020.05.05.23.14.41;
        Tue, 05 May 2020 23:15:05 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727101AbgEFGJq (ORCPT <rfc822;radocaj.bane@gmail.com>
        + 99 others); Wed, 6 May 2020 02:09:46 -0400
Received: from verein.lst.de ([213.95.11.211]:39079 "EHLO verein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726438AbgEFGJq (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 6 May 2020 02:09:46 -0400
Received: by verein.lst.de (Postfix, from userid 2407)
        id 4601168C4E; Wed,  6 May 2020 08:09:44 +0200 (CEST)
Date:   Wed, 6 May 2020 08:09:44 +0200
From:   Christoph Hellwig <hch@lst.de>
To:     Martijn Coenen <maco@android.com>
Cc:     axboe@kernel.dk, hch@lst.de, ming.lei@redhat.com,
        narayan@google.com, zezeozue@google.com, kernel-team@android.com,
        maco@google.com, bvanassche@acm.org, Chaitanya.Kulkarni@wdc.com,
        jaegeuk@kernel.org, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, Linux API <linux-api@vger.kernel.org>
Subject: Re: [PATCH v4 10/10] loop: Add LOOP_CONFIGURE ioctl
Message-ID: <20200506060944.GG10771@lst.de>
References: <20200429140341.13294-1-maco@android.com> <20200429140341.13294-11-maco@android.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200429140341.13294-11-maco@android.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thanks, this looks very nice!

Reviewed-by: Christoph Hellwig <hch@lst.de>

Are you also going to submit a patch to util-linux to use the new
ioctl?