Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp1610022ybj; Wed, 6 May 2020 01:45:07 -0700 (PDT) X-Google-Smtp-Source: APiQypIv4432ZU+t1QBDylWcsL/cI3p7/dQhv8YYG7WW4uGBUgmINALNT9dkzKmFetyR0m8DekhW X-Received: by 2002:a05:6402:1611:: with SMTP id f17mr5480962edv.352.1588754706882; Wed, 06 May 2020 01:45:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588754706; cv=none; d=google.com; s=arc-20160816; b=Vaf2i+JfpIqhCJaDBamBnRp5h1pB9tHCzB5Rtb2fHMBPu272J6DyExmbmbVQqwURYQ mB7UTFtP6KE7Cu0VXkHOgBjfKC6fOlHAjmwvU8EN0h22Xi8CX2Lc9SzIhD3DJAZn1pk4 oF7s0x7Xe2PsX56UHG2qW0erpiceulKSybtddRBRw3iPXxT20bSK8u8pPrHUj2nuRhRz qpXlMhhd9mXhGFAuE3msnxhG2ngeST3JrnnbnS2YXEbS7E2dnRdc7bPII/psXntmNggK 6Vcy7NEr+kfhY4WXPQur4n7njPuGpwjCURCusJrmYrSjZCymtcQnZb3bsnysBRiygVTN lfDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=ZpuaMWJsdqW0NHWigI4OMdvnaFuZm6FiI5YPhkXCmY8=; b=C65k9Amx5NlQOjs+kMjsyC/GSrM0jRv0R7F8wTdBeBfuDYF50UZ8pnzsdx58K6rRiA IR1dHYRmF2mKygCn9wW7/fuuv18eqMHqMFy7PM/II5DykvBe/7hUUUPnzAcGI/opVmqk Zybbkp0fMKnBtG/mdKSD9DcM2m/F2qLEABgTV69o+53WDvRxo3Kz2V4OI3r+bgLr72sr iDR2K1j/JJ/yzXEBp4tKVybimzX8Ic85yKa//zv3nWZ1RZSGkPu2j5aqUWk8V+McVgjv t8EGc9IRLTIzOqPAk5UzSXMgi8zfH6i2xP53PAXm3hVzuoiYjmDMJSGDqszBCd3XVfMy tYNg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u2si741977ejr.370.2020.05.06.01.44.44; Wed, 06 May 2020 01:45:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728736AbgEFInM (ORCPT + 99 others); Wed, 6 May 2020 04:43:12 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:50458 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727956AbgEFInM (ORCPT ); Wed, 6 May 2020 04:43:12 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id A378A75A4B1ED3E052B9; Wed, 6 May 2020 16:43:06 +0800 (CST) Received: from [127.0.0.1] (10.166.213.7) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.487.0; Wed, 6 May 2020 16:43:01 +0800 Subject: Re: [PATCH] ARM: OMAP2+: remove unneeded variable "errata" in configure_dma_errata() To: Russell King - ARM Linux admin CC: , , , , References: <20200506061900.19832-1-yanaijie@huawei.com> <20200506082941.GA1559@shell.armlinux.org.uk> From: Jason Yan Message-ID: Date: Wed, 6 May 2020 16:43:00 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <20200506082941.GA1559@shell.armlinux.org.uk> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.166.213.7] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ?? 2020/5/6 16:29, Russell King - ARM Linux admin ะด??: > On Wed, May 06, 2020 at 02:19:00PM +0800, Jason Yan wrote: >> Fix the following coccicheck warning: >> >> arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return >> "0" on line 161 > > NAK. Look closer at what the code is doing, thanks. > > This warning is basically incorrect. > OK, the macro SET_DMA_ERRATA is using this variable.