Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peter Chen <peter.chen@nxp.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
CC:     "balbi@kernel.org" <balbi@kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "jun.li@freescale.com" <jun.li@freescale.com>,
        "rogerq@ti.com" <rogerq@ti.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] usb: gadget: audio: Fix a missing error return value in
 audio_bind()
Thread-Topic: [PATCH] usb: gadget: audio: Fix a missing error return value in
 audio_bind()
Thread-Index: AQHWITg+2d4HmGUDzkWJmNFd0Xw0X6iayB0A
Date:   Wed, 6 May 2020 09:03:33 +0000
Message-ID: <20200506090358.GD30237@b29397-desktop>
References: <20200503104707.148996-1-christophe.jaillet@wanadoo.fr>
In-Reply-To: <20200503104707.148996-1-christophe.jaillet@wanadoo.fr>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <C3C6C58B08C009448250D33884C2E52C@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 9b678fb9-03ef-4306-f82d-08d7f19c5a7a
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2020 09:03:33.0509
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: s9UErcjrPZCrEQ5fOHy2Eb0zDxcWC+87SvbAfT3A4sEx5tCBIqh4X9DM2yngHNf5xR3DzOzQ3IJRoCOVCQyiaQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6885
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20-05-03 12:47:07, Christophe JAILLET wrote:
> If 'usb_otg_descriptor_alloc()' fails, we must return an error code, not =
0.
>=20
> Fixes: 56023ce0fd70 ("usb: gadget: audio: allocate and init otg descripto=
r by otg capabilities")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/usb/gadget/legacy/audio.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/usb/gadget/legacy/audio.c b/drivers/usb/gadget/legac=
y/audio.c
> index dd81fd538cb8..a748ed0842e8 100644
> --- a/drivers/usb/gadget/legacy/audio.c
> +++ b/drivers/usb/gadget/legacy/audio.c
> @@ -300,8 +300,10 @@ static int audio_bind(struct usb_composite_dev *cdev=
)
>  		struct usb_descriptor_header *usb_desc;
> =20
>  		usb_desc =3D usb_otg_descriptor_alloc(cdev->gadget);
> -		if (!usb_desc)
> +		if (!usb_desc) {
> +			status =3D -ENOMEM;
>  			goto fail;
> +		}
>  		usb_otg_descriptor_init(cdev->gadget, usb_desc);
>  		otg_desc[0] =3D usb_desc;
>  		otg_desc[1] =3D NULL;
> --=20
> 2.25.1
>=20

Reviewed-by: Peter Chen <peter.chen@nxp.com>

--=20

Thanks,
Peter Chen=