Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp1663601ybj; Wed, 6 May 2020 02:58:43 -0700 (PDT) X-Google-Smtp-Source: APiQypIPaDe2DKAXMfcQ5HbZQVXZXo0TOKBEKu29hK0MA1zw9TKo9yM+f3FRFvqDO1Jjm2G5V3KE X-Received: by 2002:a05:6402:1d37:: with SMTP id dh23mr5981805edb.287.1588759123782; Wed, 06 May 2020 02:58:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588759123; cv=none; d=google.com; s=arc-20160816; b=nm18mpED2kBDi7XL/aVHziDGPAWvVmkx4rx6iVogyt3SIq+QP/ot0B2YH0jT5zrZ55 yNNdVzb4rqpi9r17tLmsZ7Gsd8z5/gPfDV58KKhU3BrKXUBqrkhW1R5AVVWqMTAFlRov cThovp1kFrCOCw5Zoc3yAmQBheAAYXd154/GjIjuR5PGPUOMpHdOPsO9y24fw+gp86JM NNgk1qMrS2Jv4Vf095f2WsdPmhFor57D33OAbO/lsOADL6q0pIOlwWXpC//6boUV1wWA 8k32Gz8y1LbCvlXmMio4488Gb9knCLAaYW6QbLxUmlu/OavmeGyPYW2v8p92m8bqHQL+ TBQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=m1a2PkwV2T8+2DItaMD9IItjhWohAns0GTTh7+ScaUs=; b=QTWqSbH85tJC6mzRC/unVry9pPXkJUFJz4DEc7J4wjv5UoLzfG5v1UoCKx+TDVCFoH OtH++DNzHpXjy5YD5hAgbEjw2C+65+C+mt33KG8zF7VvQjRok/53wdSUXKiFpFELxwoZ wR3K+pj2L0NgGie3OxMkHliLERoeCNABVJ4l+f/vXkoIVXMAfNCygtFwMTPwNMoOXnPw /MtcbVBANvpIdh1oDA5uRs6/NGL8eGWBB5VaRYsAEieC/PoJbl5fM+sZ3ZhsYDwh7+O1 b8qERUFdlyTEurZLKiWJDJzUpbfolCn5T0z3U/zMQV+YGXu9qwhmzyNWeH8gpD66twlC Bu9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@android.com header.s=20161025 header.b=LEfzudg1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=android.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b95si793563edf.85.2020.05.06.02.58.20; Wed, 06 May 2020 02:58:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@android.com header.s=20161025 header.b=LEfzudg1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=android.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729194AbgEFJzs (ORCPT + 99 others); Wed, 6 May 2020 05:55:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1729084AbgEFJzs (ORCPT ); Wed, 6 May 2020 05:55:48 -0400 Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com [IPv6:2a00:1450:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2C0FC061A10 for ; Wed, 6 May 2020 02:55:47 -0700 (PDT) Received: by mail-lf1-x143.google.com with SMTP id a9so802636lfb.8 for ; Wed, 06 May 2020 02:55:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=android.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=m1a2PkwV2T8+2DItaMD9IItjhWohAns0GTTh7+ScaUs=; b=LEfzudg1N43QZjTlPIxvvlD34Fb6yTWkxh+eLzWYTWcd/9UIKEfv5stX7ryBfvg9g6 4FEWoUoC0LtPshkhjHT4vcyfMfYAn7ZPnLGdV5/iXBcWvyh64jodk2owgmeghnA//F6e ZtjpQwu9epWZIkLsWcpWCdbHh5nw0dZvRcxTyoYXHqY1aiPCLmegMHCyERwAWp8D5r4x q/dUEV4ApkG8PhkWIGCcm4QybyLXmsMtZCsXevtDVeVEdX96M2IQT15/txUTjfBPfHLH JlWG+5IWq6iYWsB5a2TRaUPEHo4iV6r8MtxUDWgVqL4/4pHEP//ovBgnH47kQDKJep1D OMVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m1a2PkwV2T8+2DItaMD9IItjhWohAns0GTTh7+ScaUs=; b=K3+2MUVWmER3fsZwkKllscxWxsKyf6AmNY3lyfbE6BbiP8o95cNv0ooEwF75hsgCbJ xaxqDSMiy80/RMs8qgyMFM9QU7gz730RhlGG6TSTApXxpiunfo5JSnEZUXAaznrw0Kuo e+6WJHCQF/RrxVzC2pQGFW82tnVlN7KaYRQ25MzGJaRVoLM4PWspWysTUFg5H74esHuB 2N6pBUSRAZkgvCA49fT/CC9Yiwdhuqh2KPz7fGwMqa0H12p9ewr9UCDc67NFLIIKkkfe 5SubetMcgaicO1YJRj9p7v31LCsGBEhqiaboeloCje0BdPC5x0EeChVJTcKMjJS5hMdT 3iEA== X-Gm-Message-State: AGi0PuYBwpb4gkOy+TjhCgNOupVLcGeaHs+huKtLxnFGWtRkxSIgtkXF pudoAtmxw+yzGhRzy71ozIOKuXBpZD12DRJHntWFaO6LeRI= X-Received: by 2002:ac2:4546:: with SMTP id j6mr4684635lfm.203.1588758945507; Wed, 06 May 2020 02:55:45 -0700 (PDT) MIME-Version: 1.0 References: <20200429140341.13294-1-maco@android.com> <20200429140341.13294-11-maco@android.com> <20200506060944.GG10771@lst.de> In-Reply-To: <20200506060944.GG10771@lst.de> From: Martijn Coenen Date: Wed, 6 May 2020 11:55:34 +0200 Message-ID: Subject: Re: [PATCH v4 10/10] loop: Add LOOP_CONFIGURE ioctl To: Christoph Hellwig Cc: Jens Axboe , Ming Lei , Narayan Kamath , Zimuzo Ezeozue , kernel-team@android.com, Martijn Coenen , Bart Van Assche , Chaitanya Kulkarni , Jaegeuk Kim , linux-block , LKML , Linux API Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 6, 2020 at 8:09 AM Christoph Hellwig wrote: > > Thanks, this looks very nice! Thanks! And thanks for all the feedback, it has made this series a lot cleaner. > > Reviewed-by: Christoph Hellwig > > Are you also going to submit a patch to util-linux to use the new > ioctl? Yeah, I'm happy to - will do it as soon as the series lands. Best, Martijn