Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp1663760ybj; Wed, 6 May 2020 02:58:57 -0700 (PDT) X-Google-Smtp-Source: APiQypLzWVGcvsgE4527T9VkpNJhCAb4NWzIrmMneuEVtGbtNDVcJ946HCgkz9vc6azImLcAjV+d X-Received: by 2002:a05:6402:48b:: with SMTP id k11mr6244418edv.47.1588759137184; Wed, 06 May 2020 02:58:57 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w24si897786ejn.277.2020.05.06.02.58.33; Wed, 06 May 2020 02:58:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=isFjy5tF; dkim=fail header.i=@synopsys.com header.s=selector1 header.b=pnuHXWGg; arc=fail (signature failed); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729258AbgEFJ4X (ORCPT + 99 others); Wed, 6 May 2020 05:56:23 -0400 Received: from smtprelay-out1.synopsys.com ([149.117.73.133]:49568 "EHLO smtprelay-out1.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728663AbgEFJ4W (ORCPT ); Wed, 6 May 2020 05:56:22 -0400 Received: from mailhost.synopsys.com (badc-mailhost2.synopsys.com [10.192.0.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtprelay-out1.synopsys.com (Postfix) with ESMTPS id 08134439D6; Wed, 6 May 2020 09:56:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1588758981; bh=E47aFDuc7L8n2VBZxNocmI2DrDPzdNN/m1cy/aSpy4I=; h=From:To:CC:Subject:Date:References:In-Reply-To:From; b=isFjy5tFIyxswYzQtBPKj9m81e8kz5Blu9JEFXTr799CI6AdGu4XSZt18970YKuiY Xhk8nM/LXb8zp7q8spkKROPFQ9JWEo0ZJHtAE1vjrqCJ3pb/pu5rPWqqKw75WU7N3+ qeRvowOgkAOt/JLt6f0RCSnvxzLm7FRnOccnp09oKBRI11fGmrJNvsd/VgWtwzEa6u ti9A7NDEkLyUWvY8XXEhsy7RrE7twM+fdpJOCeE7tT4DSyTQOst0T1s4nty/s209c7 unr/yrwLDiVFAphD2kKBWwx5HzEipKLch02cdtpDY/D786QxGEM0BLkx05D0rYGB9a zrcxEX0/WB6ow== Received: from US01WEHTC3.internal.synopsys.com (us01wehtc3.internal.synopsys.com [10.15.84.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mailhost.synopsys.com (Postfix) with ESMTPS id 86C51A006E; Wed, 6 May 2020 09:56:19 +0000 (UTC) Received: from us01hybrid1.internal.synopsys.com (10.200.27.51) by US01WEHTC3.internal.synopsys.com (10.15.84.232) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 6 May 2020 02:56:19 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (10.202.3.67) by mrs.synopsys.com (10.200.27.51) with Microsoft SMTP Server (TLS) id 14.3.487.0; Wed, 6 May 2020 02:56:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i1ECMK3UO0okm27y5u9DvrUrwqG5MCesZWhlXkI/kRBtdcjsM6Kw6fAyCEr6coatyQvSBitjfYFtbIpqPIn2K45i3IwCG+hPnZ3pIZdoWT7Awx+gLk5BsBAGDLEQjJt5HfNJcJXfhQi3ZKSN8BrbF6JEsj+fXbCtaPcqu9+oJ/yXToR899lOZxY8rI9o77Zb60yksioN/+HfJjGkBWyA4rVVX1yod0igauskgEzSoTQNRqPsRA6R6G+qBtYBu1cjfH4uPmU/Ury36RjK/oZBEYKovMC40qY3jiKzxCNEgEIgIL5HEITcIWwOjNK0zblDhHdKjYEqSSD9fBKXfLmbEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AnhfA8bSdZo2l3G55by2sSnWjUHg3Yjv1D5R0jkm09Y=; b=e01L/J9npy60aMzdj0nshTEQsAXS5pl617+C8PGpGpUTJeLphuDRPW1SD9T1id0zPNcKBjZVwQh9AEkMFGhkfI5sLUp5Hgm2sKPawCGuotkGsUCciL4HrOMMMhUDElVkwk6FZHUrnphitTz17fBvjcRlaZmtC8ahFchT6IIMxTSUBF+3UcwmHcnWFu7FZKMdiLixGoxZTeVdV905Z3+hucZtrc6CJtYi/igSggnPFvYmFR9s5cXakXS6GYv94OYcywNKQg7iLtc7Itfn3Lmq3LGtahvpxWwiUeJfwlm0Ylv4Solx9wM842Mtf0T+tSnZTA2T+5dRiKAgPO9Nw94QnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=synopsys.com; dmarc=pass action=none header.from=synopsys.com; dkim=pass header.d=synopsys.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=synopsys.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AnhfA8bSdZo2l3G55by2sSnWjUHg3Yjv1D5R0jkm09Y=; b=pnuHXWGgHxixMCMX8Sduv5K633hYwvpYYAbkZLxtHuknvAo2iOqgDrENxo5O2+qHTwMvYqySeJrDcBceN+i82rEGbmk1C40KQi5o6Fy7siO9uJ9f5NI7ggpOwI7OtFwPdCNGCo6RlFgKxlWyLOVOPBBBsOWMk9ZaQCB/cs/Hbvo= Received: from CH2PR12MB3782.namprd12.prod.outlook.com (2603:10b6:610:23::28) by CH2PR12MB4102.namprd12.prod.outlook.com (2603:10b6:610:a9::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.27; Wed, 6 May 2020 09:56:17 +0000 Received: from CH2PR12MB3782.namprd12.prod.outlook.com ([fe80::c8ba:1b80:f234:e1c2]) by CH2PR12MB3782.namprd12.prod.outlook.com ([fe80::c8ba:1b80:f234:e1c2%2]) with mapi id 15.20.2979.028; Wed, 6 May 2020 09:56:17 +0000 From: Angelo Ribeiro To: Daniel Vetter CC: "dri-devel@lists.freedesktop.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Maarten Lankhorst" , Maxime Ripard , David Airlie , Sam Ravnborg , Gustavo Pimentel , Joao Pinto Subject: RE: [PATCH v3 3/4] drm: ipk: Add extensions for DW MIPI DSI Host driver Thread-Topic: [PATCH v3 3/4] drm: ipk: Add extensions for DW MIPI DSI Host driver Thread-Index: AQHWHJYPw9IJM5JmgkGGf0JPX2lmYKiOqhmAgAwS5VA= Date: Wed, 6 May 2020 09:56:16 +0000 Message-ID: References: <24372475c0afe1e88f323efec16300903d1c6294.1587992776.git.angelo.ribeiro@synopsys.com> <20200428152815.GX3456981@phenom.ffwll.local> In-Reply-To: <20200428152815.GX3456981@phenom.ffwll.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-ref: =?us-ascii?Q?PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcYW5nZWxvclxh?= =?us-ascii?Q?cHBkYXRhXHJvYW1pbmdcMDlkODQ5YjYtMzJkMy00YTQwLTg1ZWUtNmI4NGJh?= =?us-ascii?Q?MjllMzViXG1zZ3NcbXNnLWQxYTdkN2YxLThmN2YtMTFlYS05ZDczLWZjNzc3?= =?us-ascii?Q?NGVlZGMyZVxhbWUtdGVzdFxkMWE3ZDdmMi04ZjdmLTExZWEtOWQ3My1mYzc3?= =?us-ascii?Q?NzRlZWRjMmVib2R5LnR4dCIgc3o9IjIyNjIwIiB0PSIxMzIzMzIzMjU3NDc3?= =?us-ascii?Q?NjQ2MjMiIGg9ImU0bi9ZTGVwMFptZVpDaHBjOS9ZWGNHQVBOND0iIGlkPSIi?= =?us-ascii?Q?IGJsPSIwIiBibz0iMSIgY2k9ImNBQUFBRVJIVTFSU1JVRk5DZ1VBQUJRSkFB?= =?us-ascii?Q?Q1BMWCtVakNQV0FmODBKVy9jYUx0YS96UWxiOXhvdTFvT0FBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFIQUFBQUNrQ0FBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFFQUFRQUJBQUFBSGFXeU5BQUFBQUFBQUFBQUFBQUFBSjRBQUFCbUFHa0Fi?= =?us-ascii?Q?Z0JoQUc0QVl3QmxBRjhBY0FCc0FHRUFiZ0J1QUdrQWJnQm5BRjhBZHdCaEFI?= =?us-ascii?Q?UUFaUUJ5QUcwQVlRQnlBR3NBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUVBQUFBQUFBQUFBZ0FBQUFBQW5nQUFBR1lBYndCMUFHNEFaQUJ5QUhrQVh3?= =?us-ascii?Q?QndBR0VBY2dCMEFHNEFaUUJ5QUhNQVh3Qm5BR1lBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FB?= =?us-ascii?Q?QUFBQUNlQUFBQVpnQnZBSFVBYmdCa0FISUFlUUJmQUhBQVlRQnlBSFFBYmdC?= =?us-ascii?Q?bEFISUFjd0JmQUhNQVlRQnRBSE1BZFFCdUFHY0FYd0JqQUc4QWJnQm1BQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFCQUFBQUFBQUFBQUlBQUFBQUFKNEFBQUJtQUc4?= =?us-ascii?Q?QWRRQnVBR1FBY2dCNUFGOEFjQUJoQUhJQWRBQnVBR1VBY2dCekFGOEFjd0Jo?= =?us-ascii?Q?QUcwQWN3QjFBRzRBWndCZkFISUFaUUJ6QUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBRUFBQUFBQUFBQUFnQUFBQUFBbmdBQUFHWUFid0IxQUc0QVpBQnlBSGtB?= =?us-ascii?Q?WHdCd0FHRUFjZ0IwQUc0QVpRQnlBSE1BWHdCekFHMEFhUUJqQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQVFBQUFBQUFBQUFD?= =?us-ascii?Q?QUFBQUFBQ2VBQUFBWmdCdkFIVUFiZ0JrQUhJQWVRQmZBSEFBWVFCeUFIUUFi?= =?us-ascii?Q?Z0JsQUhJQWN3QmZBSE1BZEFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUJBQUFBQUFBQUFBSUFBQUFBQUo0QUFBQm1B?= =?us-ascii?Q?RzhBZFFCdUFHUUFjZ0I1QUY4QWNBQmhBSElBZEFCdUFHVUFjZ0J6QUY4QWRB?= =?us-ascii?Q?QnpBRzBBWXdBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUdZQWJ3QjFBRzRBWkFCeUFI?= =?us-ascii?Q?a0FYd0J3QUdFQWNnQjBBRzRBWlFCeUFITUFYd0IxQUcwQVl3QUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBUUFBQUFBQUFB?= =?us-ascii?Q?QUNBQUFBQUFDZUFBQUFad0IwQUhNQVh3QndBSElBYndCa0FIVUFZd0IwQUY4?= =?us-ascii?Q?QWRBQnlBR0VBYVFCdUFHa0FiZ0JuQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBSjRBQUFC?= =?us-ascii?Q?ekFHRUFiQUJsQUhNQVh3QmhBR01BWXdCdkFIVUFiZ0IwQUY4QWNBQnNBR0VB?= =?us-ascii?Q?YmdBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUVBQUFBQUFBQUFBZ0FBQUFBQW5nQUFBSE1BWVFCc0FHVUFjd0Jm?= =?us-ascii?Q?QUhFQWRRQnZBSFFBWlFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFRQUFBQUFB?= =?us-ascii?Q?QUFBQ0FBQUFBQUNlQUFBQWN3QnVBSEFBY3dCZkFHd0FhUUJqQUdVQWJnQnpB?= =?us-ascii?Q?R1VBWHdCMEFHVUFjZ0J0QUY4QU1RQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFCQUFBQUFBQUFBQUlBQUFBQUFKNEFB?= =?us-ascii?Q?QUJ6QUc0QWNBQnpBRjhBYkFCcEFHTUFaUUJ1QUhNQVpRQmZBSFFBWlFCeUFH?= =?us-ascii?Q?MEFYd0J6QUhRQWRRQmtBR1VBYmdCMEFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBRUFBQUFBQUFBQUFnQUFBQUFBbmdBQUFIWUFad0JmQUdzQVpR?= =?us-ascii?Q?QjVBSGNBYndCeUFHUUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQVFBQUFB?= =?us-ascii?Q?QUFBQUFDQUFBQUFBQT0iLz48L21ldGE+?= authentication-results: ffwll.ch; dkim=none (message not signed) header.d=none;ffwll.ch; dmarc=none action=none header.from=synopsys.com; x-originating-ip: [95.136.124.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ffc68daf-8a54-44f3-1e02-08d7f1a3b864 x-ms-traffictypediagnostic: CH2PR12MB4102: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-forefront-prvs: 03950F25EC x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cZPRcTdFE0NCfplSIL+aN0BmWuPVBEAV10B4ARkRHDI83nzsJHYbE8X3BjU0BsR5fkGToeUDUC0CzBZXgQZwuIk7nNVhmSsMrBNL1wlvoMmOwmjV/CoKdDO82v2bhgaudqOmVYK7iIx+IsJUsfviyB2Vya9HedBeX5kjgd0LB8HjX/BcfSL/lBFBiKrYmkKNNCW1JmqZTGU8SNn9Efzs5eMS1O4vCnj9lmFwXhLTrEI9fMYtA/Kqp665UYXAJfwvOu5RvsRne8TPfIZY3yL2r7pyjy9T4XA07KuDnz/qi80h9sMmgR4gd0gpenKR2AzYIQqE3EpS/WZ4mKRrCKCcJ3HM8Ila03UzJOx7LNNtZBACgbM32pMEaVMraix06ZvLw8XURr3SEwrOZQiLCq9h+LpdO5zNhXQtp4WOBKvjLBdQiES+YalA/NxYZgHDvIfhSw65MwOOrpjUFMimlkn6UbDYucS5P/WYBeOEWS6AWlHh8W1GedbceoxwFxETC6D5Z0jLPDQLqQyAtrmVal8avhHGIUwS7N33+oV+hl3Mf9uDz6hHnMtavmcVlmWfL4edId2Aro4UiWLyFuzs+urXkUsrO2uRD68qI6U6EJDNZBk= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3782.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(366004)(136003)(376002)(39860400002)(346002)(396003)(33430700001)(8676002)(86362001)(6916009)(107886003)(8936002)(30864003)(186003)(26005)(76116006)(316002)(4326008)(54906003)(66476007)(66556008)(71200400001)(66946007)(66446008)(52536014)(7696005)(6506007)(33656002)(966005)(33440700001)(478600001)(2906002)(64756008)(5660300002)(83080400001)(55016002)(9686003)(579004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: UTSJPiM+oxk9ucOQj/uMiLcOkAqcepXcGX/yjKhafa/Dy2ylgm7VYjIOr6hON+ByNDAq5R9uiG73dQFy5r7GiDDeptDs2Vpvgbkf8ASuX++qYu7n039dWJJD0/EvodO0cJwwfbSrwDPz9z5rD1eddBp52BqoSeSYz5cBcVh2ukEkDm/CjgLHv9oBMa7kMRu2UqVxxGv4YqeogdrLNxruDAt/sgvcgbxIAun511NbjkajjyYaMLGzCRDwVl4Tlh8te76UlbiopxNK0kX4FNMR+9OWstiIc18Pdb+cqh/sMzEz3VpfArJ9ttA4O8ADfcL4sL2TxA6iDUbDdXiJzYxCOli//zM8DT/ZDwfctRJRsDeSzeSsJRCeT80b7Jb2p47Naa6Qt+Rg49CfgCNTq4+XFSs1G2/6qEmqxj5DjwvH6DdfbKyzne1o1KcwFY3aAcuJ/xqPCui0l/5Oav8IivG29BZrlClpbNhW8Og+Fs+FTUrnw/T4hh2f+OUDv0JiWXPz9tgwdej+ByJW1v8fTLnb5I/8M2CHo8vwuHdglT+CEkqFy61yLhDgaDvN7R80AQchTJDp7Uf4+uPkYtv9Y8WDCzfAJlj49Q71ROQOBHMqpROswOFQyEXzMWSXJ9sQWi7wAAX1VuZYpI8iBdb2p7XAAwfUwpniSZYwVl17TSifdCYJ6VEa0md5glt7eOMbG8NXZT9/Ej2BQoA+cMzzMxjy8n6ltIIsTadSDW6JVqv1NniHhVgxMo829Qt/BSLs6xXCGoNBd47f7+XlEMcHam80lzI12DeWYT2Gu2bzPW13qms= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: ffc68daf-8a54-44f3-1e02-08d7f1a3b864 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2020 09:56:17.0817 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: c33c9f88-1eb7-4099-9700-16013fd9e8aa X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 29e9d+mVtj40Gq7er+PSAyfWizqF7ZmQ0S5Qcctc32lNlxE5HVinZFqPYNJmSalD8Uvq1s/Py5ROEUSxwQgBlg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4102 X-OriginatorOrg: synopsys.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Daniel Vetter Date: Tue, Apr 28, 2020 at 16:28:15 > On Mon, Apr 27, 2020 at 04:00:35PM +0200, Angelo Ribeiro wrote: > > Add Synopsys DesignWare IPK specific extensions for Synopsys DesignWare > > MIPI DSI Host driver. > >=20 > > Cc: Maarten Lankhorst > > Cc: Maxime Ripard > > Cc: David Airlie > > Cc: Daniel Vetter > > Cc: Sam Ravnborg > > Cc: Gustavo Pimentel > > Cc: Joao Pinto > > Signed-off-by: Angelo Ribeiro >=20 > I've dumped this on a pile of bridge drivers by now, but I don't think th= e > dw-mipi-dsi organization makes much sense. >=20 > I think what we'd need is: >=20 > - drm_encoder is handled by the drm_device driver, not by dw-mipi-dsi > drm_bridge driver >=20 > - the glue code for the various soc specific implementations (like ipk > here) should be put behind the drm_bridge abstraction. Otherwise I'm no= t > really seeing why exactly dw-mipi-dsi is a bridge driver if it doesn't > work like a bridge driver >=20 > - Probably we should put all these files into drm/bridge/dw-mipi-dsi/ >=20 > - drm_device drivers should get at their bridges with one of the standard > of helpers we have in drm_bridge, not by directly calling into a bridge > drivers. >=20 > I know that dw-hdmi is using the exact same code pattern, but we got to > stop this eventually or it becomes an unfixable mess. > -Daniel Hi Daniel, Sorry for the late answer. I understand what you stated and the conversion of this driver in a help library could be a good solution since you can use the DSI as bridge or as encoder, as your pipeline requires. Also most of the code implemented by each glue is essential PHY related, the development of a PHY driver could make this more clear. However, this needs a lot of work and consensus. Do you think that we can go ahead with this driver and do the rework later? I'm available and interested to help on this rework. Thanks, Angelo=20 >=20 > > --- > > Changes since v3: > > - Rearranged headers. > > --- > > drivers/gpu/drm/ipk/Kconfig | 9 + > > drivers/gpu/drm/ipk/Makefile | 2 + > > drivers/gpu/drm/ipk/dw-mipi-dsi-ipk.c | 557 ++++++++++++++++++++++++++= ++++++++ > > 3 files changed, 568 insertions(+) > > create mode 100644 drivers/gpu/drm/ipk/dw-mipi-dsi-ipk.c > >=20 > > diff --git a/drivers/gpu/drm/ipk/Kconfig b/drivers/gpu/drm/ipk/Kconfig > > index 1f87444..49819e5 100644 > > --- a/drivers/gpu/drm/ipk/Kconfig > > +++ b/drivers/gpu/drm/ipk/Kconfig > > @@ -11,3 +11,12 @@ config DRM_IPK > > Enable support for the Synopsys DesignWare DRM DSI. > > To compile this driver as a module, choose M here: the module > > will be called ipk-drm. > > + > > +config DRM_IPK_DSI > > + tristate "Synopsys DesignWare IPK specific extensions for MIPI DSI" > > + depends on DRM_IPK > > + select DRM_DW_MIPI_DSI > > + help > > + Choose this option for Synopsys DesignWare IPK MIPI DSI support. > > + To compile this driver as a module, choose M here: the module > > + will be called dw-mipi-dsi-ipk. > > diff --git a/drivers/gpu/drm/ipk/Makefile b/drivers/gpu/drm/ipk/Makefil= e > > index 6a1a911..f22d590 100644 > > --- a/drivers/gpu/drm/ipk/Makefile > > +++ b/drivers/gpu/drm/ipk/Makefile > > @@ -2,3 +2,5 @@ > > ipk-drm-y :=3D dw-drv.o dw-vpg.o > > =20 > > obj-$(CONFIG_DRM_IPK) +=3D ipk-drm.o > > + > > +obj-$(CONFIG_DRM_IPK_DSI) +=3D dw-mipi-dsi-ipk.o > > diff --git a/drivers/gpu/drm/ipk/dw-mipi-dsi-ipk.c b/drivers/gpu/drm/ip= k/dw-mipi-dsi-ipk.c > > new file mode 100644 > > index 0000000..f8ac4ca > > --- /dev/null > > +++ b/drivers/gpu/drm/ipk/dw-mipi-dsi-ipk.c > > @@ -0,0 +1,557 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (c) 2019-2020 Synopsys, Inc. and/or its affiliates. > > + * Synopsys DesignWare MIPI DSI solution driver > > + * > > + * Author: Angelo Ribeiro > > + * Author: Luis Oliveira > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include