Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: ISHQmuRW9w1YFGWWOyPWjyNvV1MI44mFgIWja1OcJkdhQ+l75JfsQ+XZHVqPqxLVJgik4UMYg2
 p1hu8jNv26jg==
IronPort-SDR: BuypfD8hgJq/oZvch/8WnxQawyfcaQENOeVKmR67ET/zyw/t1ivmyxIrszOzqaTax7ItuUiu5K
 SEqzbQbOY/1A==
Subject: Re: [PATCH] serial: lantiq: Add x86 in Kconfig dependencies for
 Lantiq serial driver
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        andriy.shevchenko@intel.com
References: <96fd193c0a8939d27641ff93573545c02313048f.1588577002.git.rahul.tanwar@linux.intel.com>
 <20200505142504.GA832370@kroah.com>
 <3aa4aac0-a9d2-5ab2-e9c9-c7f3bd16da96@linux.intel.com>
 <20200506064148.GA2266968@kroah.com>
From:   "Tanwar, Rahul" <rahul.tanwar@linux.intel.com>
Message-ID: <efa6660e-f572-a884-5d9c-5ad92230944b@linux.intel.com>
Date:   Wed, 6 May 2020 15:00:34 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <20200506064148.GA2266968@kroah.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 6/5/2020 2:41 pm, Greg KH wrote:
> On Wed, May 06, 2020 at 12:49:57PM +0800, Tanwar, Rahul wrote:
>> On 5/5/2020 10:25 pm, Greg KH wrote:
>>> On Mon, May 04, 2020 at 04:03:52PM +0800, Rahul Tanwar wrote:
>>>> Lantiq serial driver/IP is reused for a x86 based SoC as well.
>>>> Update the Kconfig accordingly.
>>>>
>>>> Signed-off-by: Rahul Tanwar <rahul.tanwar@linux.intel.com>
>>>> ---
>>>>  drivers/tty/serial/Kconfig | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
>>>> index 0aea76cd67ff..4b0a7b98f8c7 100644
>>>> --- a/drivers/tty/serial/Kconfig
>>>> +++ b/drivers/tty/serial/Kconfig
>>>> @@ -1035,7 +1035,7 @@ config SERIAL_SIFIVE_CONSOLE
>>>>  
>>>>  config SERIAL_LANTIQ
>>>>  	bool "Lantiq serial driver"
>>>> -	depends on LANTIQ
>>>> +	depends on (LANTIQ || X86) || COMPILE_TEST
>>>>  	select SERIAL_CORE
>>>>  	select SERIAL_CORE_CONSOLE
>>>>  	select SERIAL_EARLYCON
>>>> -- 
>>>> 2.11.0
>>>>
>>> Any reason this can't also be a module?
>> Thanks a lot for accepting the patch. This driver is also used for
>> console during bootup so we always have it as built in.
> So no generic kernel images can ever be made for this driver?  That's
> not good, what about systems that have this serial port but does not
> care about the console?
>
> That's just ensuring that it will not be built into any distro kernel
> images, I suggest fixing this up please.

I understand your concern. I will send out another incremental patch
series to fix it assuming that this Kconfig change is already merged
in tty tree. Thanks.

Regards,
Rahul

> thanks,
>
> greg k-h