Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp1723766ybj; Wed, 6 May 2020 04:15:56 -0700 (PDT) X-Google-Smtp-Source: APiQypJ1RW57ElAa57iznJx3CvbePZ/v8mPKlP6RZJ9BSpyQNL75r3cVw9xGA7UrR3o/d0L+InN3 X-Received: by 2002:aa7:dc4b:: with SMTP id g11mr6052718edu.223.1588763756051; Wed, 06 May 2020 04:15:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588763756; cv=none; d=google.com; s=arc-20160816; b=Lv2yBc38sc/ngYxEq+2I4G5sfFPQZv8q6rVkNQ2q6sI3mtvhgQqS1k4DjGcpN1w3fN V2rgEl0s6PYb/qT2VvCkbjZIvAEmPrx1dITqHyUq1EHehjLBY5e04g/Ar3FK8H/l68Wh MuYQiRYJfknGiQK++ntrOupIANVgUFlsZp78ts+HUkCjQ4AZwBMxDx8zLRxt0meDIjfC lRtjOlYR1wiiMqsVMYorv4GOC4zD9aVM/Fc2/vfmBCtxLoP45/DA0KZ1Io77dAcLtFWB +HAEZqUXiIfVwCMIUQWz5/Kb1HVMOllyVEEQx3hVePUjcBmlFSfbZqqr6kd+wUqJG9wW EnZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=A5mHBUCJf7MdjK71bAXmz5Z9cAImGkmNTVaeveSqWxc=; b=AJp85HF1aTBFx38q22e89OCFuFovvksTz5dbmfUi2+IPrCiIiByO+Hl6cwBCh3xE7W mdxRlZtAQE6V4SeOtq0X0kwtpmmXYNkxFCPGVbNFrBW0PIskDqXuYRr/utt9gQk1b9MV nmcLmKk6ZcSeQanOx0HhU8r3ha+RKz+ctHPhowAzyamORvn2RpRgy5Qtc1fN7/rNa2Rz r1MwpaulCUJA4nYu2j4dTd7+THow6PmooH+iql/LTwC4F45fGPqIwIXvizUdkEsF1jvO rMIS85hXAb6TBx1hVx+AfnrW7i4B62jyqxhU86/hJde2oUXvRFbxtuPR9AAmsVsD0+J7 NhlA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n8si156183ejl.78.2020.05.06.04.15.33; Wed, 06 May 2020 04:15:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727992AbgEFLFm (ORCPT + 99 others); Wed, 6 May 2020 07:05:42 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:3817 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727959AbgEFLFm (ORCPT ); Wed, 6 May 2020 07:05:42 -0400 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 677F674154628CBA8447; Wed, 6 May 2020 19:05:38 +0800 (CST) Received: from huawei.com (10.67.174.156) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.487.0; Wed, 6 May 2020 19:05:29 +0800 From: ChenTao To: CC: , , , , Subject: [PATCH -next] input/keyboard/qt1050: fix unsigned comparison with 0 Date: Wed, 6 May 2020 19:04:45 +0800 Message-ID: <20200506110445.111576-1-chentao107@huawei.com> X-Mailer: git-send-email 2.22.0 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.67.174.156] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes warning because num is u32 and can never be negtative drivers/input/keyboard/qt1050.c:371:18: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] if (button.num < 0 || button.num > QT1050_MAX_KEYS - 1) Reported-by: Hulk Robot Signed-off-by: ChenTao --- drivers/input/keyboard/qt1050.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/keyboard/qt1050.c b/drivers/input/keyboard/qt1050.c index 403060d05c3b..a9ac99f62e39 100644 --- a/drivers/input/keyboard/qt1050.c +++ b/drivers/input/keyboard/qt1050.c @@ -368,7 +368,7 @@ static int qt1050_parse_fw(struct qt1050_priv *ts) dev_err(dev, "Button without pad number\n"); goto err; } - if (button.num < 0 || button.num > QT1050_MAX_KEYS - 1) + if (button.num > QT1050_MAX_KEYS - 1) goto err; ts->reg_keys |= BIT(button.num); -- 2.22.0