Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 6 May 2020 13:49:32 +0100
From:   Sudeep Holla <sudeep.holla@arm.com>
To:     Hanjun Guo <guohanjun@huawei.com>
Cc:     Xiongfeng Wang <wangxiongfeng2@huawei.com>, rjw@rjwysocki.net,
        viresh.kumar@linaro.org, linux-kernel@vger.kernel.org,
        linux-pm@vger.kernel.org, john.garry@huawei.com,
        Jonathan Cameron <jonathan.cameron@huawei.com>,
        Souvik Chakravarty <Souvik.Chakravarty@arm.com>,
        Thanu Rangarajan <Thanu.Rangarajan@arm.com>
Subject: Re: [RFC PATCH] cpufreq: add support for HiSilicon SoC HIP09
Message-ID: <20200506124932.GA20426@bogus>
References: <1588227599-46438-1-git-send-email-wangxiongfeng2@huawei.com>
 <20200430095559.GB28579@bogus>
 <3ba950dd-4065-e4a5-d406-dc5c6c1781a7@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3ba950dd-4065-e4a5-d406-dc5c6c1781a7@huawei.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

+ Thanu, Souvik who work with ASWG

On Wed, May 06, 2020 at 05:36:51PM +0800, Hanjun Guo wrote:
> Hi Sudeep,
>
> On 2020/4/30 17:55, Sudeep Holla wrote:
> > On Thu, Apr 30, 2020 at 02:19:59PM +0800, Xiongfeng Wang wrote:
> > > HiSilicon SoC has a separate System Control Processor(SCP) dedicated for
> > > clock frequency adjustment and has been using the cpufreq driver
> > > 'cppc-cpufreq'. New HiSilicon SoC HIP09 add support for CPU Boost, but
> > > ACPI CPPC doesn't support this. In HiSilicon SoC HIP09, each core has
> > > its own clock domain. It is better for the core itself to adjust its
> > > frequency when we require fast response. In this patch, we add a
> > > separate cpufreq driver for HiSilicon SoC HIP09.
> > >
> >
> > I disagree with this approach unless you have tried to extend the CPPC
> > in ACPI to accommodate this boost feature you need. Until you show those
> > efforts and disagreement to do that from ASWG, I am NACKing this approach.
>
> Unfortunately we are not in ASWG at now, could you please give some
> help about extending CPPC in ACPI to support boost feature?
>

You may have to provide more details than the commit log for sure as I
haven't understood the boost feature and what is missing in ACPI CPPC.

--
Regards,
Sudeep