Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp1857949ybj; Wed, 6 May 2020 06:42:45 -0700 (PDT) X-Google-Smtp-Source: APiQypI0b5fgTFJPsb4hrYn/gpZjTxBy/5SgqszjZRRpn8HtVsXGPNYpt9EwiR4nNd7PZOjaaBCb X-Received: by 2002:aa7:cf94:: with SMTP id z20mr6620915edx.302.1588772565054; Wed, 06 May 2020 06:42:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588772565; cv=none; d=google.com; s=arc-20160816; b=u0Yv5n1hwvVbOtuggA4j7le0pNKwrRVjggDe+BvxbECNFdc59TRivhvzwhi/Lp58dI oiCrvhneeSjFCi09yXinVhAZEGmrDUT8b/2f986FEIBWbLKWuCV0Mj3bTcI1+esQ0BTx l/a1lBIPMJKejHTlOC3QMsKDFU8Msi43frEFQx/clYvWUTyk/43UXTqBCMvgpFE2DJdl 7H/ol17bgC8/3RxFO8EDfOPAQuR1D6pnTlrxGg7JkZUpF8hMPXThZVrssc1sfUNx77RU /6WfWlA2FPcZ5F/ZQHegLdUDXlrNOlYPWLMabN2HwEHdH4fnRmnDAbLSUohmxuqXg/EY fSXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=hqJdqoHlgiiR8BucDATayDArInMZGbky1LhSSGtXWoE=; b=tzTVDc7SIPPxAp7PuZgrMsbB9k570wPCyRMHRHmbqFO1fMhW4DjizJu+Lg9maZEmLv 4LdBB1wg5GoLxgsXN3AUur+38mj5kBUY2efhYfS4rCM1nk17e9g7hfuDDWemQ7i51V3q 7aMA4DPCrRXn9dXn6zkeQcl+NKpI8GlsOQsZ0rKOFTpsVIY5rgQyzBuWAkA460rGolS8 zK/aJxvXR5mGPaB73Xl5jar88+5WA32G88/yDX0+f1WcFA4Sg0v3O6szTs2QggHpoMR3 1HJDQTx3xz0Po+HWeX16PW8G9szz5bK9o83g80AOJ3LcOWy8QvQqcTirb7k3r+uXJGBe NI7w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t26si1035699edw.567.2020.05.06.06.42.20; Wed, 06 May 2020 06:42:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728297AbgEFNiH (ORCPT + 99 others); Wed, 6 May 2020 09:38:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:47098 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728081AbgEFNiH (ORCPT ); Wed, 6 May 2020 09:38:07 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B556C20575; Wed, 6 May 2020 13:38:06 +0000 (UTC) Date: Wed, 6 May 2020 09:38:05 -0400 From: Steven Rostedt To: Joel Fernandes Cc: Xiao Yang , linux-kernel@vger.kernel.org, Ingo Molnar Subject: Re: [PATCH] kernel/trace: Stop and wait for kthread on preempt irq module unload Message-ID: <20200506093805.1f86f3f0@gandalf.local.home> In-Reply-To: <20200429191224.GA75562@google.com> References: <20200424223630.224895-1-joel@joelfernandes.org> <5EA80319.7080005@cn.fujitsu.com> <20200428104409.0995ceb0@gandalf.local.home> <20200428104543.3926eaaf@gandalf.local.home> <5EA96AE8.6000707@cn.fujitsu.com> <20200429123141.580f89ce@gandalf.local.home> <20200429191224.GA75562@google.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 Apr 2020 15:12:24 -0400 Joel Fernandes wrote: > > Mine ;-) > > > > The "kthread_should_stop()" is the normal way to end kernel threads. Using > > get/put is not the orthodox way. > > Agreed :-) thanks. And while I'm working on getting a new "urgent" branch out, I found this code is buggier than I thought. I'll have a new patch soon. -- Steve