Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp1889663ybj; Wed, 6 May 2020 07:12:01 -0700 (PDT) X-Google-Smtp-Source: APiQypK4o7gLhm1EvFySgdl5WPdLEkKritS1xTwXgrqxC2yKwgWTr7WvChry3KCMQ04KZyDpR6ga X-Received: by 2002:a17:906:16ce:: with SMTP id t14mr7650900ejd.366.1588774321165; Wed, 06 May 2020 07:12:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588774321; cv=none; d=google.com; s=arc-20160816; b=tfZg6O//WPgX+0TCsepUGkijOmYGUoQ7UE+kAbRnIw2Qws4sE3ak5sSixRuiZFNqpk EciCot8YD/WI/5uAwrFmWcu6h115jfeNWBQCRbPzH2qBmixO3GV6mMJv19jm1aoIawsd cQOD+dm7G95o4hryPyBq76cCOXIuY/kbY0X9eAgN+KipoSphTcPf1zlWYlM1kZbkHtNO wFWpuI9z1P4GXzlyALw1CeLQgqCA69BrnQePsGRjlu2KCEAd/Q9bDNaZi5VZ+ijwxBbF RiNXFG7TB+MJ8lGX5o/o94AmmO3MQKipU/i9yj8jvWy/Uu75KsIqhX8Moy4BQRAE7mWP Q//A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=GgWZf/AHQ77atT4TDWUSsDyFTHq1Tj53V4P+dx8R7u4=; b=FbFQYxZAGx0dpGO2uCu32Cy9EfgBgIH+SK/ihFLMr+9DmbjY/YScjXaXCORjrh/G+h yNZ/IZ7NXIvJUfM2S5XcyungyOHUGFffVxl+1LZAOAGCdWnpmPU7l1R3lyz5XezBeZPl 0RGrWiw7SclZ7Scqf064LluawwzPoKhfBL/1sOZNg7n9Rrw4f2PeW+Qqzrf44cT2V2aw 8Anrj/0aS6nmpLahfNGTUn1mf91iSqWr9TkkBKXqLXZ7K5ACSl0gwbpq2KejgQ4tqhjX 0PrScZiSsm0MpSFml8sBlpi9AtpixDoHQifpjpCxz+Uefd0X11fi9bMLlJoSt2PkE/P5 Norg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l2si1278014ejz.185.2020.05.06.07.11.38; Wed, 06 May 2020 07:12:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728947AbgEFOJ3 (ORCPT + 99 others); Wed, 6 May 2020 10:09:29 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:3871 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725915AbgEFOJ3 (ORCPT ); Wed, 6 May 2020 10:09:29 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id B35597B26A92DDEEEFB8; Wed, 6 May 2020 22:09:18 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.487.0; Wed, 6 May 2020 22:09:11 +0800 From: Wei Yongjun To: Matthias Brugger , Enric Balletbo i Serra CC: Wei Yongjun , , , , Subject: [PATCH -next] soc: mediatek: Missing platform_device_unregister() on error in mtk_mmsys_probe() Date: Wed, 6 May 2020 14:13:17 +0000 Message-ID: <20200506141317.119537-1-weiyongjun1@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add the missing platform_device_unregister() before return from mtk_mmsys_probe() in the error handling case. Fixes: 667c769246b0 ("soc / drm: mediatek: Fix mediatek-drm device probing") Signed-off-by: Wei Yongjun --- drivers/soc/mediatek/mtk-mmsys.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c index 05e322c9c301..05ce4cb464b0 100644 --- a/drivers/soc/mediatek/mtk-mmsys.c +++ b/drivers/soc/mediatek/mtk-mmsys.c @@ -312,8 +312,10 @@ static int mtk_mmsys_probe(struct platform_device *pdev) drm = platform_device_register_data(&pdev->dev, "mediatek-drm", PLATFORM_DEVID_AUTO, NULL, 0); - if (IS_ERR(drm)) + if (IS_ERR(drm)) { + platform_device_unregister(clks); return PTR_ERR(drm); + } return 0; }