Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
From:   =?UTF-8?B?5Lq/5LiA?= <teroincn@gmail.com>
Date:   Wed, 6 May 2020 22:46:42 +0800
Message-ID: <CANTwqXAwbiGwd3-6ShQw-kvnwNPk6Ev2Sc1yMTVH4+1=mxRQsA@mail.gmail.com>
Subject: [BUG]is there a refcount leak in function mei_me_cl_rm_by_uuid?
To:     tomas.winkler@intel.com
Cc:     linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

HI, all
When reviewing function mei_me_cl_rm_by_uuid=EF=BC=8C I notice that functio=
n
__mei_me_cl_by_uuid increases me_cl refcount
and function _mei_me_cl_del delete a list node with decrement me_cl
refcount , actually here cause a refcount leak as we haven't release
the refcount
by __mei_me_cl_by_uuid  ?
similar issue happens in mei_me_cl_rm_by_uuid_id too.

void mei_me_cl_rm_by_uuid(struct mei_device *dev, const uuid_le *uuid)
{
    struct mei_me_client *me_cl;

    dev_dbg(dev->dev, "remove %pUl\n", uuid);

    down_write(&dev->me_clients_rwsem);
    me_cl =3D __mei_me_cl_by_uuid(dev, uuid); /* increase a refcount */
    __mei_me_cl_del(dev, me_cl); /* release the refcount with a list
node deteled */
    up_write(&dev->me_clients_rwsem);
}

Best regards,

Lin Yi.